From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0041.outbound.protection.outlook.com [104.47.34.41]) by dpdk.org (Postfix) with ESMTP id E54A21B1A5 for ; Thu, 21 Sep 2017 12:38:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Z06iFGXw2HkOmN0lKWF0v5h/r6ayLwdVCLN76fSEh8U=; b=AusLwkamHoFIWEqOsYruGQujC/M61D1sVKY4O7SCPfYFlBxs/2A5ZQWXIxcBDgH0PST80CxqbzrgUyfDYqkggAiB3Uk4426NlweQctMrAuzVXeIXitwRg1YNQvo0CxV1apVzWVWMJCUgiSvlxbSL5Bs91Z4UgInQpjoFqw5ysj4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from PBHAGAVATULA-LT (111.93.218.67) by DM5PR07MB3466.namprd07.prod.outlook.com (10.164.153.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Thu, 21 Sep 2017 10:38:42 +0000 Date: Thu, 21 Sep 2017 16:08:09 +0530 From: Pavan Nikhilesh Bhagavatula To: "Dumitrescu, Cristian" , "stephen@networkplumber.org" Cc: dev@dpdk.org Message-ID: <20170921103808.GA16371@PBHAGAVATULA-LT> References: <1504795187-11087-1-git-send-email-pbhagavatula@caviumnetworks.com> <1505921833-2286-1-git-send-email-pbhagavatula@caviumnetworks.com> <3EB4FA525960D640B5BDFFD6A3D891267BABEA09@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891267BABEA09@IRSMSX108.ger.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0098.INDPRD01.PROD.OUTLOOK.COM (10.174.144.14) To DM5PR07MB3466.namprd07.prod.outlook.com (10.164.153.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2191d60d-e913-40c4-496e-08d500dceebf X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR07MB3466; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 3:t/Y+RFS0gBrJvy8MMR/9ypEKZ9F1IGvf+v4JIVaA34LYCfll/rFRJALlklNi65tVHA5dKVOU6gxO/18aj86PWzTJfzLw33hj1PNX573SnhrqqI3Zd0L4itwOqCfBfqvJ9Oc8QsZvAaTSF/fJBMKTY26i/cQFrHADUTI+tP7oJ+KVXoDbMmWbyLXcNzJU6kvllXKjIT3WMOeWXAiceg4a1wmvL/YhT5ePZ8j6/gPnlV5iWGUI0Bvf+wflv2hm/3Km; 25:42N6SCPOMi4MWuCDL3+wlaFgMtYFCLanQ/HgnZQmQvTe3Bp+vHx83d7SuzH//6LZnZW7f/zPsA+hCtqnYU1JOp2W1CNmUxVZ6IHyEittam/PQRRtYzV1i3jsOLmVW5X5z0TRSVGLyy3uffQLdcrX9B8fScPVPxpQ3jNISJ+DIUiKgk8bqs/uoZPw/BbEkQgqGh9+0fw/u6RVnX3SjWbAUrEW8MxozUxp2fUNXkncqSJXO+4qatoZEFyRocjPIqJ0K9VG4HgApO5BxCoJ2gPRD5vlXA1AhUzHtcVYaXXIvzN4/aJolV1gcPmpjrCfT2vEhq9bKRau5QaITnQ1B7+RQQ==; 31:Y63Mfaz3niqhiQq1rIao62YqNhjOO6YrMlcirTpKKZouVETcVNXtErpwb8wOQLTvQSuFYPpydiBM5bTLxdjfF/jCLw4j5Rukwp6lO4EA7uVWzDisHkqSjE+KSyytE5lIF8JtUSVMNMxZajodAIfYFybwmALKgLoJVvuT2vCmHUlyjwNIaMAwdg3+DcSVoP0hCbRBjXKLueJ27MXMBbGfyBKs+zPzg8fOxCSpxKZ0eoM= X-MS-TrafficTypeDiagnostic: DM5PR07MB3466: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 20:sE1ufN865vdWZUrxE3ROqU3S4vsz034Gu2LbSDId790YVzxWi4Hpmwea9HHc89qGQyGddQeyGfV+DNzIRIu9YXAwJSPCiy+lYTyyG37S+mcR++u8d+iQSF/8NyVuPTTM3dTF5wlO4x1hWQgsbdPul437adk5tnJ0YPviiovuTi3iNaG9YVUv/CCMcXLkKFrIeNdofuV0hYeGDoGmgStWFryN/jHL7jXZMAcrWTYYUxFGn1aRNtkhMV2frt4rjBalhVsYLD6PQ2jFz0TSVUTYp35SIm/N9nHdHp79/tvmeGf9e9qv97uB81xvi1QEyetCmtmrc9qu+wKktAt7nOz3PaXTyeHAMnbOeHQAep+q9ioX/7U9cWMtKsAB1vgveT3OznBLNETUIgAiw6ho+4YSsfaRyQUuPFaN51q5w7klOndoRmal//ytJvR+IIch2cwI90PAqRf8q/JWQBAJcVtZiCeY388pHap10vpiG+C7IGrqZNpJpP0ZnjGM/uI2vbikEoJnF4YM4jihNDTcHFiNAUiMLyutLRPPTX1EDj94BP+z0d+jIeY2eNVBTO7MmI3OMcrZ/qqrLSqq75iC12PvgHh08o7xrAxMpi/VPKAfc7s= X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3466; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3466; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 4:HyHkFjsJ2x39ipDNS+DMBeJq+6FFC3K3z+hvvORMICNvAaOhRpwG9WcYa+HtHYtpJp47UMWMa/0sN/pEPma/XaqEuPQwtwXxrkpQQ4pZOXfLXQ9Od+br4WKlmoFaUfNjPXs0OYnwcT67sclj2OhlQJ4stYByJDRs1sSxoy7qKDAcIIwb7gPllkyJRCLhvrh74tFEtmfjalJkVTW6qwOgOcxHFMzcH+v9a6i/eN+AE7q+YxwQjC9dvu4NEDYsbmHjeyZxC+DokwA0Pcjg0mu7g4AN2UQRQbcQecS3G/VjP/OKilgJ4vTFIKOT6Zjb9eHH7YRvTpGXJq8k34AOe8Lbeg== X-Forefront-PRVS: 04371797A5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(13464003)(189002)(377454003)(24454002)(199003)(81156014)(8676002)(16586007)(25786009)(53546010)(81166006)(2501003)(105586002)(33716001)(83506001)(6666003)(76176999)(8936002)(97736004)(50986999)(16526017)(1076002)(316002)(68736007)(42882006)(189998001)(110136005)(54356999)(50466002)(478600001)(9686003)(33656002)(101416001)(575784001)(66066001)(55016002)(305945005)(2950100002)(58126008)(3846002)(6116002)(47776003)(23726003)(7736002)(229853002)(106356001)(5009440100003)(5660300001)(2906002)(6246003)(53936002)(4326008)(6496005)(72206003)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3466; H:PBHAGAVATULA-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3466; 23:xgED/YMjT5wjwiBb71vkmOtSyQVSVcWASGA4WHD4v?= =?us-ascii?Q?DWwrFw2eBARgNJ9mwrpsIhnHgih9LFpJ8ILtMKgD11efPOJqv3ISySZn6NC7?= =?us-ascii?Q?Cnd6v5UIm4SwTVXMmIQ5Sc8oks9EgbWm0/kgbQ4B6QBi2qVBssBdWh04iILp?= =?us-ascii?Q?O2LT0hKPnGmlCcZuiigyHGEZ8Om+FSsFlDzASffoJ6mrWk98q+hlXO24n7pY?= =?us-ascii?Q?Icd2cYhXoA8kXADcz8I6nzmP0s4U0OhtRj65fVxWUvdYs9Qj6CfMM2fg6pPF?= =?us-ascii?Q?wDe9EujjqnHGIHB+Zh9GqrPfcv3YGLP1BA+8Z6h6E8aciBfXItoBMmgmBRC5?= =?us-ascii?Q?UImt1/NtJVo3klBAN7KiZmxxahMm13N+2XLTr+K/6DYCW96hG0OWZpdxzq4/?= =?us-ascii?Q?h5l/HS+l2TUazTFWxOfRPbri7x2IJAtyGo6wEtXXukpeJvgkj6CmBiiWu/M2?= =?us-ascii?Q?Wvl6AIsrtj9uU9ZXX6TUawpFK598NNlZ+sxFl0MYN37ETV8LtL6cC+iHbr7K?= =?us-ascii?Q?RctbAC6RhxYLnRrABTWafZUMrWvVh+sAHRyBlJs+PF0WhyfYb5Qx76ph/RIC?= =?us-ascii?Q?9OLX9oq+Ytw7wiWkEWtLHEmTfUeAu3GL/DqjHIvdV95ipFvz0cM298+fO4fC?= =?us-ascii?Q?xXZw6zzJvBRiOwDWIb7lhJe6OBaP15f5Ow9E3JbusviekY68n79UYbAQ+MzA?= =?us-ascii?Q?D6yEnHiv9U6x30dRnEz0j04Q/PXMB9LYXrXL4M9SfLfGe8gqzsFJxfeY8Ziq?= =?us-ascii?Q?OkLFyud7FT1nBMHHB8yPRiESnNuvlJwnljQ3QWb/LDBLZG/U9QkNBqqcgrWY?= =?us-ascii?Q?e36s+eYH0nM7KPNoIu2g3DvduFLCv11tGx+MEU76dqd8iXn1FMYSJ9p76enb?= =?us-ascii?Q?LhjO/DjBwG9PBGiwqqP781yHMx/XnYuXTLhEHsiENUm2t6M7RM+UCAwvFCgH?= =?us-ascii?Q?1douexriCplCFlmYMx0ZauHDnPSkqIzNqlT5yw5U+ocJo7MfJJCw2JDbcAgG?= =?us-ascii?Q?sXhU9+bFTLYxcck3Tr3IpFDOTIhqcRJxgArTBACrrUpSDNfmg6pmEN/je12u?= =?us-ascii?Q?4XbHuMe4nAKWxnkckoCjIyiSBKHIKXDI46GSowfdVXM3cMHByCOGwtwI4pzS?= =?us-ascii?Q?YdmGAHuO/0GZ8YLBLVVHJRFmHJafRw74sXhyhmjajDZH9Ftu72xkDy2ojUYU?= =?us-ascii?Q?S9vzb4Sx1wM2JVT5Mj4/q4SViKirIubETNB/Ngfr7HG0IM98XK3GdEYEj1IN?= =?us-ascii?Q?RWIv2tN+LUQjfiDh7uoT0Y+JYr5atsxu3hhHMtBtoyNgZcDMifbnwgTs8LsB?= =?us-ascii?Q?HOwOG2ZGTFWH56cXs3qaRZo64eCKmLwZ0oGoiXHUbKg++0rxqekecAXvHJoj?= =?us-ascii?Q?7racsFstYgcG5G46+1oIPy9KbU=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 6:YnQlDrxmtsHxkYkSr9g0qh5dNPK2AIw21MaUlRnbOleTHd5wKWJYJG6Jmb/Erge+9bcyKl7p/N3sIiSCNI0QRPM3NB3EyB72pWViKB5u2qRiQx0QjdSvXqIO5kVN+LkiCE3EFHSuthMH3iesaoINW94rrQxpffyFcwp1EsylmGNMQTea30+Y6o4p36AHbyq4jHM75jO36DzSYZixT9BfQpq83kJI8N3j8b+hlogKs+hF+nAUHaaXoBB7U9OBaUoupf8hZB3fZZ2H/cxd+XxA2ilSxZKmXP7Hx09gGjjgV0Hg7dQq44SdGMzbTouWD6qP5wHfGGSs+Fin211xVeEiUg==; 5:U5VbUegCATmRZJzeH0vAswJfxn6AALPT3B4Bx2NWepQYxTpe3tCcl75AaJYx1/9NFieJahqBUd8X/hh0ofScckh5f0Drj94IbIwZg6hVw6Scf85RZHlbHL1RvZ0kuj3zyeMsqMfNIKeQCgdR+YQYzQ==; 24:K2vuU8mN7Pxko1RGRbSQOg4uglCdEnxkwULWBky8s2vGbo8XbVgiCnUs1MceH1gGo/VD5MywrmBqGbiH8CRokuFZp0xVZ11pklLd1FMci0A=; 7:cIjiv62dykBeyKZV7v62wnSId/7xOV8zm8S77k7F6M2elNc3+bOpf+GeM2cOCBhRn5Yc2+6Flw7rOGVdaJLhj2QtHtHAFwaPnHXdKmXp8FTQvvFvohV6BzNbNX44FI3K4wZeRdxu03GPl8iu3FoB2YhdpNYHRhe4ZhJn/8FXEp/S7Y+nwwM6/MBjvMlK7dqOMX4zvGzakIRnbrl9TF+y/vTwDvRpkUqISt4gu767IqI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2017 10:38:42.6424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3466 Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 10:38:46 -0000 On Thu, Sep 21, 2017 at 10:25:18AM +0000, Dumitrescu, Cristian wrote: Hi Cristian, > Hi Pavan, > > Thank you, just a couple of minor issues below: > Sure will spin up a v3 with the mentioned changes. Thanks, Pavan > > -----Original Message----- > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Wednesday, September 20, 2017 4:37 PM > > To: Dumitrescu, Cristian ; > > stephen@networkplumber.org > > Cc: dev@dpdk.org; Pavan Bhagavatula > > > > Subject: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched > > > > From: Pavan Bhagavatula > > > > The librte_sched uses rte_bitmap to manage large arrays of bits in an > > optimized method so, moving it to eal/common would allow other libraries > > and applications to use it. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > > > v2 changes: > > - undo rte_bitmap.h cosmetic changes > > - update maintainer info > > > > lib/librte_eal/common/Makefile | 1 + > > lib/{librte_sched => librte_eal/common/include}/rte_bitmap.h | 0 > > lib/librte_sched/Makefile | 5 +++-- > > lib/librte_sched/rte_sched.c | 2 +- > > 4 files changed, 5 insertions(+), 3 deletions(-) > > rename lib/{librte_sched => librte_eal/common/include}/rte_bitmap.h > > (100%) > > > > diff --git a/lib/librte_eal/common/Makefile > > b/lib/librte_eal/common/Makefile > > index e8fd67a..c2c6a7f 100644 > > --- a/lib/librte_eal/common/Makefile > > +++ b/lib/librte_eal/common/Makefile > > @@ -42,6 +42,7 @@ INC += rte_hexdump.h rte_devargs.h rte_bus.h > > rte_dev.h rte_vdev.h > > INC += rte_pci_dev_feature_defs.h rte_pci_dev_features.h > > INC += rte_malloc.h rte_keepalive.h rte_time.h > > INC += rte_service.h rte_service_component.h > > +INC += rte_bitmap.h > > > > GENERIC_INC := rte_atomic.h rte_byteorder.h rte_cycles.h rte_prefetch.h > > GENERIC_INC += rte_spinlock.h rte_memcpy.h rte_cpuflags.h rte_rwlock.h > > diff --git a/lib/librte_sched/rte_bitmap.h > > b/lib/librte_eal/common/include/rte_bitmap.h > > similarity index 100% > > rename from lib/librte_sched/rte_bitmap.h > > rename to lib/librte_eal/common/include/rte_bitmap.h > > diff --git a/lib/librte_sched/Makefile b/lib/librte_sched/Makefile > > index 18274e7..9a28a9e 100644 > > --- a/lib/librte_sched/Makefile > > +++ b/lib/librte_sched/Makefile > > @@ -55,7 +55,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_SCHED) += rte_sched.c > > rte_red.c rte_approx.c > > SRCS-$(CONFIG_RTE_LIBRTE_SCHED) += rte_reciprocal.c > > > > # install includes > > -SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include := rte_sched.h > > rte_bitmap.h rte_sched_common.h rte_red.h rte_approx.h > > -SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include += rte_reciprocal.h > > +SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include := rte_sched.h > > rte_sched_common.h > > +SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include += rte_reciprocal.h > > rte_red.h > > +SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include += rte_approx.h > > > > These changes are not required, please just remove the rte_bitmap.h from this list with no other changes. > > > include $(RTE_SDK)/mk/rte.lib.mk > > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c > > index b7cba11..b3e0d4f 100644 > > --- a/lib/librte_sched/rte_sched.c > > +++ b/lib/librte_sched/rte_sched.c > > @@ -34,6 +34,7 @@ > > #include > > #include > > > > +#include > > Please #include at the end of the #include list. > > > #include > > #include > > #include > > @@ -44,7 +45,6 @@ > > #include > > > > #include "rte_sched.h" > > -#include "rte_bitmap.h" > > #include "rte_sched_common.h" > > #include "rte_approx.h" > > #include "rte_reciprocal.h" > > -- > > 2.7.4 > > Regards, > Cristian >