From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id EAED11B1A2 for ; Thu, 21 Sep 2017 14:04:54 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id m127so558218wmm.1 for ; Thu, 21 Sep 2017 05:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YDCDkI6QxyK2qngjJ6KYXgCduEnuxAmj0BnLSC2rLJc=; b=hhtG1pHTTPKVFHVaX/50+uiNS6/6NCZLe0t7l7dHb3rxmUJUj/StZsSrYKtsi/L74D CMMY9AL2jKyNkAElFF2cfIvVrYhFl8U8nGYPuPKTVe57citTlZwZNVzMc/We4wGFQH4i rm6e4oU9Vd+hm68COSTmiYWZwp2xLnt/2KGsbSAr2jYHVPQk1k1DlMtxN1mjVsLrVWTF YdtzsF/qwkFW8FOg7VFYy7PEcjCZCoRBTJq6NiZ3wvBq0zM/gIcg3D0sOuMIBW1E8tuQ reQFeZL1L7Wi9nMB5rpVk+qGnF9UDOKldO79D3W62meAchnPax2EwaVASvqzxhyxiR6/ Oyug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YDCDkI6QxyK2qngjJ6KYXgCduEnuxAmj0BnLSC2rLJc=; b=YPnM9KPmK7oUNugTdYtSix2mCemxdUkZKhByQX8IMmd1oI4tGplR0SRBEpB7AbXpA8 xac6gATmIPIwjYAOBv8ipyZ3UZx3AfXMDOOaizyMZIz8nFHlnAVHQYVXHYGNbfmCodKw wAV+VS+h0RUxlHHyPkYA8qRq6Rv4qKUAlcfHu2ayUgmetbz/cuekfdZpSlJtNqeRCCKJ TcrzTZ9M/t61+vs2FNKRUAuz38l/tbLwGynpgvlRfoWHpu01faCTSTjvWj4aHSa8IL+Q LakULjnnpTLvK1fXcGpIHZY2UV5UwCvQh8NnbT79ZPz3tdMN+tV+kJF3KOPRiolYEkcx mcoQ== X-Gm-Message-State: AHPjjUi2O5rThUfquvymYrKxEDUgHz9OgjoCvLHBg1cw+tbiaz66HDGs N/VHHlTNq38WdimjplGgzZjjwAhC2g== X-Google-Smtp-Source: AOwi7QCxLG3/9DhbWaUBcLQTjMcNTVeADr5za2Ug56bZaRc6vEDEJt0t9vXJcsKUafzz8nqx6ax1Wg== X-Received: by 10.28.139.208 with SMTP id n199mr893897wmd.29.1505995494617; Thu, 21 Sep 2017 05:04:54 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f89sm1349307wmh.18.2017.09.21.05.04.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 05:04:53 -0700 (PDT) Date: Thu, 21 Sep 2017 14:04:43 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: "Van Haaren, Harry" Cc: "dev@dpdk.org" Message-ID: <20170921120442.GC13383@autoinstall.dev.6wind.com> References: <1505994496-10141-1-git-send-email-nelio.laranjeiro@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] eal: fix service array initialisation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 12:04:55 -0000 Hi Harry, On Thu, Sep 21, 2017 at 11:53:48AM +0000, Van Haaren, Harry wrote: > > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Sent: Thursday, September 21, 2017 12:48 PM > > To: dev@dpdk.org > > Cc: Van Haaren, Harry > > Subject: [PATCH] eal: fix service array initialisation > > > > GCC is complaining on variable used without being initialised. > > > > dpdk.org/lib/librte_eal/common/rte_service.c: > > In function ‘rte_service_start_with_defaults’: > > dpdk.org/lib/librte_eal/common/rte_service.c:449:9: > > error: ‘ids[0]’ may be used uninitialized in this function [-Werror=maybe- > > uninitialized] > > ret = rte_service_map_lcore_set(i, ids[lcore_iter], 1); > > > > Fixes: 21698354c832 ("service: introduce service cores concept") > > Cc: harry.van.haaren@intel.com > > > > Signed-off-by: Nelio Laranjeiro > > Hi Nelio, > > Thanks for the patch - indeed this seems to be an issue. It was raised by Yang too > in this thread http://dpdk.org/ml/archives/dev/2017-September/076210.html > > Given I've asked for a v2 of that patchset, and it was posted earlier I'll suggest > to merge that one, if that's OK with you? Yes, it is. I have search for such patch, but it is not easy to find it. I will move this patch to superseded on the patchwork. > On another note, I'm curious why neither I or the automated build-system experienced this... I don't know either, I faced the issue on debian 8, on ubuntu 16.04 and redhat the issue is not visible. It becomes quiet complicate for a single guy to test on so many distributions ;) > Thanks for investigating / proposing a solution. -Harry Thanks, -- Nélio Laranjeiro 6WIND