From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0062.outbound.protection.outlook.com [104.47.32.62]) by dpdk.org (Postfix) with ESMTP id 2DE271B19D for ; Thu, 21 Sep 2017 14:20:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nHbptZ3Q0pywrY/ZOhl6mz+nIUhg2Mfi7sCYQFl6J6E=; b=BDtQFPgr3fmzriuoRCuDSKVceF+odSNJtlBrtxMdPvWmg2YIOeXzj+QmJuw3jutCtakLM0z9av32utBr6zcr/J8FDT/3iA7Odo4KzWE4YKy6bVOzlPOTzGmgssKqH7EndI3u6v2vrEyPvnJ4fDV7TbvhGRb1M0Y3tvMkOiPSLvI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 21 Sep 2017 12:20:53 +0000 Date: Thu, 21 Sep 2017 17:50:34 +0530 From: Jerin Jacob To: Gowrishankar Cc: dev@dpdk.org, Chao Zhu , Bruce Richardson , Konstantin Ananyev Message-ID: <20170921122033.GA20126@jerin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0077.INDPRD01.PROD.OUTLOOK.COM (10.174.144.145) To CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b207ef8-25fe-4e3c-60a1-08d500eb3542 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 3:q7TCUlOYbSXNOO9M2AKdrvNS+zhXxCpLBHyJGKChOsd7wcs6CTc8YdIVzJo7Rn1RqK/wMI9aTmFsFkm8PJfRPk2yIzSAFHbHJmJcLejrCy4j9cBPpuQK45l7UPx3WIylalFFAa4iS+qlTEtHISC0SRIP5TzUlM0wsa8QAttGMAq9ltCOnafFm8rt2Yh1Z7WBMUDe6sIQH3GyS4T1A87s1A/TR9CuNiVZOA1LKZ+93GltK30eUhfxP7nmzpo45n7n; 25:KqABDvld2H/GkM8dQudLUmu183NC4e5cBd2LknJ8dOOMi0TO2nGy2Uo9lAsDvYFwQrybccO6O4uEBmRKTI1/7CWg5Qw7u/d5qcJz+PIIILnLDRyimBRsvz/ZEWctr0B2tRsIpBExoolU+7u0eM8rhfGd8PGcQJYlAr+cQwpVWJbgz2qhh05MAJwyRHJ4UwDFQjaKyjm455euvKjNBevmX5+qeiqV93Gcx0UO9R2nfyJOx/PB2P31nQ5oYJ9UeIbSFlrcOH7iUIz3nrRnNRWZEd8bfx8vA+8y/ZXE7rX+LOlPa+yySRXGbW5le+WNr1//5xSu47UjBnMfxmATJms5Qg==; 31:9yvROBNfCgAzfQ9aEKdjMnHEuOZOXzmtSIfyIlfUxLIJQNhWprteS1T5+rc0FsiErhxaw9f0x2CONZPaFuektqXRPIisZOuOEHzACmsQt/6VZzluDZ7XIs1+B2ROlONem6YbFp5ctszkT6nMO6iuPhs+xlMHvy2gf05C4moTZfQz/SKEoow52YcKGnQ4P4LwTJLranyn5d7ucQ+hnaAVXCdwMkXP2Op4pl9rlN4F4iU= X-MS-TrafficTypeDiagnostic: CY1PR07MB2522: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 20:OiVO3F+FpwZ+TFwq1Hzv8gX0JrmWHBw26vYjL28mE3AdQDtmUvjEdY2TLByNIXv/JROpYb7TNOLvRhuS5IyDcI/HLHYRl7kditltOSWl9YYNsKEihb3Kpqwkpior+CoBu1u0JedqhJUqFAYQUfzmT79x0uq7MAmVpDqs5LxRDqGKDmg8ZshczH5aEmYMgi1dBi8hkbmhvoO0YvXHVssq1GxegSwb2D8Qof0xxPr6j3lYfkjkGJL3h7BDpMXE4w3UfG0Vblhp/YS5/3ON27PukS5QJTIriMuKSqgLe1svQNDHq6l5sgaaYmzQCUGgOF/zsha5jKVwuPwDAY5mkN3dliL3FMeUbv/Ly4fWVuav1EF3u6B7CZ8pVCOaFO0QsYG4RSDURWk61cWIYCYdrrakXhzvZJ7i+eiNn8uHZnBnz71LK/F6AHUmMIiNfF7hZoc7IiS6mz06UdeB8tCZBiKeyY/cEO9ltHvmXqy2k9rDeWz0cOzDmCg9+//1fSnNn/oCoo8NpELSFVyijcaxMKPFYUB7J3tfJ8Y2njWr30Pbotbv+azsVsdvOikOeQgcNfdGQtTyWGuVUb0jAdecgGDGO8zKJ/YOM7X6jzkorjxvZDQ= X-Exchange-Antispam-Report-Test: UriScan:(104084551191319)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(10201501046)(3002001)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR07MB2522; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 4:gb9awQ2NrIsNJpr985SPLrejaMbrDSG0ic1hCSXjm3H3Be8uq+j38IF7W8bA6pUXq1jqYDz2/V9x3XUPql76ajWxvR2fUYJ0HKLS0OdTqn2+KyrB/X07Hbpn99pUV9t1dzTic/1hC+Oae4c/0M9in51eBfvPvb1R698rlciQ8n4VwxYNdXGgmI+rFVWWy5WbfnIKz2idLeWFtR4Txo/icb16qlKC5sVk55avTI4vYF7z++EcNo2Sh+tsl8teO+/RzFLI8IMeLXKdhTlCU59kSxGXadBzRULFLDceq4a19EhvdnKy8bBa0x+Nwkbw42b/tQ8TfBZ59RRV1ZUCUPIK+g== X-Forefront-PRVS: 04371797A5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(189002)(13464003)(199003)(5660300001)(54906003)(58126008)(55016002)(229853002)(189998001)(50466002)(97736004)(83506001)(6666003)(7736002)(305945005)(2906002)(16586007)(966005)(6246003)(6496005)(81156014)(76176999)(54356999)(66066001)(50986999)(101416001)(81166006)(53936002)(16526017)(33716001)(53376002)(316002)(478600001)(25786009)(8936002)(72206003)(8676002)(4326008)(106356001)(1076002)(105586002)(33656002)(9686003)(5009440100003)(68736007)(6306002)(23726003)(2950100002)(42882006)(47776003)(6916009)(6116002)(3846002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2522; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2522; 23:sggytqp8cnWTYRoVHcuJmYGz8IfIcT9LVDkSrTNZH?= =?us-ascii?Q?LO7enLFLJyo1J7t5GsRY72BFPcbhOhlSa+WM4/slrkSJWOfNc0kn9QF4dxzW?= =?us-ascii?Q?jd59MaNhX91mdf3EYOhg8jxnol40I+979II1xlTQY8ldAPZfJqDg+96BRysg?= =?us-ascii?Q?F9evDlM2FKAyt7w1xrLgaaVctuwBfUYRmOiXreKObayeO/d9GGiRd5tnGxsN?= =?us-ascii?Q?iO1a30oZ7wRfZ0pyy2Mg1IZ+h9o1uyJSiRM+nT6+4azjmvl5W4ZxCeNnbbFw?= =?us-ascii?Q?2VgxNu0UZkuwZAdo8HYsJdzhhqdXldbfjP8W11/zQpuyT8xoQcP8RwFZg/Oy?= =?us-ascii?Q?aJj9km1P1Ag6rMlx4wuO1VIKTwrlKr2mptEw0ORq+io+g9gxaKO5yMwnq4ai?= =?us-ascii?Q?nqkF58ePDFF8IGGIeH1XR/4/bSPzegirJh7vrHHtxKUcqLoUDiawh1ASNwBb?= =?us-ascii?Q?eVFeIv/z5xpk5Vn8ShKCoItQ+oY/CAIxm/doWaFRbShMghJsCGZHgjl5/tUx?= =?us-ascii?Q?YK21ntS5tswgm8/dzb1KGhKJsQMdpOMkEWg9tQ0Ij38qjFUBb/hU9NDYedYM?= =?us-ascii?Q?7MMqcao+uuGthJrxywQA0449B/pCGO8BVDSqJH20BG/yEmSotFigLDtL8yuf?= =?us-ascii?Q?CL2d5385Vooasj2CxRyTesiZYzyxWqS9EliyL0ue65zaeQCMgsVc4Tq5xKJ+?= =?us-ascii?Q?A+PYyLjnBF7BvVfws9212otn+yUuYs0lqioHhxh92Tc7GM8QwZsAYcTw63b0?= =?us-ascii?Q?vKwns95YD1KtAAj8gEirgPIAyaDONNaSWflGwJpGXijhuCpJ8UeVdgiF4NsN?= =?us-ascii?Q?az7OtZp0PHOMUUqSaS21GtPtneaxGhIQVTEokg1nXQ98vSwAI/zVYn7kkmB2?= =?us-ascii?Q?A6QIa5tddN2KHJjS7Vb7AJQiPugVA/MUvK3N9n0A5Z9upI9J5s8lSsy2lzfF?= =?us-ascii?Q?HIbO8szMNrwa4RNcMszIAQ6MNUZU2XPFR7ek7a3wKHw5U4IMus2Vgu5jPTae?= =?us-ascii?Q?tE8Z38LpCIhGCGBRqhQJSgyjQY670lDiXw7TtdqOyfPbl7rgb6yyp+25br1W?= =?us-ascii?Q?54Ecy0pP/cq6b51jyvZ2n1wgT1lGmx6MBg5iITKXXt8i4MSmdY+eEi98jzkQ?= =?us-ascii?Q?hrj32svjDNJx/HdP1ME8skF9+OwfEU+Sqq1bdO2UQ26Ln2vnoVc5eHLD4Pnm?= =?us-ascii?Q?Qw3iA6V05/2KG9n33bj1Iy8cVabRPFdXC6gmIGmFRiTCex/1/2BrtKCgHqIe?= =?us-ascii?Q?B+n5+UKlnWXgQrnT6B4cdbCAVRxRWmZvhCJaiViaArJzu9jd7eobA72azv6e?= =?us-ascii?Q?+S5SprjSkNWsCVkgNH9JIk=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 6:+YYF81uGRZHr4rxGVCVhu3tdeEFbIY1xcynJTWfjVsZPzlQ8rxFDyw/u7995iV0HED0pIWJJjB9Ok+SPFCzyWqDhDyL0jXztz2q5J5b+qx+qLpWEEJKvBiPO8B2VeQ1FQjDfHMFiaYCjc54OA/VLDkDo3DRGXwMqEKrPKzicwGy1iUF5CURnKj8vSVt19WteHn+sfWXXGu0dJt5HqCfLY0A5PLK7dgsWMefhvh56fX+l7Eoz1iT35gBQFtzFoDooOaSW2VMzXaLEgVgzDPkB4vqi9hNTGXhavqJE2UN4whjaIWd1xPPoht7cpSiuvQci17SrzhTi63GwYJKc0zL3ow==; 5:Tf36r0vY0AG5UShPZIdWi5P5QPYzyIZ3ucvOpALQ1NCHik9vBvTz52q4Nwp3ckikxY82mHmbFmriyF4IfUbxKnLMVYocz8xE9cG0mxoy7cDNmkMpZB9YNoeT6tZpxFdM1FeVx+Iarlp7RGClfqIqBQ==; 24:/P4LGK/7LNrrsnBQOmsKvQ4JfquyHdtrXmDwVrqVTGk0sXVmRWn8dB68ZYLrXhoxv/VX4D0Lg3l8amY34w1b/Tbil1MeS1awUrLEM5Rmx1Q=; 7:KiDcpAzRP+L3KaOrbjtozQt1yYSKFRT3yOTqwgINHf3X24hW8ohOmkzvSxHwO9TBtJy9Fbm39oIyWEB1c3+r99Rekq/hPGcKTFD9+f9YYgWyARRv+BI8O0XeeBrZKJhxG0wcVK8OeVgGHxtsc5hx0Hr0AK5Ky1MOBQ7boVRBOQapOeTgNm/CLJZUWbMMizCV1I3l7kkh9I87+8R2IbB7yclqYGmI9cEPGxi4KG+7UH8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2017 12:20:53.1822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2522 Subject: Re: [dpdk-dev] [PATCH] eal: fix TSC resolution in hz for ppc_64 architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 12:20:57 -0000 -----Original Message----- > Date: Thu, 21 Sep 2017 17:11:26 +0530 > From: Gowrishankar > To: dev@dpdk.org > CC: Chao Zhu , Bruce Richardson > , Konstantin Ananyev > , Jerin Jacob > , Gowrishankar Muthukrishnan > > Subject: [PATCH] eal: fix TSC resolution in hz for ppc_64 architecture > X-Mailer: git-send-email 1.9.1 > > From: Gowrishankar Muthukrishnan > > In ppc_64, rte_rdtsc() returns timebase register value which increments > at independent timebase frequency and hence not related to lcore cpu > frequency to derive into. In this patch, we fix get_tsc_freq() to not > depend upon rte_rdtsc(), but obtain cpu current frequency from sysfs. > > Signed-off-by: Gowrishankar Muthukrishnan Hi Gowrishankar, > --- > Note: > * This patch would need minor port as per below patch (yet to upstream): > http://dpdk.org/dev/patchwork/patch/27527/ > > lib/librte_eal/linuxapp/eal/eal_timer.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_timer.c b/lib/librte_eal/linuxapp/eal/eal_timer.c > index afa32f5..b8775cc 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_timer.c > +++ b/lib/librte_eal/linuxapp/eal/eal_timer.c > @@ -55,8 +55,10 @@ > > #include "eal_private.h" > #include "eal_internal_cfg.h" > +#include "eal_filesystem.h" > > enum timer_source eal_timer_source = EAL_TIMER_HPET; > +static const char sys_cpu_dir[] = "/sys/devices/system/cpu"; > > #ifdef RTE_LIBEAL_USE_HPET > > @@ -269,6 +271,17 @@ struct eal_hpet_regs { > uint64_t > get_tsc_freq(void) > { > +#ifdef RTE_ARCH_PPC_64 I guess you can use the below series to avoid ifdef clutter in common code. Right? http://dpdk.org/ml/archives/dev/2017-August/072805.html. If yes, then you could resend the series with ppc_64 change.i.e removing following patch and add yours. http://dpdk.org/dev/patchwork/patch/27527/ > + unsigned long cpu_hz; > + char path[PATH_MAX]; > + > + snprintf(path, sizeof(path), "%s/cpu%d/cpufreq/cpuinfo_cur_freq", > + sys_cpu_dir, rte_get_master_lcore()); > + if (eal_parse_sysfs_value(path, &cpu_hz) < 0) > + RTE_LOG(WARNING, EAL, "Unable to parse %s\n", > + path); > + return cpu_hz*1000; > +#else > #ifdef CLOCK_MONOTONIC_RAW > #define NS_PER_SEC 1E9 > > @@ -290,6 +303,7 @@ struct eal_hpet_regs { > return tsc_hz; > } > #endif > +#endif > return 0; > } > > -- > 1.9.1 >