From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, remy.horton@intel.com, tiwei.bie@intel.com,
yliu@fridaylinux.org
Cc: mst@redhat.com, jfreiman@redhat.com, vkaplans@redhat.com,
jasowang@redhat.com, Maxime Coquelin <maxime.coquelin@redhat.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 14/19] vhost: don't dereference invalid dev pointer after its reallocation
Date: Sun, 24 Sep 2017 18:19:16 +0200 [thread overview]
Message-ID: <20170924161921.30010-15-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20170924161921.30010-1-maxime.coquelin@redhat.com>
numa_realloc() reallocates the virtio_net device structure and
updates the vhost_devices[] table with the new pointer if the rings
are allocated different NUMA node.
Problem is that vhost_user_msg_handler() still dereferences old
pointer afterward.
This patch prevents this by fetching again the dev pointer in
vhost_devices[] after messages have been handled.
Cc: stable@dpdk.org
Fixes: af295ad4698c ("vhost: realloc device and queues to same numa node as vring desc")
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
lib/librte_vhost/vhost_user.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 8aca7ef7e..f495dd36e 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -1198,6 +1198,12 @@ vhost_user_msg_handler(int vid, int fd)
}
+ /*
+ * The virtio_net struct might have been reallocated on a different
+ * NUMA node, so dev pointer might no more be valid.
+ */
+ dev = get_device(vid);
+
if (msg.flags & VHOST_USER_NEED_REPLY) {
msg.payload.u64 = !!ret;
msg.size = sizeof(msg.payload.u64);
--
2.13.5
next prev parent reply other threads:[~2017-09-24 16:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 16:19 [dpdk-dev] [PATCH v2 00/19] Vhost-user: Implement device IOTLB support Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 01/19] Revert "vhost: workaround MQ fails to startup" Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 02/19] vhost: make error handling consistent in rx path Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 03/19] vhost: prepare send_vhost_message() to slave requests Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 04/19] vhost: add support to slave requests channel Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 05/19] vhost: declare missing IOMMU-related definitions for old kernels Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 06/19] vhost: add iotlb helper functions Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 07/19] vhost: iotlb: add pending miss request list and helpers Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 08/19] vhost-user: add support to IOTLB miss slave requests Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 09/19] vhost: initialize vrings IOTLB caches Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 10/19] vhost-user: handle IOTLB update and invalidate requests Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 11/19] vhost: introduce guest IOVA to backend VA helper Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 12/19] vhost: use the guest IOVA to host " Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 13/19] vhost: enable rings at the right time Maxime Coquelin
2017-09-24 16:19 ` Maxime Coquelin [this message]
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 15/19] vhost: postpone rings addresses translation Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 16/19] vhost-user: translate ring addresses when IOMMU enabled Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 17/19] vhost-user: iommu: postpone device creation until ring are mapped Maxime Coquelin
2017-09-29 12:34 ` Yuanhan Liu
2017-09-29 12:51 ` Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 18/19] vhost: iommu: Invalidate vring in case of matching IOTLB invalidate Maxime Coquelin
2017-09-24 16:19 ` [dpdk-dev] [PATCH v2 19/19] vhost: enable IOMMU support Maxime Coquelin
2017-09-29 12:36 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170924161921.30010-15-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jasowang@redhat.com \
--cc=jfreiman@redhat.com \
--cc=mst@redhat.com \
--cc=remy.horton@intel.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=vkaplans@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).