From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, Stephen Hurd <stephen.hurd@broadcom.com>
Subject: [dpdk-dev] [PATCH v3 08/24] net/bnxt: fix usage of ETH_VMDQ_* flags
Date: Thu, 28 Sep 2017 09:13:13 -0500 [thread overview]
Message-ID: <20170928141329.73874-9-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20170928141329.73874-1-ajit.khaparde@broadcom.com>
Map ETH_VMDQ_ACCEPT_HASH_UC to the promiscuous bit.
Also, set ALLMULTI and MCAST when MCAST is set to ensure multicast traffic
is received regardless of the VF driver list.
Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode")
Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/rte_pmd_bnxt.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c
index c343d9033..0bf5db5ec 100644
--- a/drivers/net/bnxt/rte_pmd_bnxt.c
+++ b/drivers/net/bnxt/rte_pmd_bnxt.c
@@ -409,20 +409,19 @@ int rte_pmd_bnxt_set_vf_rxmode(uint8_t port, uint16_t vf,
if (vf >= bp->pdev->max_vfs)
return -EINVAL;
- if (rx_mask & (ETH_VMDQ_ACCEPT_UNTAG | ETH_VMDQ_ACCEPT_HASH_MC)) {
+ if (rx_mask & ETH_VMDQ_ACCEPT_UNTAG) {
RTE_LOG(ERR, PMD, "Currently cannot toggle this setting\n");
return -ENOTSUP;
}
- if (rx_mask & ETH_VMDQ_ACCEPT_HASH_UC && !on) {
- RTE_LOG(ERR, PMD, "Currently cannot disable UC Rx\n");
- return -ENOTSUP;
- }
+ /* Is this really the correct mapping? VFd seems to think it is. */
+ if (rx_mask & ETH_VMDQ_ACCEPT_HASH_UC)
+ flag |= BNXT_VNIC_INFO_PROMISC;
if (rx_mask & ETH_VMDQ_ACCEPT_BROADCAST)
flag |= BNXT_VNIC_INFO_BCAST;
if (rx_mask & ETH_VMDQ_ACCEPT_MULTICAST)
- flag |= BNXT_VNIC_INFO_ALLMULTI;
+ flag |= BNXT_VNIC_INFO_ALLMULTI | BNXT_VNIC_INFO_MCAST;
if (on)
bp->pf.vf_info[vf].l2_rx_mask |= flag;
--
2.13.5 (Apple Git-94)
next prev parent reply other threads:[~2017-09-28 14:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 14:13 [dpdk-dev] [PATCH v3 00/24] bnxt patchset Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 01/24] net/bnxt: fix HWRM_*() macros and locking Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 02/24] net/bnxt: use 64-bits of address for vlan_table Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 03/24] net/bnxt: fix an issue with group id calculation Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 04/24] net/bnxt: fix calculation of number of pools Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 05/24] net/bnxt: handle multi queue mode properly Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 06/24] net/bnxt: fix rx handling and buffer allocation logic Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 07/24] net/bnxt: fix an issue with broadcast traffic Ajit Khaparde
2017-09-28 14:13 ` Ajit Khaparde [this message]
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 09/24] net/bnxt: set checksum offload flags correctly Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 10/24] net/bnxt: update status of Rx IP/L4 CKSUM Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 11/24] net/bnxt: add support for xstats get by id Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 12/24] net/bnxt: fix config rss update Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 13/24] net/bnxt: set the hash_key_size Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 14/24] net/bnxt: add support for rx_queue_count Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 15/24] net/bnxt: add support for rx_descriptor_status Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 16/24] net/bnxt: add support for tx_descriptor_status Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 17/24] net/bnxt: add new HWRM structs to support flow filtering Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 18/24] net/bnxt: add support for flow filter ops Ajit Khaparde
2017-09-28 16:05 ` Ferruh Yigit
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 19/24] doc: update release notes Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 20/24] net/bnxt: fix per queue stats display in xstats Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 21/24] net/bnxt: prevent interrupt handler from accessing freed memory Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 22/24] net/bnxt: add dev_supported_ptypes_get dev_op Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 23/24] net/bnxt: add support for get/set EEPROM Ajit Khaparde
2017-09-28 14:13 ` [dpdk-dev] [PATCH v3 24/24] net/bnxt: add support for rx_queue_intr_enable/disable APIs Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928141329.73874-9-ajit.khaparde@broadcom.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen.hurd@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).