From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 4D8193257 for ; Sat, 30 Sep 2017 13:35:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 6242E1009; Sat, 30 Sep 2017 07:35:06 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sat, 30 Sep 2017 07:35:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=OMYP5Q5hCZayLOj/Df2I2kWnk9jG/VR7srZlGIIfx ck=; b=tRTtutAE9G6G2+MHf+XQjvyElOjXLmwSWku4sGZoqJaFV4K+0Jdu6uSsk UWD37PJ1t6hqM/Pvb+YA7gHInOrgHm3rongWp+waSRvJbCntpQJacgtcvtyY5nSE vnQvr+eb6uPF2W7k5aDzWrpQEcmfLwTn7twlGdDwj1pbffFlVgFRVhozuZ0e5Dow 5eprjl1EtNbXWYb62lsKIQEZIY5u9XfJUcitWUEeGmAc+aIDHl0Fc103lHfSQPkJ a4FYhs5lt0AtWOVQBRm70SRfHo3/RHXxEVzoZPLJTGfBEVrH9uWopvdFgSy+1PfB CqNtDWDIfc39LMTjCUUwE2MyS0CkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=OMYP5Q5hCZayLOj/Df 2I2kWnk9jG/VR7srZlGIIfxck=; b=VoufnleajGenTWUs9OgHSuLPk3Cazr7WlH 0yQ2qtlGzJ/l8OouGcBGt7A/sDOJfWVuzqpEThO0XeBZIFq/HLVvm1cQN8qdpTCc bOhS1wnYFNc2YGSZiICsnFhDiYI2Nc05pgEfqHAhoIc7cni6a1XY6KuLl9K6LLAh UdU9jgCKD6q6SKwW/cnbCzgtAaZ++LsyV0rWyzmysD+kWNq+PASjWZyS6O9xwikN ATQjdvGKQ3mIM+FTVc0I51CiSOdNyAt7ttJzWoPMHtp6dY64dK/4QExcCwgSRgN6 /GgznAoxXVyb6Ta/06/TsG/lWDSp4Jy5q44LO7zYDVKraxuPy+xg== X-ME-Sender: X-Sasl-enc: U74Y4br2TZVaVWolxujqmOCRXg6zVPQXbaqE+AKBp6iK 1506771305 Received: from yliu-home (unknown [222.64.168.88]) by mail.messagingengine.com (Postfix) with ESMTPA id C792D7E430; Sat, 30 Sep 2017 07:35:03 -0400 (EDT) Date: Sat, 30 Sep 2017 19:34:47 +0800 From: Yuanhan Liu To: Jianfeng Tan Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com Message-ID: <20170930113447.GF6251@yliu-home> References: <1503654052-84730-1-git-send-email-jianfeng.tan@intel.com> <1506606959-76230-1-git-send-email-jianfeng.tan@intel.com> <1506606959-76230-13-git-send-email-jianfeng.tan@intel.com> <20170930082319.GD6251@yliu-home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170930082319.GD6251@yliu-home> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v2 12/12] net/vhost: support to run in the secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Sep 2017 11:35:07 -0000 On Thu, Sep 30, 2017 at 12:53:00PM +0000, Jianfeng Tan wrote: >On 9/30/2017 4:23 PM, Yuanhan Liu wrote: > > On Thu, Sep 28, 2017 at 01:55:59PM +0000, Jianfeng Tan wrote: > >> +static int > >> new_device(int vid) > >> { > >> struct rte_eth_dev *eth_dev; > >> @@ -610,6 +685,8 @@ new_device(int vid) > >> _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, > >> NULL, NULL); > >> > >> + share_device(vid); > >> + > > Another question is, have you considered/tested the case when the VM > > changes the qeueue number later? > > Yes, that is a covered test case, we use ethtool to increase the > combined queue number; see cover letter for detail. Sorry I missed that! However, I'm not quite sure I understood you: Step 5: enable multi queue in VM1 and VM2. $ ethtool -L ethX combined 2 Note in this test case, only queue 1, i.e., secondary process can process packets. To use queue 1, basically, we can run command like: $ taskset -c 1 Do you mean the secondary can't rx/tx pkts from/to the 2nd queue? And you are asking the user to add "taskset -c 1" each time he wants to run a command inside the VM? --yliu