From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id EF03E532E for ; Sun, 1 Oct 2017 19:24:12 +0200 (CEST) Received: by mail-pf0-f173.google.com with SMTP id b70so1880215pfl.8 for ; Sun, 01 Oct 2017 10:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h0tZcurof4zWDQrwdMbnnIRqz521wInsR8pEk0XDvrs=; b=nUGSSJljQI0OydBH5pfy8TWGLhbNwaNAH4xN8IhmHOy6nskH0AhZTWQuEvdl/eXsmO YXXjX+o/xmbge32EkUpcgF/U0bLPouDjZCTGBHZmI1Js0VXQ7YXzn+HQTaPcFWQz48I6 R4/OPMLXBLmAUmghu2f0CPBjVqAKT22oUr068vAzeepgndR+2t0sR0ZYaGAKcj0NmLPy U1SwBq67ap3ji/EgtBDaKdRmTbSN9S6gnqMzMlk6X7aTNuz/wi/jFLSHwKTJRCwrL//z TxvB8Lsvv1e8v/MnkIJdzHboe+zwldwNIPha+6Nd2zKQ0l7FJ8f6NN08N1RJKbmhXQfD BPlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h0tZcurof4zWDQrwdMbnnIRqz521wInsR8pEk0XDvrs=; b=tPkk9grSDMV5G2FwjALnKF2Gqk/V34LnrfwBZ6tDJGL/GttPUmt0Dm58dkSZPmRk4G d5LBpnV//kdg3gIm3W+1jZya6u2hMtG476dYzhW6LOlcS8tblFJlqteeF7P7nbHNRnPC LWbItQYvIZf7iD+VrqiKEc4vcOm9G9LIjG/ctn6iw64I5CS0SbUuyWE3qf4gjV8IBnFN iEdSmuXZgRaJiEZ0WWa0KYZypnsatb140lAEnKhyr9GJB1XcAuoWN/HTFmMkEotuensE AqmEOgU8BH6Pxm+IWGYmb91YtsKiuv9wfQYhp6YMlKktnVQL2I1nafigrckyWH1oKNH0 payg== X-Gm-Message-State: AHPjjUjKHBVhcW3athS9NC+lEuPkA1Zb10tD65t0L2qVBD/Qyr01JiYJ eBBL+8ri1oS6RKXDYDevK7cBTg== X-Google-Smtp-Source: AOwi7QAbtJNPV6t8vOwu0MC1VtNxEivEKvIwIL9vs2DBy6MTkw51i4hx4d4Aq85mZkSxlOBajwiyzw== X-Received: by 10.98.29.74 with SMTP id d71mr12759089pfd.141.1506878652164; Sun, 01 Oct 2017 10:24:12 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id 65sm12983214pgh.31.2017.10.01.10.24.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Oct 2017 10:24:12 -0700 (PDT) Date: Sun, 1 Oct 2017 10:24:10 -0700 From: Stephen Hemminger To: Xiaoyun Li Cc: jingjing.wu@intel.com, dev@dpdk.org Message-ID: <20171001102410.3c928ad5@xeon-e3> In-Reply-To: <1506736748-50515-1-git-send-email-xiaoyun.li@intel.com> References: <1506565888-194214-1-git-send-email-xiaoyun.li@intel.com> <1506736748-50515-1-git-send-email-xiaoyun.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when start app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 17:24:13 -0000 On Sat, 30 Sep 2017 09:59:08 +0800 Xiaoyun Li wrote: > To make the performance can be tuning on different NICs or platforms. We > need to make the number of descriptors and Rx/TX threshold as arguments > when starting l3fwd application. > > Signed-off-by: Xiaoyun Li Not sure about this. The point of l3fwd is to make it as simple an application as possible to help users. Given that drivers can now supply default values for thresholds, I think the l3fwd sample should get rid of all the special descriptor values it is setting. Then if the values are not right for best performance that should be pushed back to the driver writer to fix.