From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0059.outbound.protection.outlook.com [104.47.41.59]) by dpdk.org (Postfix) with ESMTP id 952E5FFA for ; Mon, 2 Oct 2017 10:48:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=en2wXAE/XdZ7UvpdFuVL5H/PjvXZ6WWzO0nCN2pF0PY=; b=cNUGcTIeQubBiJl/dzdvAYxdgiNlCPSKp/kmCqmDIGedmcU/UzVf7KF0ZP/tXzPWCPQ3gwMYl/KQw+upgMxwPOJUBWaCDAj7D2792kRuxy1D/FBXN4319huBz28MtIZ6LG1dc8rhTTA+RhNbkknmsXH05vsrRq1Qah9Ihy6h3y0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.76.90.46) by CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 2 Oct 2017 08:48:45 +0000 Date: Mon, 2 Oct 2017 14:18:25 +0530 From: Jerin Jacob To: "Rao, Nikhil" Cc: bruce.richardson@intel.com, gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, narender.vangati@intel.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com, santosh.shukla@caviumnetworks.com Message-ID: <20171002084824.GA3381@jerin> References: <1506028634-22998-1-git-send-email-nikhil.rao@intel.com> <1506028634-22998-2-git-send-email-nikhil.rao@intel.com> <20170921154608.GC20126@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [171.76.90.46] X-ClientProxiedBy: MA1PR01CA0097.INDPRD01.PROD.OUTLOOK.COM (10.174.56.141) To CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3516eeee-d3f8-4ebd-0846-08d509726695 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 3:Wy6MzUisbvFX0hI1oIl2NzKuGeGN0xfXyRyaEsZZ1cGuWnfYHx5i1P/zBnRgGSMPZyPN1Oo63I4Zy+Yw7Rzps1Eqhz8uE5nW8LM23AeDMTDgYxmXvCNKxZQrTNWtUbUhe4Px6zkNYwnCJYEcnUJYQkNG7TuXVM0mio5YHBgAFCySoh9l8NfjInH+1Wx+k4nFq2Z7QmOEkCx5HxFJFPp+L4mNnOXvhDSJwua1grv82hmRVRZhJQvNc/Jc2HJHd0Mz; 25:xmdDFLbuK1buskQhwpvnTWcWNVe6WFw7+hJUCi2GyyX22EMoVcXfi0O97sPVe1g51I+d6G8TcjhbyGHJaJr9Mx4E7OxeRUJkD4yZ7QrEsv0i1PMM8MzgW0vWxDpqBZ0o3ehJJu0rwdy6WtyWTfc41RxceC0gmQV6lcXao3ZWgBOothN7eJdv48IH4jlHDE4QS4JmRBxy7K+uB0QzX6wpkW4byhB8VugfGEVNE/Pn/bEtdMuJrUwNxLvbD3E7aC2ba420YHyp6gDklaNukLvCLG0aRrlcinylUQWjItl39y/GRS+Qhg16sYpRjqpnt4VWUu1ya7OHaJhI6IiF9foKDA==; 31:mvODqzrG3uU4jPtBlM146kCS9LbHSu9+oTBcT5JAm1QxmdIb1UoFvdvKWTnmgOuDLoWswRGCC4Obn1GvPpYcgqGQ3lMpVG2Mk46v8hHr+k5+0tE/uSW7tkKYSiiIH3zuwk6/YU2bS6uzYgwt8Vdwyf236UJ3p3FciwdYozh18lXGztT2VcVT3RedkNLW5s3ljZXGYvtnal9SOWydOs9MsIvvw+vO+q4gBHGIV7l9ifE= X-MS-TrafficTypeDiagnostic: CY1PR07MB2522: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 20:z9i7e8WeX/Tb05rTLNOIwE3/fPTqlYO9zqO0/9AaNr/33iSgAk3Ath0P2UqXm2Zzf13GU7vpmvECf3OwV0qW8Z54bGZJSgpXv5hzzmhssBIkc+IKow13IT3Z2x2RBd/2Zx9VhcQGcu1xhN4+MwP5NyJ18afOmb8Yddbl9kv2WuU8alCJldAcYFRF1flNH/EwksHa77kuGnWS3EfV+iq4xcwAzJ7Zk588mZEJnwuDEWb/kbaKKxZlHC0Eq/CGYlP1UxRhxwkWnMk/ztnc/FZN2Tnrbb4sCjGxDNW33m5jcVpC3Bs7P7zQ5rAfcd7XIWw2af7bD77lRKyZV7Y/bDEb1vCGnd0NA0g7F32Jhg+/GiZ7hmkT+fPfrCR48913sOU1GduodaN2qL3RKVmIzAcAkXeOaT6Zvbn6CO9/Yj0oujzI+jtW9M2mzBECt9TIQfYM7TfkdUggHHD7ak+nDYyMSEVEciIyNHbx9tIyigKDamCj5bVaFHwH2XZbtNTi9ecJQeo9/Oq8Vxf+kAN8BQm2HTpvop+q0/tskEu7E+8+AOM+FvQFQBgkagnxnJA0Fus17j5XgpAQEMAtNvpeAdvSCsXDGqBBHGQFwmICuFK5XZE= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123564025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR07MB2522; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 4:tjXTFFf8qCnErQYfKmXRXyG93R7XzmFLfAK+aV3lfqL0uAYNpUM/RWVQrGGVg+p1jCd5KhLscO4phYpVyCfbxH+0hjKjKBAlBpSX+9YudwF6ftCi3MtM5fQ3T4hbc7ZOG4E4JQ38kCeO7MbXqMWs2Po3IIlHoqxnefjq1ULZMT+ExH9rFIWFsGfq1TzaFXnoDoG4BpWMP6P6ebjQ5x5tkYu0V069G2Ulxqp3v6RG/DA7GVVfi/tVHsxIEaNW7jkGWrecDvYiKpvJERvglKIelpLR+bgxQujl8YngTY6l5IZQCerans2bJ2ZXY27Udgt4GlibHHSQVEapbPfHOWx1Jw== X-Forefront-PRVS: 0448A97BF2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(24454002)(377454003)(199003)(189002)(13464003)(3846002)(6116002)(7416002)(53546010)(23726003)(1076002)(16586007)(68736007)(5660300001)(105586002)(106356001)(9686003)(2906002)(58126008)(229853002)(83506001)(8656003)(478600001)(7736002)(305945005)(25786009)(72206003)(50986999)(6666003)(107886003)(6246003)(101416001)(316002)(81166006)(76176999)(81156014)(54356999)(2950100002)(8936002)(97736004)(16526017)(33716001)(53936002)(42882006)(6916009)(8676002)(4326008)(33656002)(50466002)(6496005)(189998001)(55016002)(66066001)(93886005)(47776003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2522; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2522; 23:TXJKDwYcS3khSv+ORszN2SF4r+xeCrjxFugGxgl5M?= =?us-ascii?Q?YpXTN02nU9MaM0yR+vBgJppACyanfUWiu19KhuCnfe2cWVxmH1qyoqRcyzgN?= =?us-ascii?Q?gcyXY/92XkAwYg6x3HM1pwbP2uzsLMe0StpfCSbEUQ/8BpUjUlnDRuEOUK31?= =?us-ascii?Q?GfZV28Kh+x6LsF1jsW0z4kVEeF5fJsA/GmCV9/HIYvZddvyp3jKSo7CiFA0B?= =?us-ascii?Q?zEq5Et1FPHws4tkiWjmWIH8m2XNX2qmvynPYsI3xNeDQqbp5D6zogYHlPm77?= =?us-ascii?Q?mef1dHb3huY90ydQOHCqQuCui7u3FZj186VpL/7SVh0Mvxcd584GluzpRxvo?= =?us-ascii?Q?gTCx9mmH4tAG+hFw0cDrqSaXc/STQPRmg1CZmjLCOqBBvx6alqw/4Kn5tdW1?= =?us-ascii?Q?XLalDx31QDEReY1H8cKuNUqCgVVmVl4FzNtVAIyvEVWwNEwNSjhYB9ySwCXA?= =?us-ascii?Q?s9KijjtO3fyq2nRccGBRxR/ORwKP40k1L1OA3amToWTBhyB8bazeZd1YUDyb?= =?us-ascii?Q?ovDqN4cqSZgBek0bBb5jwQ76DNhvW5ZLX59Jzdwvvwf2d42He7Ztf9UmkLGX?= =?us-ascii?Q?1QbtOeNLsQimJmAMOQJ8+2q+e8m1ud4Exo8AAW0noitaHoTYEirEd1nnXM9L?= =?us-ascii?Q?wMAWNRDC4arM2IGaq8l/xwH/DPJOlfhL6HU7ysbENRRDOAG8wo/YOuFiZUDH?= =?us-ascii?Q?sJ3YYvqVFEIb9YUgwVT9ZvjnjMC2zTE1SS5VOiuPcMSLepqtdI3E2khGx7FR?= =?us-ascii?Q?iU1NN59usVID60FKx/eSB1ujlFszq2LcvO+SvjBMljJeiJ6W0I6LBlOMEmBb?= =?us-ascii?Q?4jS39frBkaulgTX0QwLVP32YIfRLFlq/Fes0ZaE3J2ZjToddZ3ydn1XASF8x?= =?us-ascii?Q?FHYPTbYEbrYUNXoJgp6V1WlrWuGwhUQFXTMpqbh6biJkYmgAhT6lL9+479z+?= =?us-ascii?Q?tSImCHONGqVAxdWX/EYbl0FTW4Tk7sQnwbckLFky0zCmLjB3dAXVDT2+/v/7?= =?us-ascii?Q?PcCEqAa4ySw5xV5IYuigmTmWUlZ1L7ZlSgsLfgQTCNN9Zeb2vC1PZTdB9Flh?= =?us-ascii?Q?DRK9qM33+UPyCUeY3e5FHS01JCYy3wIYbEfP04XSMxKmWbDWQlBVzeVfDkAw?= =?us-ascii?Q?D+A1iP/Nb2dmbivNOZNzxNJdOrvlfCwU7ywIVXNkAOYH/sTjrsJ3UvnKgLG9?= =?us-ascii?Q?K+sLzWJ2H3bzN8/2DoKlcaK7WY2pPyZYbf6lt42SghKutyXyaUCzS6PNoSnW?= =?us-ascii?Q?4vCTufkxQY1sl514ZsaXkSz27C6O504oJ1EmoTej4HWS/KJqRznFG6G2nxYc?= =?us-ascii?Q?5v2naQgAeri/L4uLNTNno9q+xf4ZlPXki9FKpgSozM5loe0np/u9q+XAGCWN?= =?us-ascii?Q?edc0A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 6:GcT/HI+4N2cfBp+YEBUtqwn60xBS+VXh1nZ3WWWbbkL1gIEuFxu1YmJt9QWIXR6cUpuPUgQFLBzcizDbPP3gyFSPpkIf/sltWMJYuNLUe/nlC+5x3nYEcLJIVLxSJ1tvpRKq61g0rZ7zuQ37YsqZFisTPvBuSt19xWbwk2Hx424ivGPjsVIkfIFySHnLwq7FXvQN+c2Cs2z+OnP8C7OfAZhNODHanAsspwOFbRNmqGIux7RUwNhqx6tBSUaGy4jrzpqByK6mdj8JVRt6fl1Z6FKrZ2Z2RqRp2reqI8D4GZ5VO+RXqaX1GbgUpgoTIMsfK13OnA7jWlfH05SAH2miwA==; 5:YkGW9Rz2nFH77rlEAcBbrU2HoDizJfbaQul9J68AIzltzyiDIRq9n7deb2nlTJhoj+NeiWKOCZgN/6OHIXVcFFb1lPBRBq631N4RnDTPtY5FRys4T8K63vlYbfO4tJe8eO7Ij+hwnCeYYHSKjaYoTw==; 24:oD/t49IRL6yGYMfQXzB1g9UfF3FjLhAxyQir1abbtrZqyBp5ezYYpalJs3ejpiHczalDCUabpNW9xUtQ+2LvYFoWnlP51EIQCyaf9qxguuw=; 7:FG1nKA0eNCKkssSnnuTsMtAoRKQcSwYGgEXuKY1JyYHFdu5UNfjvblj59Ih3UY5lga9VljTRRRD/JM1cTnLec1BTmV1OgGBlxItWV1vYpgbLUSZAGr+3bp0RUR7cXNrbB4zv8Dt8bfmKk+SQPDAVx0mwhzWj4UiKygXjConR+FQ10L2yOPNv8ywcAePpn32ltlqHH/JDZ3zTOsL0ie8xB269O9LBnTg7RHnwUr1WQOk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2017 08:48:45.2726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2522 Subject: Re: [dpdk-dev] [PATCH v4 1/4] eventdev: Add caps API and PMD callbacks for rte_event_eth_rx_adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 08:48:53 -0000 -----Original Message----- > Date: Sun, 24 Sep 2017 17:44:06 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: bruce.richardson@intel.com, gage.eads@intel.com, dev@dpdk.org, > thomas@monjalon.net, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, > nipun.gupta@nxp.com, narender.vangati@intel.com, > erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com, > santosh.shukla@caviumnetworks.com > Subject: Re: [PATCH v4 1/4] eventdev: Add caps API and PMD callbacks for > rte_event_eth_rx_adapter > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.3.0 > > On 9/21/2017 9:16 PM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Fri, 22 Sep 2017 02:47:11 +0530 > > > From: Nikhil Rao > > > To: jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com > > > CC: gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net, > > > harry.van.haaren@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, > > > narender.vangati@intel.com, erik.g.carrillo@intel.com, > > > abhinandan.gujjar@intel.com, santosh.shukla@caviumnetworks.com > > > Subject: [PATCH v4 1/4] eventdev: Add caps API and PMD callbacks for > > > rte_event_eth_rx_adapter > > > X-Mailer: git-send-email 2.7.4 > > > +/* Ethdev Rx adapter capability bitmap flags */ > > > +#define RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT 0x1 > > > +/**< Eventdev can send packets to ethdev using internal event port */ > > > +#define RTE_EVENT_ETH_RX_ADAPTER_CAP_SINGLE_EVENTQ 0x2 > > > +/**< Ethdev Rx queues can be connected to single event queue */ > > > > I think, Its is more of limitation. Since we are expressing it as > > capability. How about changing it as RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ > > (same as exiting !RTE_EVENT_ETH_RX_ADAPTER_CAP_SINGLE_EVENTQ and SW driver has this capability) > > i.e Ethdev Rx queues of single ethdev port can be connected to multiple > > event queue. > > > OK. I agree that the MULTI_EVENTQ is better suited to be expressed as a > capability. > > > > +#define RTE_EVENT_ETH_RX_ADAPTER_CAP_FLOW_ID 0x4 > > > +/**< Ethdev Rx adapter can set flow ID for event queue, if this flag > > > + * is unset, the application needs to provide a flow id when adding > > > > Looking at implementation, If I understand it correctly, it not application > > "needs" to provide instead, it is application can provide. If so, I think, > > making it as RTE_EVENT_ETH_RX_ADAPTER_CAP_SET_FLOW_ID or > > RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID makes more sense. > > > If the FLOW_ID cap is not set, it is required for the application to provide > it, else the application optionally can provide it but the feature of the > application being able to provide (override) the flag should be a separate > flag. > > If it's only the override behavior that is required, we can rename the flag > to OVERRIDE_FLOW_ID. Yes. OVERRIDE_FLOW_ID behavior makes sense to me. Please update the doxygen comments as well.