From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id CFD2A1B617 for ; Wed, 4 Oct 2017 14:02:44 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id b189so18436491wmd.4 for ; Wed, 04 Oct 2017 05:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=h9KvhH/MFUreIc2VoQrEm3wivZLIBuxNmCja2tm5vI4=; b=Fr/m5gOUWtFxSQnxIELVKg2yrQKfwxCyX/PtvIoU/w1P03YqDNHaW+yh5tkZj4QGNz o/+IagNrL/kyOx8nF4vzGlpo6QUqrhHiYL1U1930i+dppI40SnxjcEc5e5nqzP3b0zeZ za5ufU5Cfj5fdgTWV1MYKt7KGUcPsCEOhgPlCJN+IAK7UsUNloIaT9OqneSsInGlaIzJ MaGIZMCHBhZOvZuynx59PLscB7D7SADLEmATcZTy69qMZFkdp1Vu64PTrB0lnXRWg/Z2 NOyQQzlKiLpIfe4sARrAF2/iGE1pIKudY+uoe1h9cUGC3aTFA0nCg/YSRBFMSB+WcZwq 63DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=h9KvhH/MFUreIc2VoQrEm3wivZLIBuxNmCja2tm5vI4=; b=UaXEf0xG1vaGzttgGM9+2CAfvREANf8PN8o2IzhDwq4opsASAw/ZuCBroP+R9Ljbqy qtfT11CIOJ2zsr29CNwxSyLk6HpKupSC5LBE6EFik892UIef1FedH5SANIssQyRE9RgJ r4ZWhhd37raewbNOoGpJSCBiJvyDjBtp9lE049LBrN0n2S3gG7YWFwE3EuCDV1pWPV/m ZygLMUnV+ot1tW4d+0hlQOnTBLO5DpDDfAqyNeJZdRAmcf5AO0R1vbTxuTf36Hxs8Bc/ WCGhHslJps5xt2i8eZkUgmpUiDsC5wgdaG8pVb1LjPH9p6tPHZVCVd+FgqJn2ACTRJ+N 9DZQ== X-Gm-Message-State: AHPjjUgSQqd9zINjI+Gy1AWJPjuOeJ0DxfxiycQpCLjhw3Rf3p4bxnf8 BfoIFW5cjH1W6kffID6nnMNk X-Google-Smtp-Source: AOwi7QBgLSfyxfA6Q6g50/Im33VJMdGIVTeOTX4uslbTu9RGAoSFkjrkH+2OqLfw+zhm+ouTHbDU2Q== X-Received: by 10.80.132.169 with SMTP id 38mr28914580edq.181.1507118564526; Wed, 04 Oct 2017 05:02:44 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id b17sm4709837edj.21.2017.10.04.05.02.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Oct 2017 05:02:44 -0700 (PDT) Date: Wed, 4 Oct 2017 14:02:33 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: yskoh@mellanox.com, dev@dpdk.org, shacharbe@mellanox.com Message-ID: <20171004120233.GK1343@autoinstall.dev.6wind.com> References: <20171004082843.66576-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171004082843.66576-1-shahafs@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix checksum offload cap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 12:02:44 -0000 On Wed, Oct 04, 2017 at 11:28:43AM +0300, Shahaf Shuler wrote: > The PMD was using the wrong flag to query device checksum capabilities > > Fixes: bba710e6b99b ("net/mlx5: support upstream rdma-core") > Cc: shacharbe@mellanox.com > > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 229b824bc..a4b718417 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -649,8 +649,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > } > > priv->hw_csum = > - ((device_attr_ex.device_cap_flags_ex & > - IBV_DEVICE_UD_IP_CSUM)); > + !!(device_attr_ex.device_cap_flags_ex & > + IBV_DEVICE_RAW_IP_CSUM); > DEBUG("checksum offloading is %ssupported", > (priv->hw_csum ? "" : "not ")); > > -- > 2.12.0 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND