* [dpdk-dev] [PATCH] net/mlx5: fix checksum offload cap
@ 2017-10-04 8:28 Shahaf Shuler
2017-10-04 12:02 ` Nélio Laranjeiro
0 siblings, 1 reply; 4+ messages in thread
From: Shahaf Shuler @ 2017-10-04 8:28 UTC (permalink / raw)
To: nelio.laranjeiro, yskoh; +Cc: dev, shacharbe
The PMD was using the wrong flag to query device checksum capabilities
Fixes: bba710e6b99b ("net/mlx5: support upstream rdma-core")
Cc: shacharbe@mellanox.com
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 229b824bc..a4b718417 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -649,8 +649,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
}
priv->hw_csum =
- ((device_attr_ex.device_cap_flags_ex &
- IBV_DEVICE_UD_IP_CSUM));
+ !!(device_attr_ex.device_cap_flags_ex &
+ IBV_DEVICE_RAW_IP_CSUM);
DEBUG("checksum offloading is %ssupported",
(priv->hw_csum ? "" : "not "));
--
2.12.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix checksum offload cap
2017-10-04 8:28 [dpdk-dev] [PATCH] net/mlx5: fix checksum offload cap Shahaf Shuler
@ 2017-10-04 12:02 ` Nélio Laranjeiro
2017-10-05 0:56 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Nélio Laranjeiro @ 2017-10-04 12:02 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: yskoh, dev, shacharbe
On Wed, Oct 04, 2017 at 11:28:43AM +0300, Shahaf Shuler wrote:
> The PMD was using the wrong flag to query device checksum capabilities
>
> Fixes: bba710e6b99b ("net/mlx5: support upstream rdma-core")
> Cc: shacharbe@mellanox.com
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index 229b824bc..a4b718417 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -649,8 +649,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
> }
>
> priv->hw_csum =
> - ((device_attr_ex.device_cap_flags_ex &
> - IBV_DEVICE_UD_IP_CSUM));
> + !!(device_attr_ex.device_cap_flags_ex &
> + IBV_DEVICE_RAW_IP_CSUM);
> DEBUG("checksum offloading is %ssupported",
> (priv->hw_csum ? "" : "not "));
>
> --
> 2.12.0
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix checksum offload cap
2017-10-04 12:02 ` Nélio Laranjeiro
@ 2017-10-05 0:56 ` Ferruh Yigit
2017-10-05 18:05 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2017-10-05 0:56 UTC (permalink / raw)
To: Nélio Laranjeiro, Shahaf Shuler; +Cc: yskoh, dev, shacharbe
On 10/4/2017 1:02 PM, Nélio Laranjeiro wrote:
> On Wed, Oct 04, 2017 at 11:28:43AM +0300, Shahaf Shuler wrote:
>> The PMD was using the wrong flag to query device checksum capabilities
>>
>> Fixes: bba710e6b99b ("net/mlx5: support upstream rdma-core")
>> Cc: shacharbe@mellanox.com
>>
>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix checksum offload cap
2017-10-05 0:56 ` Ferruh Yigit
@ 2017-10-05 18:05 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-10-05 18:05 UTC (permalink / raw)
To: Nélio Laranjeiro, Shahaf Shuler; +Cc: yskoh, dev, shacharbe
On 10/5/2017 1:56 AM, Ferruh Yigit wrote:
> On 10/4/2017 1:02 PM, Nélio Laranjeiro wrote:
>> On Wed, Oct 04, 2017 at 11:28:43AM +0300, Shahaf Shuler wrote:
>>> The PMD was using the wrong flag to query device checksum capabilities
>>>
>>> Fixes: bba710e6b99b ("net/mlx5: support upstream rdma-core")
>>> Cc: shacharbe@mellanox.com
>>>
>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>
>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Applied to dpdk-next-net/master, thanks.
Squashed into relevant commit in next-net, thanks.
(since waiting pull-request invalidated, squashed in next-net)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-05 18:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-04 8:28 [dpdk-dev] [PATCH] net/mlx5: fix checksum offload cap Shahaf Shuler
2017-10-04 12:02 ` Nélio Laranjeiro
2017-10-05 0:56 ` Ferruh Yigit
2017-10-05 18:05 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).