From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) by dpdk.org (Postfix) with ESMTP id 1F3EF1B6C2 for ; Wed, 4 Oct 2017 19:11:24 +0200 (CEST) Received: by mail-qk0-f175.google.com with SMTP id w63so12182089qkd.10 for ; Wed, 04 Oct 2017 10:11:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XQJtE2utkcRjkMDJzKoVkhgo6VaqFIr1aYxG7ttRiuo=; b=qFrUT/hZp0JPsi7rdd6yN1P2PcLDwOwFPtFAQCrXLjGITrTexZgXuLoPVW6N+0q0IF TXSkNOUHdLmPvRFPHIJbuCzE60EG5b8pulDwxRAmrn2OiB55Y7zphpwMLVMnS6/wkksn Qjtl8lF617pcf61UgX8y4M+R6XPYm+MCYRXphO/liVYf9Z75xIwPhOwxoP3h7i64XFZl bxF7dVzlglGHMlWgFNg8sF1Ra1k9Qzauv+dpYRhIgvA3zgA6MXELqbCyq306vLK5SoIG 6bUDm8p8BhomZktiKXpjh4HZLnzU0dQKT0D9uQWzcJMYCoSzfhzgTheJH9WeXCdq50Je ZvaQ== X-Gm-Message-State: AMCzsaXb0q8VCJuvWn2UJbeOI65pWjGvb3+yh5GzjtyfqXPNlB9+vyul 53cnzQ9jtYGAmz0J35kyllJB5A== X-Google-Smtp-Source: AOwi7QAcPRipLKPNRYe84b9r3hmlJFr430BhLJzGXQdArmV3ib2ZL3p7LhavFPpeD/x5z0D680hcQA== X-Received: by 10.55.107.66 with SMTP id g63mr26015317qkc.152.1507137083380; Wed, 04 Oct 2017 10:11:23 -0700 (PDT) Received: from plex.home ([2001:1284:f013:5dc7:c27e:d031:a739:dac1]) by smtp.gmail.com with ESMTPSA id 4sm10111911qke.50.2017.10.04.10.11.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Oct 2017 10:11:22 -0700 (PDT) Date: Wed, 4 Oct 2017 14:11:19 -0300 From: Flavio Leitner To: Thomas Monjalon Cc: "Mokhtar, Amr" , dev@dpdk.org, aconole@redhat.com, bluca@debian.org Message-ID: <20171004141119.67a0998d@plex.home> In-Reply-To: <1887012.k95aipThBJ@xps> References: <1503668796-65832-1-git-send-email-amr.mokhtar@intel.com> <5517187.euiR5LjUcT@xps> <3D3765A8CDB52A4C8B410430AA19CB236EC341D7@IRSMSX104.ger.corp.intel.com> <1887012.k95aipThBJ@xps> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] Wireless Base Band Device (bbdev) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 17:11:24 -0000 On Tue, 03 Oct 2017 17:17:53 +0200 Thomas Monjalon wrote: > 03/10/2017 16:29, Mokhtar, Amr: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 25/08/2017 15:46, Amr Mokhtar: > > > > +int > > > > +rte_bbdev_configure(uint8_t dev_id, uint16_t num_queues, > > > > + const struct rte_bbdev_conf *conf); > > > > > > I am not convinced by the "configure all" function in ethdev. > > > We break the ABI each time we add a new feature to configure. > > > And it does not really help to have all configurations in one struct. > > > Would you mind to split the struct rte_bbdev_conf and split the function > > > accordingly? > > > > There is nothing to split tbh. The only parameter it has is the socket_id. > > And in fact, it's optional, can be null. The only config we need is num_queues. > > Indeed, there is nothing in this struct. > If you need only to allocate queues, you just have to rename this function. > > > I don't see in the near future that we may need to add more config params. > > As a side, in the time of the implementation we were trying to avoid any > > diversions from the current design ideology of ethdev and cryptodev. > > There is no ideology in ethdev, just some mistakes ;) > > > Can we leave it for consideration with future releases? > > No it should be addressed from the beginning. > > When you will need to add something more to configure port-wise, > you should add a new function instead of breaking the ABI > of the global conf struct. > That's why the configure option should be more specialized. > > Distro people were complaining about ABI breakage last week. > This is exactly an example of how to avoid it from the beginning. Exactly, and fixing in future is unlikely to happen or could be more difficult and even if it happens, it will cause another breakage. -- Flavio