From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 82CC637B1 for ; Thu, 5 Oct 2017 12:14:55 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92B26CA399; Thu, 5 Oct 2017 10:14:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 92B26CA399 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jfreimann@redhat.com Received: from localhost (dhcp-192-218.str.redhat.com [10.33.192.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E92935C8B7; Thu, 5 Oct 2017 10:14:50 +0000 (UTC) Date: Thu, 5 Oct 2017 12:14:49 +0200 From: Jens Freimann To: Jan Scheurich Cc: "'dev@dpdk.org'" , mcoqueli@redhat.com, yliu@fridaylinux.org Message-ID: <20171005101449.w76unipc4wscqarg@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170914 (1.9.0) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 05 Oct 2017 10:14:54 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3] vhost: Expose virtio interrupt need on rte_vhost API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 10:14:55 -0000 Adding maintainers to Cc On Sat, Sep 23, 2017 at 08:31:37PM +0000, Jan Scheurich wrote: [...] >Today this information is hidden inside the rte_vhost library >and not accessible to users of the API. This patch adds a >function to the API to query it. Since you add to the API please also document it in doc/guides/prog_guide/vhost_lib.rst. Apart from that the patch looks good to me. regards, Jens