From: Neil Horman <nhorman@tuxdriver.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v5] devtools: rework abi checker script
Date: Thu, 5 Oct 2017 09:15:43 -0400 [thread overview]
Message-ID: <20171005131543.GA13318@hmswarspite.think-freely.org> (raw)
In-Reply-To: <20171005075327.21678-1-olivier.matz@6wind.com>
On Thu, Oct 05, 2017 at 09:53:27AM +0200, Olivier Matz wrote:
> The initial version of the script had some limitations:
> - cannot work on a non-clean workspace
> - environment variables are not documented
> - no compilation log in case of failure
> - return success even it abi is incompatible
>
> This patch addresses these issues and rework the code.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
> ---
>
> v4->v5:
> - Add a log when shared lib has no public ABI
>
> v3->v4:
> - clarify logs on incompatible abi
> - log when an error returned an error
> - [really] fix the report path
> - log the output of make config in the proper file
>
> v2->v3:
> - fix when not launched from dpdk root dir
> - use "-Og -Wno-error" instead of "-O0"
> - fix typo in commit log
>
> v1->v2:
> - use /usr/bin/env to find bash (which is required)
> - fix displayed path to html reports
> - reword help for -f option
>
> devtools/validate-abi.sh | 397 ++++++++++++++++++++++++-----------------------
> 1 file changed, 205 insertions(+), 192 deletions(-)
>
To reiterate with updated logging
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2017-10-05 13:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 13:51 [dpdk-dev] [PATCH] " Olivier Matz
2017-09-04 16:00 ` Bruce Richardson
2017-09-04 16:03 ` Bruce Richardson
2017-09-04 16:13 ` Bruce Richardson
2017-09-06 14:51 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2017-09-08 13:46 ` Neil Horman
2017-09-11 8:18 ` Olivier MATZ
2017-09-11 8:46 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2017-09-13 15:00 ` Neil Horman
2017-09-19 9:15 ` Olivier MATZ
2017-09-20 9:12 ` [dpdk-dev] [PATCH v4] " Olivier Matz
2017-09-21 15:40 ` Neil Horman
2017-09-25 9:11 ` Olivier MATZ
2017-09-25 11:21 ` Neil Horman
2017-10-05 7:53 ` [dpdk-dev] [PATCH v5] " Olivier Matz
2017-10-05 13:15 ` Neil Horman [this message]
2017-11-07 23:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005131543.GA13318@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).