From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com
Subject: [dpdk-dev] [PATCH v2 4/4] net/bnxt: fix some unnecessary parentheses
Date: Thu, 5 Oct 2017 10:06:46 -0500 [thread overview]
Message-ID: <20171005150646.3188-5-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20171005150646.3188-1-ajit.khaparde@broadcom.com>
This patch removes some unnecessary parentheses from the code.
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 12 ++++++------
drivers/net/bnxt/bnxt_filter.c | 6 +++---
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index c559a9db8..636f09a66 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1734,9 +1734,9 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
STAILQ_FOREACH(mfilter, &vnic0->filter, next) {
if ((!memcmp(efilter->mac_addr.addr_bytes,
mfilter->l2_addr, ETHER_ADDR_LEN) &&
- (mfilter->flags ==
- HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP) &&
- (mfilter->ethertype == efilter->ether_type))) {
+ mfilter->flags ==
+ HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP &&
+ mfilter->ethertype == efilter->ether_type)) {
match = 1;
break;
}
@@ -1745,9 +1745,9 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
STAILQ_FOREACH(mfilter, &vnic->filter, next)
if ((!memcmp(efilter->mac_addr.addr_bytes,
mfilter->l2_addr, ETHER_ADDR_LEN) &&
- (mfilter->ethertype == efilter->ether_type) &&
- (mfilter->flags ==
- HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX))) {
+ mfilter->ethertype == efilter->ether_type &&
+ mfilter->flags ==
+ HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX)) {
match = 1;
break;
}
diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c
index 3eaa7e45a..d470be259 100644
--- a/drivers/net/bnxt/bnxt_filter.c
+++ b/drivers/net/bnxt/bnxt_filter.c
@@ -612,7 +612,7 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_item pattern[],
if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
- (vxlan_spec->flags != 0x8)) {
+ vxlan_spec->flags != 0x8) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ITEM,
item,
@@ -659,8 +659,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_item pattern[],
return -rte_errno;
}
- if ((nvgre_spec->c_k_s_rsvd0_ver != 0x2000) ||
- (nvgre_spec->protocol != 0x6558)) {
+ if (nvgre_spec->c_k_s_rsvd0_ver != 0x2000 ||
+ nvgre_spec->protocol != 0x6558) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ITEM,
item,
--
2.13.5 (Apple Git-94)
next prev parent reply other threads:[~2017-10-05 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 14:28 [dpdk-dev] [PATCH 0/3] patch series for bnxt Ajit Khaparde
2017-10-05 14:28 ` [dpdk-dev] [PATCH 1/3] net/bnxt: add ntuple filtering support Ajit Khaparde
2017-10-05 14:28 ` [dpdk-dev] [PATCH 2/3] net/bnxt: fix number of mac addresses for VMDQ support Ajit Khaparde
2017-10-05 14:28 ` [dpdk-dev] [PATCH 3/3] net/bnxt: fixup bnxt.ini Ajit Khaparde
2017-10-05 15:06 ` [dpdk-dev] [PATCH v2 0/4] patch series for bnxt Ajit Khaparde
2017-10-05 15:06 ` [dpdk-dev] [PATCH v2 1/4] net/bnxt: add ntuple filtering support Ajit Khaparde
2017-10-05 15:06 ` [dpdk-dev] [PATCH v2 2/4] net/bnxt: fix number of mac addresses for VMDQ support Ajit Khaparde
2017-10-05 15:06 ` [dpdk-dev] [PATCH v2 3/4] net/bnxt: fixup bnxt.ini Ajit Khaparde
2017-10-05 15:06 ` Ajit Khaparde [this message]
2017-10-05 20:38 ` [dpdk-dev] [PATCH v2 0/4] patch series for bnxt Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005150646.3188-5-ajit.khaparde@broadcom.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).