From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id B93B91B279 for ; Fri, 6 Oct 2017 10:06:02 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id k4so6294220wmc.1 for ; Fri, 06 Oct 2017 01:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3Z32ndwHDl34fLX58nTmhrvK91ablZF11gnmNGve8+g=; b=ki6R6dAz3+e+nQT6rIv5GTphnCDc/QEyuMjkWXyDco5TpqFO5KtvQqWeKK5wu1sIXQ myb0cGpeuh4ubrfsB1U/MHMowUReEM6JujmwpPf9zpXbiVtFMabFahPEee7dC7e0syKv VkVoupgkcEzsEtbnODF9ZUbh2Sm8sMPq/Rg5FDmp6ovkcitNA4/A9fY1fT0L0ayWiBCc 4TyH1X6Au3EhhXkb3akPGdyRloW4qv0Ky/ZnRicG5Sg0dRtXCu7ebWoO1txsfsa7YB2X qZBvab1k0mFMCmBibuPOn+r6cH7m1Jr3vYsnTraQlHqI7nM2xkcuc6/wYalcWWPawQrm TEvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3Z32ndwHDl34fLX58nTmhrvK91ablZF11gnmNGve8+g=; b=V4yST4hldixfcU5gRfQ7Z2qAgtHYUfQ20dHq1SLSU1v5cS+Vh5kKOWrkZ85lsHgo7x CjjPyjTlD+BQduq39yVKVAnDQm66GTLV5bTLp3t+8kHEh8g+CbvkITrU7rPO1W6lqoKq TsIpmPtcG+MwRRmbgHVPlKw0fnRTOLIUqK08m9cW/HLxnfwiQ+Pb66XDQgYQVJu5gnRD MgVhSP0Flkmbc6U0CLbteJg1b5jAIWvdyopZHUcBeyLFRSvYqjJWAVOl/zI7pKocfPVr xRLnTmF4C7EgbVmdyFso0nt2MEj/M1cdgD+pq5Pns6GuURU9NdgJ3LwyDvTBkGq/lopS ouOw== X-Gm-Message-State: AMCzsaWFnXamWkId7AutDH9U+B3OwORZuafdCVuZgnl4C1KgO0G7uTd2 sY6SbfyBFLy8QJqqlSVlvGEFnw== X-Google-Smtp-Source: AOwi7QCfO+2Qvhky1PVXz5JvgyCJ4zs0tE8C7BVilHHolNsFOwqjSSdIo1TC5kI9P+Zb3YExkWKgDQ== X-Received: by 10.80.135.157 with SMTP id a29mr2237656eda.112.1507277162154; Fri, 06 Oct 2017 01:06:02 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f9sm1370724ede.38.2017.10.06.01.06.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Oct 2017 01:06:00 -0700 (PDT) Date: Fri, 6 Oct 2017 10:05:50 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Gaetan Rivet , dev@dpdk.org Message-ID: <20171006080550.GB3871@6wind.com> References: <919ab2dc-1081-d139-50a3-c797fbeb7284@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <919ab2dc-1081-d139-50a3-c797fbeb7284@intel.com> Subject: Re: [dpdk-dev] [PATCH v1 0/7] Flow API helpers enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 08:06:02 -0000 On Fri, Oct 06, 2017 at 02:13:14AM +0100, Ferruh Yigit wrote: > On 10/5/2017 10:49 AM, Adrien Mazarguil wrote: > > This series brings enhancements to various rte_flow helpers: > > > > - Allow applications to use rte_flow_error_set() by making it part of the > > public interface and documenting it as such. > > > > - Address rte_flow_copy()'s limitations by replacing it with the more > > versatile rte_flow_conv(). This new function allows retrieving other > > properties such as item/action names, enabling testpmd to finally use it > > and get rid of duplicated code. > > > > - Add a script (gen-rte_flow_conv-h.sh) to help with generating the > > resources used by rte_flow_conv(). Developers should run it when adding or > > modifying pattern items or actions (done as part of this series to add the > > missing "fuzzy" pattern item). > > > > - Future plans for rte_flow_conv() include translating error codes to > > human-readable messages, so applications do not have to make their own. > > > > All these changes address concerns raised a couple of months ago [1]. Work > > on these patches actually started at the time but I was unable to complete > > and clean them up until recently. > > > > [1] http://dpdk.org/ml/archives/dev/2017-July/070492.html > > > > Adrien Mazarguil (7): > > ethdev: expose flow API error helper > > ethdev: replace flow API object copy function > > ethdev: add flow API item/action name conversion > > app/testpmd: rely on flow API conversion function > > ethdev: enhance flow API item/action descriptions > > ethdev: generate flow API conversion header > > ethdev: update flow API conversion header > > Hi Adrien, > > This received too late for this release cycle, and changes in rte_flow > library may effect PMDs. > > I suggest deferring the set to next release, what do you think? Hi Ferruh, My opinion as the author (since you're asking :) is that it would be nice to have it in this release assuming reviewers don't find blocker issues with it. To summarize the changes from a PMD standpoint: - rte_flow_error() (previously not public) switching from positive to negative return value like the other rte_flow_*() functions. The only PMDs relying on its return value so far are mlx4 and tap. - rte_flow_copy() disappearing. This function was temporary pending a better solution, and so far is only used by fail-safe PMD (modified as part of this series). Besides fail-safe, PMDs did not a have a use case for this function. These patches were originally targeted at 17.08, and since the "fuzzy" item is missing from rte_flow_copy() (GTP/GTPU/GTPC are now also missing by the way) and there is currently a lot of redundancy between this function and testpmd's internals, I thought it would be a good time to have everything in a single place. I was also considering using rte_flow_conv() in upcoming mlx4 patches in case it was included. So here's my suggestion: I can track all rte_flow-related changes in PMDs and in rte_flow itself and update this series accordingly until things have settled (e.g. I'll re-submit to rebase and include GTP). Once applied, I will check all new code that relies on these two functions and update it if necessary until the release. How about that? -- Adrien Mazarguil 6WIND