From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gaetan.rivet@6wind.com>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
by dpdk.org (Postfix) with ESMTP id 8AA571B1BA
for <dev@dpdk.org>; Fri, 6 Oct 2017 15:32:28 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id i124so7954106wmf.3
for <dev@dpdk.org>; Fri, 06 Oct 2017 06:32:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to
:user-agent; bh=nDSjopcdK3J3XO0CoYVC+qG88633bPplfD7x0f73cO4=;
b=avS/KF5V9JPps7Q3FoBWv/LOniC1Q9CdVASJ7WAb+TzP64+IRj937Ggx9px2D/3nbL
Cc7TJFv+EqDJiQ9XHR0/6AJUYpGYnd7pnGWYDrSTlpqiW3AnF8AeGABzUHyi6fN9YEyn
ljVqH49qvlkYAH5YzSxcwuQDYtTAE94QTh632TOs1bQX8BGaryr/aGWJ8QnRlk80a3xx
ga18Ezt0I7XHVpFwYX9AMvwSKCgSeLt0EORe9aUeJIta2A4VtXg62fExjYSR4TGcPmdI
swY+he21ro05eBYDk9OJS0RmTTXlgfIzTNo1NFDVG6FzwT3gLIVGyh0BzvQApFXeIvE9
2zvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=nDSjopcdK3J3XO0CoYVC+qG88633bPplfD7x0f73cO4=;
b=UeTQzhFoASG6sJcc5pX52dYsrY0VFQwwHexgeibVpMep2Cj0OfwUAa9pZEbU+gOQ5k
feE2GDnrDd6JjVXCJc2pDxGtcBki4W92Tsbdoi9EUWhQHV/XudDS6oY+KOXCNIsOrZRM
cy+DF81CHqWQDc+IHCMbp0Box8wbnbjg2B1mQVAjX8xCMSbCY8D1SM6icUiOolpgsJVj
ZatINF9oo2HTPVp7DgpAw56qX+CFua3Y7xCGGvI7RCfeQ28bC6M6G7xBhjvo3OeWgibT
3d3YGtsKD5UzVYIwMyR0zWDW9OFkWuLRte7aZuQe6+FlHkSSWpn69mFw/aHTyfvzgNDG
m3ew==
X-Gm-Message-State: AMCzsaUgkuDKACz0PgmDZ8FRvsSxLM/GYyXQLW86nO4WMaLxPrFfDJl2
0Tg77hUhV+0QSHT2XSmfAsulXQ==
X-Google-Smtp-Source: AOwi7QCnoNyStDEggiJdc0i/Uo/QYaY7sSl39I4vAsRMNritVdfoHb7ofRKvImbcvYDwireQGBNEsw==
X-Received: by 10.80.179.187 with SMTP id s56mr3246204edd.237.1507296747978;
Fri, 06 Oct 2017 06:32:27 -0700 (PDT)
Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com.
[62.23.145.78])
by smtp.gmail.com with ESMTPSA id m8sm1535945edl.74.2017.10.06.06.32.26
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Fri, 06 Oct 2017 06:32:26 -0700 (PDT)
Date: Fri, 6 Oct 2017 15:31:23 +0200
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Zhiyong Yang <zhiyong.yang@intel.com>, dev@dpdk.org,
thomas@monjalon.net, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
Declan Doherty <declan.doherty@intel.com>
Message-ID: <20171006133123.GA31685@bidouze.vm.6wind.com>
References: <20170925032231.72897-1-zhiyong.yang@intel.com>
<20170929071727.21618-1-zhiyong.yang@intel.com>
<f8625d3d-1b96-f72e-13c2-74e5bbc3c45a@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f8625d3d-1b96-f72e-13c2-74e5bbc3c45a@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v6 0/5] increase port_id range
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Oct 2017 13:32:28 -0000
On Fri, Oct 06, 2017 at 03:15:40AM +0100, Ferruh Yigit wrote:
> On 9/29/2017 8:17 AM, Zhiyong Yang wrote:
> > port_id is currently defined as uint8_t, which is limited to the range
> > 0 to 255. A larger range is required for vdev scalability.
> >
> > It is necessary for a redefinition of port_id to extend it from
> > 1 bytes to 2 bytes. All ethdev APIs and usages related to port_id will
> > be changed at the same time.
> >
> > Discussion about port_id is the following thread.
> > http://www.dpdk.org/dev/patchwork/patch/23208/
> >
> > Changes in V2:
> > 1. cover more PMDs to increase port_id range.
> > 2. cover more examples to increase port_id range.
> > 3. add 17.11 release note.
> >
> > Changes in V3:
> > 1. cover mlx4 and mlx5.
> > 2. add to increase port_id range in test code.
> > 3. The patch "librte_mbuf: modify port initialization value" is merged
> > into the patchset.
> >
> > Changes in V4:
> > 1. Add a patch to remove bonding APIs using ABI versioning according to
> > Ferruh's comments.
> > 2. Unify to use typedef portid_t in testpmd code.
> > 3. update release note deprecation doc in 2/5
> > 4. fix some issues according to comments.
> >
> > Changes in V5:
> > 1. For 1/5, bond_mode_8023ad_conf_get_v1708() and bond_mode_8023ad_conf
> > _get() are merged into one function bond_mode_8023ad_conf_get.
> >
> > Changes in V6:
> > 1. For 2/5, remove the unnecessary LIBABIVER in Makefile and update
> > the release notes "Shared Library Versions".
> > Note: The patchset have dependency on the following patch.
> > http://www.dpdk.org/dev/patchwork/patch/28738/
> > http://www.dpdk.org/dev/patchwork/patch/29219/
> >
> > Note: 3/5 and 4/5 patches' building depends on 2/5 patch since 2/5 patch
> > breaks lib/PMD API/ABI.
> >
> > Zhiyong Yang (5):
> > net/bonding: remove bonding APIs using ABI versioning
> > ethdev: increase port_id range
> > examples: increase port_id range
> > test: increase port_id range
> > librte_mbuf: modify port initialization value
>
> Series applied to dpdk-next-net/master, thanks.
>
> There was merge conflict for:
> rte_eth_bond_pmd.c
> failsafe_private.h
> mlx5_rxtx.h
>
> Maintainers of these files cc'ed, can you please double check latest
> files in next-net?
Hello Ferruh,
The only potential conflicts I see are on the event callbacks
8<-----
int failsafe_eth_rmv_event_callback(uint16_t port_id,
enum rte_eth_event_type type,
void *arg, void *out);
int failsafe_eth_lsc_event_callback(uint16_t port_id,
enum rte_eth_event_type event,
void *cb_arg, void *out);
----->8
and I see no issue there on next-net.
Let me know if you want me to check something specific.
Regards,
--
Gaëtan Rivet
6WIND