From: Roger B Melton <rmelton@cisco.com>
To: jingjing.wu@intel.com
Cc: dev@dpdk.org, Roger B Melton <rmelton@cisco.com>
Subject: [dpdk-dev] [PATCH v2] net/i40e: improve i40evf buffer cleanup in Tx vector mode
Date: Fri, 6 Oct 2017 10:08:53 -0400 [thread overview]
Message-ID: <20171006140853.27212-1-rmelton@cisco.com> (raw)
Signed-off-by: Roger B Melton <rmelton@cisco.com>
---
v2 - Same content as v1, but properly signed-off.
i40evf tx vector logic frees mbufs, but it does not remove the
mbufs from software rings which leads to double frees. This change
corrects that oversight. I've validated this fix within our application.
drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
index 39a6da0..fdc6fce 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -127,6 +127,7 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
if (likely(m != NULL)) {
free[0] = m;
nb_free = 1;
+ txep[0].mbuf = NULL;
for (i = 1; i < n; i++) {
m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
if (likely(m != NULL)) {
@@ -139,14 +140,17 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
free[0] = m;
nb_free = 1;
}
+ txep[i].mbuf = NULL;
}
}
rte_mempool_put_bulk(free[0]->pool, (void **)free, nb_free);
} else {
+ txep[0].mbuf = NULL;
for (i = 1; i < n; i++) {
m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
if (m != NULL)
rte_mempool_put(m->pool, m);
+ txep[i].mbuf = NULL;
}
}
--
2.10.3.dirty
next reply other threads:[~2017-10-06 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 14:08 Roger B Melton [this message]
2017-10-10 17:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006140853.27212-1-rmelton@cisco.com \
--to=rmelton@cisco.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).