From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 797A32F42 for ; Fri, 6 Oct 2017 16:34:41 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id u138so8322921wmu.4 for ; Fri, 06 Oct 2017 07:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Q1i5rBmjcJusuNC6aW8OAuYyQL5RJgUhmQTnAQgpBpY=; b=AxZGIhWR3WrIRDRYFe/Yna75mPQIVy5e+LUvpaB2hVwXDRsWv0S9saEGMW3aZ/yNML yA0rJGj+OZoZbIGzyi06ePdOYjFfw85A1C9jZoa7tnipyQL0/zJRE5kSLnyL9B5739JJ icFlrDFSnhkCZZD70MRYzk09KmmtQIu9Z/6sIDhyHIhr/fejDUeavgZugp9tfxN92/ML a3oVh1k+p8W2KDZUsYNkLCThqZfyE1B9LsnnTuL3eAb75cgXf5e+jKQVOag2N7C+NZzh zDAIxv+30PrpNbXmQ+KiXsTp9yJ1L3MrYQ7uWplEYWiajkQSklMpYkTlke5j2SpSyJWt sWMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Q1i5rBmjcJusuNC6aW8OAuYyQL5RJgUhmQTnAQgpBpY=; b=lGOGDP4smqhqFS6rJTynwhlKspy2Sc+v9aSXKDeNpzwHvL1rQTEIKhOa4BiMMvIIeo xVzvOtFOAZ/hvXCh8gbfsaaw4AYc3bYz8quTGaqxwQsrNGst3m/o6i6O+wvW5CqPQ+lz mzPiUBNAfWDkDRYeW5YfLy1FY6ShYN64PGPu8D8zRFFHMrmhJ822h+ur60rRk/xWJgIg oOFZK8QyJszY55tr6HenAM/uF6/yUiOJwe3jjR6JV8zfAnpSjvA94DzWC4XPg3wCUChX xmb3bMBpG+Js/ImG02Uhtk7Gn+9Nd2B8cMR3hJJaZOKu2LkGDvrtdjc1uWtxtTCx3LvL F9ww== X-Gm-Message-State: AMCzsaUfRJ1icGA4L2PDSTsBOar7KaGbyMScyEG+d7aJnsizEvSDXKGt pwbbsFtc05QuaiBvT/zihuAU X-Google-Smtp-Source: AOwi7QBfX5rqRgHYiXlOR6t3BwydIR/WbbHxxbuVd7egPKzHZM6MBdMNJyvjKTPAHhh9SBj7mxXJxA== X-Received: by 10.80.184.53 with SMTP id j50mr3569884ede.134.1507300481202; Fri, 06 Oct 2017 07:34:41 -0700 (PDT) Received: from laranjeiro-vm (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id i10sm1966892edl.34.2017.10.06.07.34.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Oct 2017 07:34:40 -0700 (PDT) Date: Fri, 6 Oct 2017 16:34:30 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: ferruh.yigit@intel.com Cc: Zhiyong Yang , dev@dpdk.org, thomas@monjalon.net, Adrien Mazarguil Message-ID: <20171006143429.x3oxhe2247lxf2em@laranjeiro-vm> References: <20170909144727.46388-1-zhiyong.yang@intel.com> <20170921083243.57991-1-zhiyong.yang@intel.com> <20170921083243.57991-3-zhiyong.yang@intel.com> <20170921114928.GC11375@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170921114928.GC11375@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 2/5] ethdev: increase port_id range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 14:34:41 -0000 On Thu, Sep 21, 2017 at 01:49:28PM +0200, Adrien Mazarguil wrote: > On Thu, Sep 21, 2017 at 04:32:40PM +0800, Zhiyong Yang wrote: > > Extend port_id definition from uint8_t to uint16_t in lib and drivers > > data structures, specifically rte_eth_dev_data. Modify the APIs, > > drivers and app using port_id at the same time. > > > > Fix some checkpatch issues from the original code and remove some > > unnecessary cast operations. > > > > release_17_11 and deprecation have been updated in the patch. > > > > Signed-off-by: Zhiyong Yang > > --- > > > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > > index 7de1d1086..238a64f43 100644 > > --- a/drivers/net/mlx5/mlx5_rxtx.h > > +++ b/drivers/net/mlx5/mlx5_rxtx.h > > @@ -112,14 +112,14 @@ struct rxq { > > unsigned int sges_n:2; /* Log 2 of SGEs (max buffers per packet). */ > > unsigned int cqe_n:4; /* Log 2 of CQ elements. */ > > unsigned int elts_n:4; /* Log 2 of Mbufs. */ > > - unsigned int port_id:8; > > unsigned int rss_hash:1; /* RSS hash result is enabled. */ > > unsigned int mark:1; /* Marked flow available on the queue. */ > > unsigned int pending_err:1; /* CQE error needs to be handled. */ > > unsigned int trim_elts:1; /* Whether elts needs clean-up. */ > > - unsigned int :6; /* Remaining bits. */ > > + unsigned int :14; /* Remaining bits. */ > > volatile uint32_t *rq_db; > > volatile uint32_t *cq_db; > > + uint16_t port_id; > > uint16_t rq_ci; > > uint16_t rq_pi; > > uint16_t cq_ci; > > > Can't speak for the other PMDs, but it looks OK as far as mlx4/mlx5 are > affected. This is my ack for this specific change: > > Acked-by: Adrien Mazarguil > > -- > Adrien Mazarguil > 6WIND Ferruh, the patch applied on master-net does not match this version of mlx5_rxtx.h causing a performance issue. Regards, -- Nélio Laranjeiro 6WIND