From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 6F19A37A2
 for <dev@dpdk.org>; Sun,  8 Oct 2017 22:10:18 +0200 (CEST)
Received: from lfbn-lil-1-182-75.w90-45.abo.wanadoo.fr ([90.45.31.75]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1e1HzX-0005yv-07; Sun, 08 Oct 2017 22:16:04 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
 Sun, 08 Oct 2017 22:10:07 +0200
Date: Sun, 8 Oct 2017 22:10:07 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Yuanhan Liu <yliu@fridaylinux.org>, maxime.coquelin@redhat.com,
 dev@dpdk.org
Message-ID: <20171008201006.7gqmyeofcw3m4ech@neon>
References: <20171006064558.GE1545@yliu-home>
 <1963011.gX7c8kfyiN@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1963011.gX7c8kfyiN@xps>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [git pull] virtio changes for 17.11-rc1
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Oct 2017 20:10:19 -0000

Hi Thomas,

On Sat, Oct 07, 2017 at 04:37:53PM +0200, Thomas Monjalon wrote:
> 06/10/2017 08:45, Yuanhan Liu:
> > Hi Thomas,
> > 
> > Please consider pulling following virtio changes for 17.11-rc1 at
> >     git://dpdk.org/next/dpdk-next-virtio    master
> 
> There is a compilation error on ARM with
> "net/virtio: rationalize setting of Rx/Tx handlers"
> An include of rte_cpuflags.h is missing.

I confirm that this include is missing in virtio_ethdev.c, breaking
compilation on arm (thanks for spotting it):

 virtio_ethdev.c: In function 'virtio_dev_configure':
 virtio_ethdev.c:1748:7: error: implicit declaration of function
        'rte_cpu_get_flag_enabled' [-Werror=implicit-function-declaration]
   if (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON)) {
        ^

Thomas, about this issue, what do you expect? I can send another patch
if required.

Olivier