From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 6D2F91B246 for ; Tue, 10 Oct 2017 05:14:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 95487107B; Mon, 9 Oct 2017 23:14:18 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 09 Oct 2017 23:14:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=fY5vo/tf/ZuwiXmlxmPC57WLToiXixx6xa5oRwqqT LY=; b=VMkxSxiSC1+IovUqZEzDyqGuBjUyUkoRt298178kRSpTDBKZ/hAq+pelG IfPdvW6+IcEqjb91xk9B3LN8x7OzVC79hFs+zhUIZ84uavPZFY3EHgvt4g3zmgqg BbpOOp9i3sfxuIvMUgpjxuD5PoKGqG95Rq5IhWYfs1d4j2F6VLBmIcPhB833TzKw 3NlQJQxstCwp2z7yi86pEZKtibtK6Xmq0MY78wipeTdwvn4xl5xebV1J1sErEWFw PquAnviRH9BClo7/EN3L4FSWtlnGtVvaPNld/y39svjxCgbZNTwWGoCyiQ0jypxR l+rEYioDVUnr2Ubp7/qicIu1S1BIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=fY5vo/tf/ZuwiXmlxm PC57WLToiXixx6xa5oRwqqTLY=; b=X0U96c/QRBkbKhfD6sL9yTEyNxHt5xmW82 mBQaFclRjKjk+hOc2qgorBA0941XLs3YGuqRB2tWNoSHpPPYj/LMHciCf0Gatryp PDh9kR0DPCHXLJuIPf/OaCUUgiQJ/JmvXTcf1zDG972TiEaUuVfsTtoug6voZ+d+ FamNrrowl8EYUezNh/Gjf4rIPWQaYS43x6unYhDNPlFB1rI8I+x/Ou4nctl5440d lgtfVd4TjTll86sofg8YSMqqEKBERAn8NR4UqQvfd+Cjpknd9PJt29sN90IKQQhk oJxK/bnKDIFqd1Lze3GJk8c1aS4uXBTwpMOyORuyZuCwSefR/eVA== X-ME-Sender: X-Sasl-enc: iJyP0P9pm4wBBgc/aNdj9HP+XhYDkxfC2UEpC7Cv5Afp 1507605257 Received: from yliu-home (unknown [222.64.172.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 90B2524372; Mon, 9 Oct 2017 23:14:17 -0400 (EDT) Date: Tue, 10 Oct 2017 11:14:14 +0800 From: Yuanhan Liu To: Dariusz Stojaczyk Cc: dev@dpdk.org, Pawel Wodkowski , jfreimann@redhat.com, maxime.coquelin@redhat.com Message-ID: <20171010031414.GQ1545@yliu-home> References: <1503419092-63814-1-git-send-email-dariuszx.stojaczyk@intel.com> <1504090258-164350-1-git-send-email-dariuszx.stojaczyk@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504090258-164350-1-git-send-email-dariuszx.stojaczyk@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v3] rte_vhost: added user callbacks for socket open/close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 03:14:19 -0000 On Wed, Aug 30, 2017 at 12:50:58PM +0200, Dariusz Stojaczyk wrote: > Added new callbacks to notify about socket connection status. > As destroy_device is used for virtqueue processing *pause* as well as > connection close, the user has no distinction between those. > > Consider the following scenario: > rte_vhost: received SET_VRING_BASE message, > calling destroy_device() as usual > > user: end-user asks to remove the device (together with socket file), > OK, device is not *in use* - that's NOT the behavior we want > calling rte_vhost_driver_unregister() etc. > > Instead of changing new_device/destroy_device callbacks and breaking > the ABI, a set of new functions new_connection/destroy_connection > has been added. > > Signed-off-by: Dariusz Stojaczyk > --- > v3: improved err-handling path and updated commit msg > v2: also updated vhost_lib.rst The doc update is missing. I have cherry-picked it from v2. Applied to dpdk-next-virtio. Thanks. --yliu