* [dpdk-dev] [PATCH] net/octeontx/base: fix icc build
@ 2017-10-10 4:37 Pablo de Lara
2017-10-10 13:33 ` santosh
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2017-10-10 4:37 UTC (permalink / raw)
To: santosh.shukla, jerin.jacob; +Cc: dev, Pablo de Lara
drivers/net/octeontx/base/octeontx_pkovf.c(527):
error #592: variable "i" is used before its value is set
RTE_SET_USED(i);
Fixes: ab4f789560c4 ("net/octeontx/base: probe PKI and PKO PCIe VF devices")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/net/octeontx/base/octeontx_pkovf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/octeontx/base/octeontx_pkovf.c b/drivers/net/octeontx/base/octeontx_pkovf.c
index cbcc006..f0fb930 100644
--- a/drivers/net/octeontx/base/octeontx_pkovf.c
+++ b/drivers/net/octeontx/base/octeontx_pkovf.c
@@ -522,10 +522,10 @@ static void
octeontx_pkovf_setup(void)
{
static bool init_once;
- int i;
- RTE_SET_USED(i);
if (!init_once) {
+ unsigned int i;
+
rte_spinlock_init(&pko_vf_ctl.lock);
pko_vf_ctl.fc_iomem = PKO_IOMEM_NULL;
--
2.9.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/octeontx/base: fix icc build
2017-10-10 4:37 [dpdk-dev] [PATCH] net/octeontx/base: fix icc build Pablo de Lara
@ 2017-10-10 13:33 ` santosh
2017-10-10 19:24 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: santosh @ 2017-10-10 13:33 UTC (permalink / raw)
To: Pablo de Lara, jerin.jacob; +Cc: dev
On Tuesday 10 October 2017 10:07 AM, Pablo de Lara wrote:
> drivers/net/octeontx/base/octeontx_pkovf.c(527):
> error #592: variable "i" is used before its value is set
> RTE_SET_USED(i);
>
> Fixes: ab4f789560c4 ("net/octeontx/base: probe PKI and PKO PCIe VF devices")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/octeontx/base: fix icc build
2017-10-10 13:33 ` santosh
@ 2017-10-10 19:24 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-10 19:24 UTC (permalink / raw)
To: santosh, Pablo de Lara, jerin.jacob; +Cc: dev
On 10/10/2017 2:33 PM, santosh wrote:
>
> On Tuesday 10 October 2017 10:07 AM, Pablo de Lara wrote:
>> drivers/net/octeontx/base/octeontx_pkovf.c(527):
>> error #592: variable "i" is used before its value is set
>> RTE_SET_USED(i);
>>
>> Fixes: ab4f789560c4 ("net/octeontx/base: probe PKI and PKO PCIe VF devices")
>>
>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>> ---
>
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-10 19:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-10 4:37 [dpdk-dev] [PATCH] net/octeontx/base: fix icc build Pablo de Lara
2017-10-10 13:33 ` santosh
2017-10-10 19:24 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).