From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tdu@semihalf.com> Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 17F111B214 for <dev@dpdk.org>; Tue, 10 Oct 2017 12:25:24 +0200 (CEST) Received: by mail-lf0-f43.google.com with SMTP id a16so12993842lfk.0 for <dev@dpdk.org>; Tue, 10 Oct 2017 03:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=3Kzti/xKqRAsJUhu6ardFVBAJudxF9N1KLv4u++elgE=; b=SwbQgKNejGud6XKaw5QYBELEie+08iQz8HCCnBwiZss6g/Y9SidP2nknVTvNGR6N+j iVBPafzXOAxsFp7os0MAcpPzzIUx11oh+PMgsJ3lFlSqVw4oEAxq22cuiT76lI1tONe/ G/eb+SlZsMzTfSmO8jHepEoHpQ5poaIlPGUy8H8kR+sUQ75AFf/xuS1ABNgdHo2q34HJ XpsSFsWJypAonSxCABKjTsDKcmCs3Ks2P1d01qZpa6+Secveevy2m2mXeO8xAjBkVEwH 83a5t0T5koFZYLRKE/yWHhE4ZdG2K8etE9oWwsC7QCD2tbEyY1wNX2vSiJZkrL0ZHWYV wATw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=3Kzti/xKqRAsJUhu6ardFVBAJudxF9N1KLv4u++elgE=; b=QGHv9EB/I2jezxXoPIHjBH4PKppqeV7MhSAm27p2Suod297q50cGFFyHnHowTH25Q3 6MXN+BYRNsPsZ9T/GxLjdUcnbF2+ouOj10XkxhfXd6UjhYb4rOX6QYYmH6G4zGeiBMg2 8BwK0D9QWlZd5ZUf7bbk5H23MzE2B3xN7LthW3hjWCfuMBBt55O1P8ZfNyAgOavP+B2u dPupYRJU9zP1QHqvybvHaXD7oR6gicabafe+fXKSCY3sebqLjNr7laIXw3KXkuRf8fUm RSu7YPjF+qh7ppTaY9klPJA1fDa+8IO9dspTBzQOH/D2i4csiAbMSOe0mi170x3t7fQW hQTQ== X-Gm-Message-State: AMCzsaXR6yeJf2K1rXuUDnduX3ie11mm9gb24ieDDsS8DU8rmVa+GwlI Tw5rYCFIX9MbHgs+HiUXjqitBxFLD3g= X-Google-Smtp-Source: AOwi7QBEosj4xHKEn8silXXfk72KK1YGvz3enu48JHDbiGvQ6vg6HMwqOXIxUOQhGKt94yk1UAd90w== X-Received: by 10.25.149.131 with SMTP id x125mr4653091lfd.231.1507631123628; Tue, 10 Oct 2017 03:25:23 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id c17sm429515lfc.67.2017.10.10.03.25.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Oct 2017 03:25:22 -0700 (PDT) Date: Tue, 10 Oct 2017 12:25:22 +0200 From: Tomasz Duszynski <tdu@semihalf.com> To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> Cc: Tomasz Duszynski <tdu@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>, "mw@semihalf.com" <mw@semihalf.com>, "dima@marvell.com" <dima@marvell.com>, "nsamsono@marvell.com" <nsamsono@marvell.com>, "Jianbo.liu@linaro.org" <Jianbo.liu@linaro.org>, Jacek Siuda <jck@semihalf.com> Message-ID: <20171010102522.GA6236@tdu> References: <1506594212-15803-1-git-send-email-tdu@semihalf.com> <1507408106-11292-1-git-send-email-tdu@semihalf.com> <1507408106-11292-2-git-send-email-tdu@semihalf.com> <E115CCD9D858EF4F90C690B0DCB4D8976CC2EF80@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC2EF80@IRSMSX108.ger.corp.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 1/4] crypto/mrvl: add mrvl crypto pmd driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 10 Oct 2017 10:25:24 -0000 On Tue, Oct 10, 2017 at 10:16:42AM +0000, De Lara Guarch, Pablo wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski > > Sent: Saturday, October 7, 2017 9:28 PM > > To: dev@dpdk.org > > Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com; > > Jianbo.liu@linaro.org; Tomasz Duszynski <tdu@semihalf.com>; Jacek Siuda > > <jck@semihalf.com> > > Subject: [dpdk-dev] [PATCH v3 1/4] crypto/mrvl: add mrvl crypto pmd > > driver > > ... > > > diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd.c > > b/drivers/crypto/mrvl/rte_mrvl_pmd.c > > new file mode 100644 > > index 0000000..a404bf4 > > --- /dev/null > > +++ b/drivers/crypto/mrvl/rte_mrvl_pmd.c > > ... > > > + > > +/* Register the driver in constructor. */ > > +RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_MRVL_PMD, > > cryptodev_mrvl_pmd_drv); > > +RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_MRVL_PMD, > > + "max_nb_queue_pairs=3D<int> " > > + "max_nb_sessions=3D<int> " > > + "socket_id=3D<int>"); > > +RTE_PMD_REGISTER_CRYPTO_DRIVER(cryptodev_mrvl_pmd_drv, > > cryptodev_driver_id); > > This macro now needs 3 parameters. You probably rebased the patchset > against the main repo, and not dpdk-next-crypto. ACK > Just a reminder that all crypto patches should target this repository. > > Apart from this, the rest of the patchset looks good to me. > So send a v4 and hopefully it can be merged in RC1. > > Pablo > -- - Tomasz Duszy=C5=84ski