From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C9EC01B215; Tue, 10 Oct 2017 13:40:04 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2017 04:40:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,504,1500966000"; d="scan'208";a="1204205624" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.37]) by fmsmga001.fm.intel.com with SMTP; 10 Oct 2017 04:40:00 -0700 Received: by (sSMTP sendmail emulation); Tue, 10 Oct 2017 12:39:59 +0100 Date: Tue, 10 Oct 2017 12:39:59 +0100 From: Bruce Richardson To: "Roger B. Melton" Cc: Qi Zhang , konstantin.ananyev@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20171010113959.GA40296@bricha3-MOBL3.ger.corp.intel.com> References: <20171010132205.72173-1-qi.z.zhang@intel.com> <20171010084807.GA34984@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 11:40:05 -0000 On Tue, Oct 10, 2017 at 07:05:33AM -0400, Roger B. Melton wrote: > Hi Bruce, > > I can.  It will take a day or 2 to get the results. > > Regards, > Roger > Thanks. Keep us posted. We want to ensure we have the best fix possible for the issue in this release. /Bruce > > On 10/10/17 4:48 AM, Bruce Richardson wrote: > > +Roger Melton > > > > On Tue, Oct 10, 2017 at 09:22:05AM -0400, Qi Zhang wrote: > > > vPMD tx does not set sw_ring's mbuf to NULL after free it. > > > So to prevent same mbuf be free again, we need more carefully > > > check in i40e_tx_queue_release_mbufs. > > > > > > Fixes: b4669bb95038 ("i40e: add vector Tx") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Qi Zhang > > > --- > > > v2: > > > - fix at i40e_tx_queue_release_mbufs so no performance impact. > > > > > This patch also supercedes this one, http://dpdk.org/dev/patchwork/patch/29814/ > > right? > > Roger, can you please confirm that this alternative fix works in your > > testing and that your patch is no longer necessary too. > > > > Thanks, > > /Bruce > > > > . > > >