From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0083.outbound.protection.outlook.com [104.47.41.83]) by dpdk.org (Postfix) with ESMTP id ADBDE239 for <dev@dpdk.org>; Wed, 11 Oct 2017 12:59:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=z9SnDqCrN9rhUdWq6DJEaDIk/Ovzbi865RPWjaEo5tg=; b=XkWV3tvQ5MUIxefuBbX3zlN1lGl0j5w0dP1poxIf81kDVjX3IPVnffMtB2WmK4N9rlGK9mNgXxtGHLbI/HL913fFMzv35qt5ULMfSgJKwErAdWmXUxrJFWYHrNHTb4+ecJ6hR8vlkXqEL2aPK/SHdXN8KGdgxW1U3ZsBxwF5/8I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (14.140.2.178) by CO2PR07MB2519.namprd07.prod.outlook.com (10.166.201.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Wed, 11 Oct 2017 10:59:12 +0000 Date: Wed, 11 Oct 2017 16:28:52 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>, dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <20171011105848.GA20722@jerin> References: <20170831145436.5397-1-jerin.jacob@caviumnetworks.com> <20171008124430.1866-1-santosh.shukla@caviumnetworks.com> <f2d31436-5939-15e8-e242-ecafb11ef762@intel.com> <5089301.2kQRttag8V@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5089301.2kQRttag8V@xps> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BMXPR01CA0036.INDPRD01.PROD.OUTLOOK.COM (10.174.214.22) To CO2PR07MB2519.namprd07.prod.outlook.com (10.166.201.6) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eed8e925-4f45-4a8f-f7e8-08d510971d64 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:CO2PR07MB2519; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 3:6bWZE75sh17/Il1nKGWkRrMfop/VsPeAZz/4jlTHsL11CJ4HqUaBN76MQDvNWbCM+YtgstS6F6ulwV3Ydht4h2lLRYz3O6zYIWN4GNrCdAVhUXsRUD572iVJ610kbCKkePze6yRqmIfhtNpzovLxZ2WSYDbGg8DEpI29nrHsPHglkIxJ9cvFlQzlZAWk4XSyNdvjRbtr0XboV/RF03kBNhVGP9s1V8jUp3hIFCfi/bRzxgWHMJRGYRfjGkJhpVjc; 25:7IS+YHuycGn+EGJ8EqRNA5eJ/Qq8EKWOBj6+KJuyH1JqvvRf+XKAOqbMHjZJ0NP1HLxtIynXS7yWfQLEcFiWErBBSjyIER9hKXvJs7Gw3uYqcpK7wJKonyv99i5u8pVHIdosNFnNuipTK/1rfusTKVveGfTw77BvTI2uEQZUaRKCAO650iZFaDIvDXoMcDpSiOuXbx66jSIEWdLv3/6qnFMhze4hubUuCg1geSkdR4SUq/49zZW9y4z6D4uSF9ZC+t0rnWwIROl6jLp6/YMeHVqDnv7XIb/NEnCYH4ns83A+QC2s47RZXH9xa3ij7GwZ67c12ui/8KH6lEl4srb87ZwfZoL/Rfu6jLNcsy6ZZ2g=; 31:nghjkNQhHqGxfS1Yy8NUx+Aud055rij3SM90DsKwk0vr3MGEJdLHxeJXmYztzr74gUvmfrosFGLx/vQYMD4rvvZ8iL/wa+Y9qUxOFr46OjZiteYMYGeSD0wNiSJ+T16LRIoB4BSe5sEz/ntdaAKTk2l/99WvKxqqQbeVvs/TK+tmHMe6SJukGEcm4ZfA0AnhozCiUpQiQWQAx06QCXmbJnLmvpzkC8in1WbsR0dzeo4= X-MS-TrafficTypeDiagnostic: CO2PR07MB2519: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 20:7GXmU+Tyfx8fgAmDq3INyc1nzVnkTMzCoM6HIDc5l09uR98QkTGpnZc7x1jfok7lfklUXcSty5HBrh5KybBZRF2KDiAUwWDcPy1wKB9lLJONc6L5OayjPaHd3j+Vvniu9Dtj8EQs+wbu16WeA7TXPHtLpodz8FUd8KmYWcGEQxrD5MH3GAhES4hEWML8ZbddB9WOGKANZn34RCNC0ccCXy3iGJli98EGIMbB3yXhUzaLWFnc1Qb1UpMFLr33jTCXB8CBld1tPRPMBM22I902KBKFHmuldfbcrkvOKmtEuEzZtgvwj2fMrMm/w1vxzGKg0xfgK94RWCdiOrhGHe3lzU3lNYviAfPP9hg6zAUqTvq+BcI+R0W5k5gRDTCcKZZCjCzKHOByEd3sRsjVW1NCWCDZgzZ1NYLyDW7g8us251loQkSQ6mL12jOZW92v4Qie2rBu+2FV2CdcxFBHQCc/+ZTH6jWiWYNXSwlsP85W07WDQpEDfdR2MwFv910jSc/e4hAHmYhF3peppEcSPaD7aDNVAmPrIg8BAfwIo8Hodm0ul57slXV4VOcGDDuIVmk+kJGAFxAAJm3iXqatWnnwH3GQPfOqbgbqnqxMBJ2hB2k= X-Exchange-Antispam-Report-Test: UriScan:(166708455590820)(228905959029699); X-Microsoft-Antispam-PRVS: <CO2PR07MB25195C47A0CF0DD1863473C0E34A0@CO2PR07MB2519.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR07MB2519; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR07MB2519; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 4:KjKpyP91uG6xJ9fz9Vy16zCHXz6jWJTRlS0H1TayOwCiT1ohWmFWtVIGG5stSKGOlcII4H8+/gNP+kgfpBVxpPXSbSeSA+4k43K567Jhdbj3hv6UznGXMIV8jD27BSrH4IuHfZzCF27PRwILOt0sJpQYmJwZT2CKf5Ej/7uFZPom/aAc0i2Emy2O+ZhL1Ae1rjRwIsrRHyvE/NrukXw9XdRLeSXPRCHZZME/bHOgxrTyGnwD9r/6keED9Cs/1H/oiNCPXsqnvqxoCF8TGzY+Pk1M1JFPOD/kviuMyFT/W4h5iwfrLVBHcoOT0dmxGKS2TqHIPJtTOZLP4ZxFdCP9BA== X-Forefront-PRVS: 0457F11EAF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(24454002)(13464003)(377454003)(199003)(189002)(23726003)(3846002)(25786009)(101416001)(53936002)(6116002)(1076002)(5009440100003)(47776003)(106356001)(68736007)(33656002)(5660300001)(105586002)(189998001)(2906002)(19273905006)(305945005)(9686003)(7736002)(6306002)(6916009)(229853002)(2950100002)(4326008)(6496005)(6246003)(8676002)(53376002)(81166006)(81156014)(8936002)(33716001)(16526018)(478600001)(97736004)(42882006)(50466002)(55016002)(83506001)(316002)(54356999)(66066001)(93886005)(6666003)(58126008)(50986999)(53546010)(76176999)(966005)(54906003)(72206003)(16586007)(110426004)(18370500001)(217873001)(562404015)(563064011); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2519; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2519; 23:xm+XhUV+mr6dUq9L2yTcBJWduVgAE/KgsgToDImwS?= =?us-ascii?Q?sBuad8tK9FKCf+u1Z8gdRFEOS7dHcs2LubnMt5kbrt30za8ZZxpTINjy9Byx?= =?us-ascii?Q?caGhxTyAHi2sqCkv2fp2Az7fzUHDARv4Qlyu9k4YAE4D4aWrNW6DDV+nsma6?= =?us-ascii?Q?Hi+njQ87F4VX8ZdYUxm6TYcrBozIWJNUxh1MHpcYOEC9dRPCZOohE42CBG20?= =?us-ascii?Q?FwQUGTZ4ZS2mrCqkXSduhgzFUolpdKiFD/aBKxKEqWct7TEm51vCVQ38kbWo?= =?us-ascii?Q?PJ+rJCZjaEb9skkDklHYs2WUJan7rLNQiguZPbvPYQe8VhI3X0zRnAbPsSbO?= =?us-ascii?Q?5Aqi54X9ALydaYWWVatDn+y6+3Lc89Vy5bG7rho8nrl7uFbf9eM4QT0ZGom8?= =?us-ascii?Q?Dv+JHMEjRDsAgyYabqCxVSnFHDvhLwLWTfpkGfeg2IFGg1dANkUQJbay7ZK/?= =?us-ascii?Q?LMJgRLf5J69M62Z2zg+2p4i5tByWBe8k/vQCgVr4EVRtNljtuFvx5YrkldkA?= =?us-ascii?Q?ejHl7orseak7h7FThb3pMXHcowqn4ZPnddWdw7Vwp7tC9rEp15upHxO2Tw2j?= =?us-ascii?Q?sAp3MQwF8yn29uvsx3rMEvr6w/cluMduGHoRuCMNv65JADZvUAVrNXiRgR4w?= =?us-ascii?Q?SGjwy0t+7Dp/OQZUPOfhw82q3BAYntrRg3I4MdTro/dSrkMcldvT6yJv20Cz?= =?us-ascii?Q?PDNTu8Uj6G2Mk8f7FPUuungFIHRUY+E1JyHHOu8EpBcXCXRkKMU7BwEKkho+?= =?us-ascii?Q?0qyo8yAH2fac/qqmqxSAcplbUTZ9gzl7Tvsf6RIjy7LBBE61fapdTMMpZzOl?= =?us-ascii?Q?ued8rnMhGyXiO+2IgZ/pjF0jNWcl1rNmpK9Vt3Dip99kb3Rv0TKs3T9TZS/2?= =?us-ascii?Q?bDlXzDqyzCTdfJMQ/xM2JxXUULUP1uBiN96F77jXrDTKZW/0rW68NPXTw72f?= =?us-ascii?Q?UkXv3+GGS54vXgvhBmqGGhk7+rfzwSGXTvZXX8NsP7528/YpxINOBHiFPYcM?= =?us-ascii?Q?UqKis/ZFj444EjJn3ccDG0Qsor3s6PRpGkmr6KRPpRb9ZbTfRT0IMuAePvYD?= =?us-ascii?Q?O414LI2qnMWdRqLTZeS0fnvle1xiOwN0ClXhe1c9UEQe3fT3d1ETBHl3imNy?= =?us-ascii?Q?bb7laMgRIvEBdMIsWIDAflNUzZ+ATxG38zhKBmRmgYNO5fYa+GzF2YPtl4AS?= =?us-ascii?Q?eNQjc46MIRSIYt7lvU3HqHKoKKmXhZK4CyLhIODiP2kfzdWVaQM04PR77s+6?= =?us-ascii?Q?cdmmx9GoEQmGB8Rpomu2pGu3/y8BXmcIf2PN882CVZUqkrBu/XVtZUj4cr47?= =?us-ascii?Q?9fIEdy36NxnsWLdPmFnZYRMmgEqVj+aF3rNpajSnTXvyfpiE6cf+xRjCQfDn?= =?us-ascii?Q?d1E7IsAwWW1yDxAvSXtdW71snoP9uTzP+VrqpFlSR+82Ul3iQ/6ZUaPxEwVV?= =?us-ascii?Q?4cElQUKHDv+1Cf1N0/e8fnqLRz7LWm9cdGv+lLdmK0Yw0KJjqpCZ1oHUATMA?= =?us-ascii?Q?9lcYIxqlr58vfXofjNa5q8VZrEyunrAus4dOpTgi0DEAGXtA2xnwDcq?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 6:wfpf9gEM+LzBsPe5r/VRTkdjPN8a4RDK7oKt56JP7c4MF89ojHWusdoio7jkX1D+XEy4CspZeMmRt/Ph0meiegkC8df1gjsM8scUpgwsDcVmWD4eSphLx+x0geFceblCrHSNGzQXZfPDaWfqUTVoMVwN1TqCJRcW5C8h0kWN58cCWr2RuVOgbZM4vY8CuGrZC59LRfJ97V0BpXVGhcTx1kjZ4tgfOZzsSysVwPBzm9ILkzL2dx7cspROY+Aeisv52LXZ746Twl3ePmz+G3UxyHUJNH1m9JQdWvtuU5XYHdBPvVo1C+Ma4yfeKmJA4rvC/tJgkGAQK0UCHcQtAM2dgQ==; 5:SyQWrvOakGNeyXy1lCkaKfHWU/Xok+sxaqkkAjgGs/X44iFunVJ/JfLzdSda+/9CHaHr/pP6nmDZofNvl7jZDp08E6/Sxk/BWkC0b2fGy7N+4CZrRP43dc+tuHBeR3k++WaJI5RspPM0AfWpgfmjDw==; 24:lEssslTlqoveIip3z7iH54yHYnDFCnt1nNkZ7GjjjnmKLwvbavpjuZLVfqjso8Thxe8dK0aoEksK0OOzv97uboFPVrRzk+vw5TlN6UYr/sA=; 7:jINfojHgGatIivw/n2w1DB8SwjKPLrZ0XWYtzm5dZg8pRAwSUEDER6n9IXcth+rtg83/keoIVJJF+MicVGPz+bEHSG48SnIueLus8drcFf/UA/Iahf5JBmUtOZhu1rorjAK48ElJgV+eNXR7zsG36oXL7yaC0JGJzJ6JLxIOk9kSx9SjVkqlNQmgUN1FsGVfhUK6eoUbHGqigOYyAvlco9ruaEDaZ3YvAOswjGhf3xs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2017 10:59:12.4711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2519 Subject: Re: [dpdk-dev] [PATCH v2 00/26] DPDK PMD for OCTEONTX NW device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 11 Oct 2017 10:59:19 -0000 -----Original Message----- > Date: Wed, 11 Oct 2017 12:35:27 +0200 > From: Thomas Monjalon <thomas@monjalon.net> > To: Santosh Shukla <santosh.shukla@caviumnetworks.com> > Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, > jerin.jacob@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v2 00/26] DPDK PMD for OCTEONTX NW device > > 09/10/2017 04:07, Ferruh Yigit: > > On 10/8/2017 1:44 PM, Santosh Shukla wrote: > > > v2: > > > Includes Minor changes like: > > > - Incorporated minor review comment (Suggested y John) > > > - Added correct pool handle ops name i.e. from mbuf-pool-ops to > > > mbuf-pool-ops-name in the doc. > > > - Rebased on Octeontx-fpavf v3 series and tested for same. > > > - Refer[7]: rebased (octeontx PMD + octeontx_fpavf mempool pmd) on upstream > > > tip commit : 3fb1ea032bd6ff8317af5dac9af901f1f324cab4. > > > > > > v1: > > > This patch set provides the initial version of DPDK PMD for the > > > integrated NIC device found in Cavium OCTEONTX SoC(CN83xx) family. > > > > > > Introduction to OCTEONTX ARM processors can be found > > > here: http://www.cavium.com/OCTEON-TX_ARM_Processors.html > > > > > > OCTEONTX SoC family has two types of NIC controllers, > > > 1) nicvf HW, Which is more like traditional NIC(no NPU HW accelerators) > > > http://dpdk.org/doc/guides/nics/thunderx.html > > > > > > 2) NIC controller, based on NPU like HW accelerated coprocessors, like > > > HW assisted mempool manager, HW assisted packet scheduler, etc > > > > > > This driver adds support for the second type device and which will be > > > used as HW implementation driver ethdev-eventdev Rx adapter [1] > > > > > > Implemented features and PMD documentation added > > > in doc/guides/nics/features/octeontx.ini and doc/guides/nics/octeontx.rst > > > respectively in this patch set. > > > > > > This driver has the dependency on: > > > - IOVA infrastructure [2]. > > > - Dynamically configure mempool handle (ie.. --mbuf-pool-ops eal arg) [3]. > > > - Infrastructure to support octeontx HW mempool manager [4]. > > > - Cavium Octeontx external mempool driver [5] > > > Git source repo for all above dependency patches located at [6]. > > > > > > The series has three check patch issues: > > > 1) 1 Error on Complex Macro (which I believe it cannot be fixed) # Patch 2 > > > 2) 1 Error on spacing while using gcc inline assembly(it is false positive) # patch 2 > > > 3) Added Co-authored-by: signature to reflect the patch authorship status instead > > > of "Signed-off-by". It can be changed or the contributing guide can be > > > updated based on the community feedback in v2. > > > > > > [1] http://dpdk.org/dev/patchwork/patch/24176/ > > > [2] http://dpdk.org/ml/archives/dev/2017-August/072871.html > > > [3] http://dpdk.org/ml/archives/dev/2017-August/072910.html > > > [4] http://dpdk.org/ml/archives/dev/2017-August/072892.html > > > [5] http://dpdk.org/ml/archives/dev/2017-August/073898.html > > > [6] https://github.com/sshukla82/dpdk branch: mempool-v2 > > > [7] https://github.com/sshukla82/dpdk branch: octeontx-ona-pmd-v2 > > > > > > > > > Jerin Jacob (26): > > > net/octeontx: add build infrastructure > > > net/octeontx/base: add octeontx io operations > > > event/octeontx: introduce specialized mbox message copy > > > net/octeontx/base: add base BGX operations > > > net/octeontx/base: add remaining BGX operations > > > net/octeontx/base: probe PKI and PKO PCIe VF devices > > > net/octeontx/base: add base PKI operations > > > net/octeontx/base: add remaining PKI operations > > > net/octeontx/base: add base PKO operations > > > net/octeontx/base: add remaining PKO operations > > > net/octeontx: add eth device probe and remove > > > net/octeontx: create ethdev ports > > > net/octeontx: add device configure > > > net/octeontx: add device info > > > net/octeontx: add link update > > > net/octeontx: add promiscuous mode ops > > > net/octeontx: add basic stats support > > > net/octeontx: add MAC addr set op > > > net/octeontx: add Rx queue setup and release ops > > > net/octeontx: add Tx queue start and stop > > > net/octeontx: add Tx queue setup and release ops > > > net/octeontx: add packet transmit burst function > > > net/octeontx: add packet receive burst function > > > net/octeontx: add packet type parsing support > > > net/octeontx: add start and stop support > > > doc: add octeontx ethdev driver documentation > > > > Series applied to dpdk-next-net/master, thanks. > > The tree dpdk-next-net cannot be pulled in master > because this series is breaking 32-bit compilation with debug enabled. > > Two comments about logs in this driver: > > 1/ We must not accept some DEBUG configs anymore. > Thanks to dynamic log configuration, we can avoid such compile-time options. > The same mistake was done for OCTEONTX mempool. > Please remove all these DEBUG config options for 17.11-rc2. > > 2/ When printing a 64-bit variable, %ld or %lx is wrong. > You must use PRId64 or PRIx64. > > We have two options for this patchset. > Either the compilation is fixed and squashed today, or it is removed from RC1. > Hope you can fix it quickly. I will send the patches to squash it.