From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0066.outbound.protection.outlook.com [104.47.41.66]) by dpdk.org (Postfix) with ESMTP id B80902C37 for ; Wed, 11 Oct 2017 16:34:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ENKlyDrzX9gDeF18ivD2WWiJHUxqj8GEqiD3P6w00+0=; b=TfeIW+muDYJrqTb2zUDrtvkB6/PP4wLHk4hHP9PtnJjq/hamaw/MGEuKmOtG4mcit1djOTF4Hxeo/oLTdW4eYw5zfBstdkkypdCmZsE5GQ9OEKI3ouFpa6kXcn4TKqttl82Y4XlZdORX9CxXWLP03MyiB4C2DMp7k87Qlhevhsc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (14.140.2.178) by CO2PR07MB2519.namprd07.prod.outlook.com (10.166.201.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Wed, 11 Oct 2017 14:34:10 +0000 Date: Wed, 11 Oct 2017 20:03:54 +0530 From: Jerin Jacob To: Thomas Monjalon Cc: dev@dpdk.org, bruce.richardson@intel.com Message-ID: <20171011143352.GA23500@jerin> References: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com> <30782747.pV0nTTKWH9@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30782747.pV0nTTKWH9@xps> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BM1PR01CA0115.INDPRD01.PROD.OUTLOOK.COM (10.174.208.31) To CO2PR07MB2519.namprd07.prod.outlook.com (10.166.201.6) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c8a4ca01-599e-49d7-ac83-08d510b523d5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:CO2PR07MB2519; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 3:4FD5zGqzj/n0f898hRZg3YW4ilvaYCAoXmirx7tKYcp5+FQsrhLkdLCpL+E/2Btp2ZastVymAvdSC5P7e3grNJfnRqqDiZHxEqpY6YQKQOm4bxlP/7sW3Dkb8pgmktgmsHrN1OcUG2U4558RQ+ONU4XAQJ9JTNar7whyKmMi39XJgggMsELH+qGjEaOa637D7UacoaVBVksBqGyWrRpAq4ZeKSP9ZqsDDSTPaxWQv0/ce9xF0hEw8AAWNwYhvguk; 25:RLxjgK0P+KCIzHdiNDTWuQKmFs83/C30Jf1RIwKHlptDuFG6rlJ5Bennw40STJ1E+X37ICurStUOqEKeG4xjVhXcApzZBwcKRCZFtBGvJ8RfGbxGi92w+8bl+xtqa0hKX1hbXOpJlEr8c7W+gsSV+sw3ZGLKm1yDbq7srYLkLjfupr9rJj4TTf5Kjr5DlHjaBM8W0m/veMQ0b82UhX2x06EQ+CxhWaMh7EFtLw0HK6Psm7XLVwWk6pFr1ncm0KlN6tDiT91lq/yun7P2oQ36h9R9StWx6yDnaUE/wGK03O9bPXoqqf9FEdqwzHoFux7wbDQgHP8+XJepbuatpPCBYQ==; 31:T4nAt5t1VQo6vQVO0Gu4aTwXd9qWou/2yw6DgFSGyLF6BuYxFIiglEY9ow1srTPdPZyAbZBVgSaZA0Vcofyy5wVURYIOofhMkCGdPyBwCDzxHWxbMvIsl188Xs8LQAGgwZnfvqn4i4YNnUYsVw9XY9IiTtcyiK9L2BJ7U89SUiOoto53b8eikw6EeG5uTJcd74PuR5UAR793cRfVoLpjCFjca7/X4+Hf646sjFQO8UI= X-MS-TrafficTypeDiagnostic: CO2PR07MB2519: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 20:Z2/rGsybmgZRKNRIz6V1cQ0Xmyd2FSCGzKq0qmDZ7/mfJoQJej4IQ4gn6qr6iw1Dk3kMqMyGBsAoVGS/seRP/A/oR4ViYl31HfJDvMDVXeXXDOOe+abzIYayNasiHacrofRM2xOFF5FYtECxbqKpEBx8JF14wxwHnBXwojE+x/KVeLJIsqIUl/2LvqThyRSNho+9esI9/V87xmVzLTy9ftIiDjPLqX/oa6r/y12IKNA/IvAwRxWYXZy4auVEIHO6d5l2FRDP4964ogjS3kFGbW4MKmRAj6EQuLF61/SO5YjZZSjcRNjA6vu0FoCu/H7rYgSCI9jr11XIc6ANPRcLMpzpHQnl0pJ38c+kyZZ2l2vsgQVWizokcJzHow+VMzS/T1qoyIbRrhhGEEzGqs/3L1Oxw9Q+LO9UP8i4UjmJD83jdQGif/0rsmZRNCd/u/5JeZhNpvu8QMfjiB50iKCwVmbII/aCxLZntiVMNmyH6LshAsTPsEmiJJD5xHp7gjMENfJIsj2lqckcGJQ7giAI6zJaeCWKWUNgbg8I+Y5CIwHCwMeoMBylyABuTPVy71wHKSvuD1HoJF4lznM6CaSGuY/tZCGldXprPvJKzbAMj50=; 4:8vOs+vhmaH28TACaKEkGJo0EPIuvDZz2vnVntuX1CWCAg78DwYW6TlJiyVT2abZEFGHQGdqSkQxH3Z+CXylVAXZRi3ut3hdp5dD9ATcT4zL4aL6yq5vVikAIH9QayGz9a06vMoQKNVeBdoZlRl3sOhr5jLafsdZIHvDVN0wJAjDryL3hHxi8ltysIoLr+6870rocn4g/yXquL9dBPlZ/aORoB5YImYh5yTz03E8wpiov/jPfT4Z+BVkIRM3WOItypU+WCZERekmTseflkV5/aXsdlwFMnUaDYRlVwTdyzPU= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR07MB2519; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR07MB2519; X-Forefront-PRVS: 0457F11EAF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(13464003)(199003)(189002)(23726003)(3846002)(101416001)(25786009)(6116002)(53936002)(1076002)(5009440100003)(47776003)(106356001)(68736007)(33656002)(5660300001)(189998001)(105586002)(2906002)(7736002)(9686003)(305945005)(6916009)(2950100002)(229853002)(4326008)(8676002)(6246003)(81166006)(6496005)(81156014)(33716001)(16526018)(478600001)(97736004)(42882006)(50466002)(83506001)(55016002)(316002)(66066001)(54356999)(8936002)(58126008)(6666003)(76176999)(72206003)(16586007)(50986999)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2519; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2519; 23:pwY4Rb/3eqpUsj88Ddiieh5SovQEOjZoHkSuDCKAl?= =?us-ascii?Q?tSkRloUn7kUr+IsksSw5ELbxpA01bsZi3xRMQVhu4hvuidDnzUAggbSQQjqq?= =?us-ascii?Q?MTR0uF2ektLm6s+elQ6WZGrMgkjBwfR0UDfBYDCKX48H/RKJO1GdxxsCmUUq?= =?us-ascii?Q?RfDJw5QDHgsNl9Lg4UMUCNjrnL/ftsE3XY/o2YjUH/UDP9pec+vHhQefGeLo?= =?us-ascii?Q?kaCk3bDFSe4KxUhPTRt44pPInuA75fQGCqs+gh8OV0dwEEmLQQ+R4huYRYvs?= =?us-ascii?Q?vC+TwjjVBCQ3vhUPCOafxVRpa7C59roR89FJ/Q7XkwiyaUhSCaMFDyRyBW3N?= =?us-ascii?Q?86TFGlXVCMZFfd0mAOCLE0LCmK0YpsCUUl+KDSHUO2K2syUnaxXqg5ECsd9Q?= =?us-ascii?Q?88KgnQ5rw9Sa2a78SXAL0MGJSelCaZ5CsYkkNXcfn36lhphzGskCVKm53tX1?= =?us-ascii?Q?lYq4bryfRIqdzUMhXZ8K9Q/3ImsOx2HChAMnzY5VMDzpmKWve3yW/RrKGBD1?= =?us-ascii?Q?c9X+leYRxOfXjwbW6rYv9/SwzSoLdlHOep3ivhNUHTLKwwqGxqUt6+fmw7iv?= =?us-ascii?Q?fsbxvg/37/GebXEMSbf6CQEDYnvDkJhZA4QblZ4YjzL6xn5Cf+eQtl+aejnU?= =?us-ascii?Q?qZMOI18xXBNYvdAHrkWDFqmWUgm2327lDLU5WH8ae1Dr8r8e4utKsXqJ0nBD?= =?us-ascii?Q?svYdVyOBjTrCizPxknOQMpCeAdwhS+JEVQqTH5aZ/PrdvaBFLLPCaBr0iHk7?= =?us-ascii?Q?u5b70VIeqKnuiAG8RE7Nfh5zg76s3ftdiRb0Mo3nV43HrLg1NXeGt+bxxdPr?= =?us-ascii?Q?HGaQdCQidOaYuXrZbUWvWJ7GmwEDJtVn8kwwKV6qaZxykwuWJ25Lx9R3SFUe?= =?us-ascii?Q?dHZDxLtvMrz7Dm9aPgaH1WrI5lg709sOUjE/hbf7QwXvGwnRw/RZboGjwD8e?= =?us-ascii?Q?WGcBnYdF7/GAy8Br8gsw+UbXkjvgM8NODLTgdAlS/vEH1P/OnDB2ueOeE+nJ?= =?us-ascii?Q?z6mYl+vHIeHjWiTbbyqqbpfGf+y2jJswWMMoK9KKTTYaQOeMFw4Qr4lYevOh?= =?us-ascii?Q?LMpNA8QKG7tHeofccJHYMlazPAZBJ8A0V3WJO3KUNs5g7TUpk9VVnY5WtPRG?= =?us-ascii?Q?iZnnVsFKvyOVaUpaOHripVZEDL7nU/gFs1a24R+8owmrPzmC4WRW8/CoPhjl?= =?us-ascii?Q?zLSJdEEWq2xeYhaPF4qXqXbA/P3t9G96czUc7Hx+aQQqjKw5YaeXTcK6DE03?= =?us-ascii?Q?vOS8q4Enjb3I/MMDvI=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 6:NQth4kkPRqaczmDQAXYRnksVhORtmwG/dytN9adOT6sQQ8DdPs9GIR7r/lCCwN+NWpMWJYLNBjHPGkBC3Zb81QQ/NCZsrzn8TFTRnfl5FsRLbiEQdEBzlQU1mz89hb1UN0ZSusFvuRtWFiN/shAnjt7q+2n7aZ01lTxPfwpN3oHF9HAwXieG5CsCcKvvxn1j1/24rbPKlNb6NMJ+31YGPRCms4n3RigNeZtnibMdEcGAyHt9Ee5feeWyJjrCcNMGTLMaxctM4/o63cY6wCmMFM0k0cbTneO49kOMxBCKOUZyc7DncRF7MXelrIbmwcxfxMDICWoIHecGDc9f8SMGIw==; 5:kL6n063I2Ydb+e6bgB+1UrVrQUZbcydvoDNI/bQEhSOcbx60jzYKq0ELDsjOsrw2VNie+0iWO8gS5194n6mhtVk6KJqPvN7MbOonVOXd49ZplafBf2+erg9iKHfIS23t7/in2M5L4rVgVV+hYF9+Xg==; 24:BBx3yf2Psnbh1YGpv1VzzFPKrw/nMc3FgH8mIyiqeZSxHatwq1kFFuWumr/optAy52bSgcySOCb9E9NqeUufO+PThFM/WJqNZ7Y8WauiAXk=; 7:2jabSSKGUtJY9V54mbdiuqYm4komeNnSQ36EQNl9qhSOjZt6Cdq3MklxcjsAyhh/bH88uuSAbrqmPTJYCxYmftIjF4Z+8w65SA1uZIEaJSoB13XKM+PGz5ueYVZJH4/RztvZ2Vz8cdi8wvdqIbZtJhsoGLlDH9soGtj092lY7TS9KY0M+E+Qg7DKa4MWlVeZvVDISYhYnyHxqN7leE2SRj2pSoVX09Q0pFfzAqgzEA0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2017 14:34:10.0373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2519 Subject: Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 14:34:14 -0000 -----Original Message----- > Date: Wed, 11 Oct 2017 15:02:51 +0200 > From: Thomas Monjalon > To: Jerin Jacob > Cc: dev@dpdk.org, bruce.richardson@intel.com > Subject: Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment > specific > > 07/08/2017 14:04, Jerin Jacob: > > baremetal execution environments may have a different > > method to enable RTE_INIT instead of using compiler > > constructor scheme. Move RTE_INIT* definition under > > exec-env to support different execution environments. > > > > Signed-off-by: Jerin Jacob > > --- > > app/test-eventdev/evt_test.h | 2 +- > > lib/librte_eal/bsdapp/eal/Makefile | 2 +- > > .../bsdapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ > > lib/librte_eal/common/eal_common_log.c | 2 + > > lib/librte_eal/common/include/rte_bus.h | 2 + > > lib/librte_eal/common/include/rte_eal.h | 6 --- > > lib/librte_eal/common/include/rte_tailq.h | 2 + > > lib/librte_eal/linuxapp/eal/Makefile | 2 +- > > .../linuxapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ > > 9 files changed, 111 insertions(+), 9 deletions(-) > > create mode 100644 lib/librte_eal/bsdapp/eal/include/exec-env/rte_eal.h > > create mode 100644 lib/librte_eal/linuxapp/eal/include/exec-env/rte_eal.h > > I am not a big fan of duplicating code for Linux and BSD. > > Maybe we should have different splits and include a common file > in Linux and BSD? OK. This is doable. > > I feel it would be easier to think about the split when adding > a new environment. > It is also an open question whether we want to support (again) some > bare metal environments. IMO, A factor could be, how much we are OK to change? Our internal prototype implementation for a bare metal environment shows things are already in place and may need minor changes like this to accommodate a bare metal execution environment(accounting the latest changes of moving pci to driver/pci/..) If no one care about need for such abstraction then we could drop this patch. We can always keep local copy of such patches in our internal tree. I thought to upstream it as it may be useful for someone else and it is easy for us maintain if changes are in lib/librte_eal//eal/ and drivers/*/