From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f50.google.com (mail-lf0-f50.google.com [209.85.215.50]) by dpdk.org (Postfix) with ESMTP id DADE423A for ; Thu, 12 Oct 2017 08:07:27 +0200 (CEST) Received: by mail-lf0-f50.google.com with SMTP id b190so4718166lfg.9 for ; Wed, 11 Oct 2017 23:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=BDsjk/htRzlPhFkeTmweu1vMkB5iNwPCOnn68khZunc=; b=e8jP/qPBpryn49XiEOGgIrj6VeLkQWxrdR7UzZFBZvYZyApZONI45CTsQBTkPrYPdb yJ7KUuprQKbhY+8txMPi/JItfAzWlIO1pCmT1fCnCW3EAs0wQS66A1eWj5oECEDsflZj 49EtyfWMN3Ft0eXzQglwSsBvnK+/q8/b3mSEKO0nIS015MBub3TSROdE4GMKPV2xqLi3 Kn1cg/K4TyJRyNxovhgX0wctOC8ELQAitwGUDeTqgRjGZX2bi836YpOMMoRqtV8dIhRE biqITS/ooMrifJMuiaqmJWTd4LppMvv8RsiBwJ64HpcsEpcxei84uDxl8Tn8NViRSj7b a7cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=BDsjk/htRzlPhFkeTmweu1vMkB5iNwPCOnn68khZunc=; b=MS2aMSZtRlGcVCDyKAkiHIlckouNQq6pfc3sP75Pg0f4r+2anmZjt8j8yi5ai1OJkp SVd7dRyYWUuleMmoOPuoVuUfwJithLxxTOySxO8vh3cIt7XN2jvl6P0hv97NFEkOJ3WM F0B8Wh8klpmcxQP/LPRdHw2CLfyBLR+y/ufucCubs/+GyYv+KBuUnXsnEIqROmYoFZCT ZNH2amzmeX90MD79nhvLL8Abw9iSbBdjn0Z5Hs+HvHMVfNHkayB36+3XQmXLnKY4Wsu0 ql1rs48sBqnSJhZwPoxUw9cvEUv4GDVvW7IX5BqbSwAJ9Mv0Z9ASvbohob6iZuXVBC3S aPEg== X-Gm-Message-State: AMCzsaUR96qEfNBQ0qGHO58UodoP5uMk5fmGTqFztD4Xb8SBsVbiVE5W HlYHAZ99NYGHo6GSJ9BJWSQecw== X-Google-Smtp-Source: ABhQp+TTCJ98uilCJGmxpqGfCePOuQ9c4WGL+Ai7ORCDS3KO7Y5gWZbL98GhNZVWKIpctNtE92L6TQ== X-Received: by 10.25.178.206 with SMTP id t75mr474559lfk.228.1507788447328; Wed, 11 Oct 2017 23:07:27 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d24sm2565831lfc.85.2017.10.11.23.07.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2017 23:07:26 -0700 (PDT) Date: Thu, 12 Oct 2017 08:07:25 +0200 From: Tomasz Duszynski To: Ferruh Yigit Cc: Tomasz Duszynski , dev@dpdk.org, mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@linaro.org Message-ID: <20171012060725.GA19106@tdu> References: <1507031500-11473-1-git-send-email-tdu@semihalf.com> <1507561244-20115-1-git-send-email-tdu@semihalf.com> <1186b189-bb4f-0fb2-602d-6003b9371ea6@intel.com> <60720e51-6dd5-b7dc-5de1-a1e6b0a681c6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <60720e51-6dd5-b7dc-5de1-a1e6b0a681c6@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 00/16] add net mrvl pmd driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 06:07:28 -0000 On Thu, Oct 12, 2017 at 02:51:19AM +0100, Ferruh Yigit wrote: > On 10/9/2017 9:59 PM, Ferruh Yigit wrote: > > On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: > >> Hello, > >> > >> This patch series introduces the net driver for Marvell Armada 7k/8k > >> SoCs along with documentation. > >> > >> Below you can find the list of features which net pmd supports: > >> * Speed capabilities > >> * Link status > >> * MTU update > >> * Jumbo frame > >> * Promiscuous mode > >> * Allmulticast mode > >> * Unicast MAC filter > >> * Multicast MAC filter > >> * RSS hash > >> * VLAN filter > >> * CRC offload > >> * L3 checksum offload > >> * L4 checksum offload > >> * Packet type parsing > >> * Basic stats > >> * QoS > >> > >> Changes since v3: > >> * Split driver into skeleton, rx/tx, features, documentation parts > >> * Added speed capabilities flags. > >> * Added missing rx offload flags: VLAN/JUMBOFRAME > >> * Updated release notes. > >> * Updated documentation. > >> > >> Changes since v2: > >> * Removed LINE_SPACING, MULTILINE_DEREFERENCE and SPLIT_STRING > >> checkpatch warnings. > >> * Removed unnecessary forward declarations. > >> * Fixed whitespace warnings. > >> > >> Changes since v1: > >> * Changed commit message to explain problem better. > >> * Removed bunch of checkpatch warnings about unnecessary parentheses. > >> > >> Tomasz Duszynski (4): > >> app: link the whole rte_cfgfile library > >> net/mrvl: add mrvl net pmd driver skeleton > >> net/mrvl: add rx/tx support > >> net/mrvl: add link update > >> net/mrvl: add link speed capabilities > >> net/mrvl: add support for updating mtu > >> net/mrvl: add jumbo frame support > >> net/mrvl: add support for promiscuous and allmulticast modes > >> net/mrvl: add support for mac filtering > >> net/mrvl: add rss hashing support > >> net/mrvl: add support for vlan filtering > >> net/mrvl: add crc, l3 and l4 offloads support > >> net/mrvl: add packet type parsing support. > >> net/mrvl: add basic stats support > >> maintainers: add maintainers for the mrvl net pmd > >> doc: add mrvl net pmd documentation > > > > Series applied to dpdk-next-net/master, thanks. > > > > (I can't compile because of missing musdk library, but since PMD is > > disabled by default this is not so bad, lets get this for rc1 and for > > crypto dependency, later I can have my environment set and test) > > Did able to compile but I have questions :) > > 1- Used the "arm64-armv8a-linuxapp-gcc" config, can you please confirm. > Does it make sense to document this? Right, that makes sense. > > 2- I used different toolchain than documented in musdk, which uses a > marvel one. Can you please confirm any aarch64-linux-gnu-gcc is OK? > I am not sure that every toolchain out there will work but those available here https://releases.linaro.org/components/toolchain/binaries/*/aarch64-linux-g= nu/ should work fine. > 3- Used following command: > CROSS=3D/aarch64-linux-gnu- make > EXTRA_CFLAGS=3D"-I.../musdk-marvell/src/include > -L.../musdk-marvell/src/.libs/" > > Do you also need to use EXTRA_CFLAGS? Otherwise I can't compile. If you > also use it please document it, if not please share with us how to do? As for MUSDK I build it as follows: export CROSS_COMPILE=3D/home/tdu/workspace/gcc-linaro-5.4.1-2017.01-x86_64_= aarch64-linux-gnu/bin/aarch64-linux-gnu- # in case of the first build =2E/bootstrap # later on that will do make clean =2E/configure \ --host=3Daarch64-linux-gnu \ --prefix=3D$(pwd)/musdk-install-dir \ --enable-sam \ --enable-bpool-dma=3D64 \ --disable-shared make -j8 make install As for building DPDK that works for me: export RTE_KERNELDIR=3D/home/tdu/workspace/tmp2/linux-marvell export LIBMUSDK_PATH=3D/home/tdu/workspace/tmp2/musdk-marvell/musdk-install= -dir export CROSS=3D/home/tdu/workspace/tmp2/gcc-linaro-5.4.1-2017.01-x86_64_aar= ch64-linux-gnu/bin/aarch64-linux-gnu- make -j8 > > 4- musk generated a static library, can you please confirm there is a > way to generate a shared musdk library as well? > To generate shared just remove `--disable-shared` from ./configure command line. Then you will have both *.so and *.a generated. > 5- Still not tested building kernel modules, and building musdk with > ./configure options, I will do later. Let me know in case you have any sort of difficulties or something is unclear. > > Thanks, > ferruh -- - Tomasz Duszy=C5=84ski