* [dpdk-dev] [PATCH] app/testpmd: remove useless funciton declarations
@ 2017-10-16 2:30 Zhiyong Yang
2017-10-16 10:18 ` Thomas Monjalon
2017-10-21 0:54 ` Ferruh Yigit
0 siblings, 2 replies; 4+ messages in thread
From: Zhiyong Yang @ 2017-10-16 2:30 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, thomas, Zhiyong Yang
The four function declarations have no funciton implementation,
remove them.
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
app/test-pmd/testpmd.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 265b75f9f..15ebf8c92 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -698,10 +698,6 @@ void port_rss_hash_conf_show(portid_t port_id, char rss_info[],
int show_rss_key);
void port_rss_hash_key_update(portid_t port_id, char rss_type[],
uint8_t *hash_key, uint hash_key_len);
-void get_syn_filter(portid_t port_id);
-void get_ethertype_filter(portid_t port_id, uint16_t index);
-void get_2tuple_filter(portid_t port_id, uint16_t index);
-void get_5tuple_filter(portid_t port_id, uint16_t index);
int rx_queue_id_is_invalid(queueid_t rxq_id);
int tx_queue_id_is_invalid(queueid_t txq_id);
void setup_gro(const char *onoff, portid_t port_id);
--
2.13.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: remove useless funciton declarations
2017-10-16 2:30 [dpdk-dev] [PATCH] app/testpmd: remove useless funciton declarations Zhiyong Yang
@ 2017-10-16 10:18 ` Thomas Monjalon
2017-10-17 2:36 ` Yang, Zhiyong
2017-10-21 0:54 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2017-10-16 10:18 UTC (permalink / raw)
To: Zhiyong Yang; +Cc: dev, ferruh.yigit
16/10/2017 04:30, Zhiyong Yang:
> The four function declarations have no funciton implementation,
> remove them.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Please add Fixes: line.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: remove useless funciton declarations
2017-10-16 10:18 ` Thomas Monjalon
@ 2017-10-17 2:36 ` Yang, Zhiyong
0 siblings, 0 replies; 4+ messages in thread
From: Yang, Zhiyong @ 2017-10-17 2:36 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Yigit, Ferruh
Hi thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, October 16, 2017 6:18 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [PATCH] app/testpmd: remove useless funciton declarations
>
> 16/10/2017 04:30, Zhiyong Yang:
> > The four function declarations have no funciton implementation, remove
> > them.
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
> Please add Fixes: line.
Fixes: 0db70a803028 ("app/testpmd: add commands for filters")
Thanks
Zhiyong
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: remove useless funciton declarations
2017-10-16 2:30 [dpdk-dev] [PATCH] app/testpmd: remove useless funciton declarations Zhiyong Yang
2017-10-16 10:18 ` Thomas Monjalon
@ 2017-10-21 0:54 ` Ferruh Yigit
1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-10-21 0:54 UTC (permalink / raw)
To: Zhiyong Yang, dev; +Cc: thomas
On 10/15/2017 7:30 PM, Zhiyong Yang wrote:
> The four function declarations have no funciton implementation,
> remove them.
Fixes: 0db70a803028 ("app/testpmd: add commands for filters")
Cc: stable@dpdk.org
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-21 0:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-16 2:30 [dpdk-dev] [PATCH] app/testpmd: remove useless funciton declarations Zhiyong Yang
2017-10-16 10:18 ` Thomas Monjalon
2017-10-17 2:36 ` Yang, Zhiyong
2017-10-21 0:54 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).