From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0080.outbound.protection.outlook.com [104.47.41.80]) by dpdk.org (Postfix) with ESMTP id 1DD5A1B70E for ; Tue, 17 Oct 2017 07:01:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=T+Hjmcuf4LaF6kvZvjAnGFYgHMzs8X3MBKNYgsO14hE=; b=LTaMl3495LKEWcbsNlS9DCgXgZ6iqbsC582onkS6vEf6E/DQNInsy5XAaW/7NsNkqWA8MwH8N4tnB2X6fReHyBuUMAg4fcJBjkaKrMWPZyb8iCxZcknX+HwhISdgxj1CFCksxas+S5s4w5EhS3NoJIQTacwEPnuBOBNm2kR7C+I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 17 Oct 2017 05:01:16 +0000 Date: Tue, 17 Oct 2017 10:30:38 +0530 From: Jerin Jacob To: Nipun Gupta Cc: dev@dpdk.org, hemant.agrawal@nxp.com, nikhil.rao@intel.com Message-ID: <20171017050037.GA4009@jerin> References: <1507657887-11366-1-git-send-email-nipun.gupta@nxp.com> <1508190275-32305-1-git-send-email-nipun.gupta@nxp.com> <1508190275-32305-3-git-send-email-nipun.gupta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508190275-32305-3-git-send-email-nipun.gupta@nxp.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0108.INDPRD01.PROD.OUTLOOK.COM (10.174.208.24) To BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a755732a-aa4b-44ae-6518-08d5151c19d2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:dIVNie55oRWdCA2QZo1nwzK5ZkbxQCPEljBMhuY+GmBAhU33bmqwXfQXzaTy8gg9ZVxaKAnohXc56WPdHcw6Gu1tLvVfSqKheUHtR5pewbF+EskOn/KxIJeGFt+7pIXNadbDuEMzd+V89+HUV5MwJ32hXNYIFpap/PiAztoQijbB24KEsdI/MHtxPfEjbBnoNpzPf+MaFo15axcvwTHM8/p0uGDOvMhHGaN8ZQTnqpoQZ3Uhb5rU4QHz5WjlDdD6; 25:j5nAi6ppLPo7I8IWlVI4W9LA7g9mUe7AGDWKu6F3ehTHzhKjiewoDvAgDw5Bp9BItCygBFffRSBn9D07q3Q3rXsCqAxqRSZTGgqEvWeEXLM4U2PbS9/8phHUHf72dZYCZwx+EapC4xk/jVrJX4B/TrrUgL6tovgf/D7mkZTXn2j5vSOi7Ve+mWtnUUkVdrdUJGE2qUYGrCV2RMYIqtJXz6AT2BfKWiCk+5cHpnCojPpQghqVMy7aXAdI1rWzRJ9ueyqzaNY4Sfu6SseBPMPc8Uegi+Btz2QXy+ShUHIOKPJVcRjMh2LGRP6z6fSU8df737HoX4FAmMJAzC2jNK/zoQ==; 31:Z8KHbBOHJcrGW4Xj+dsRe4OWA9OK6V7g1fahmNPg/poyQ2gz1eNmV0cxHh37PT+c9OPLtAYRIQ9jlTBQlm+gPCo9Qu1L1OXyQeO8CC8rIPBeLOoBzX9EdmI0fVXJg7m3C3HRdpFlBo6SuPpikULv7vZ0kyIdZZO5jbjdhKrf3dOXEEmz7IU34HbeZbTcT9obmMrn1qoFHWw6to2ToemvGLofx03/PLdoSFCK9DJhuzo= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:q4X9xilbbWuDOHVNuSom8E7spu8nSccn2V8/Q3kgzuEmeGig+EgHOo7FNLPr5T73iqro1F9C2NE8XnlTPbDyFWcHFaTE5QoEn/ZBBw1lXZckp2+n5qXj8fDhDZer9lQqxnVR9MEb5J7IcJIbqAEM1G7yWxingNi0KlxCWC6mnh2EQ6uOMlAg3hKouU5SKshTWp9juvvtwh4fj+dkLdzWWJI3gxe0o1K+MZkzZC4wv5IF3F70rxKtktBPywb3Qa9n4wduDfZxNd9HhjbWpkD5dJhTZqTDuuY0wKhxTI8XXgcOGdwJ9hexScvo2bMl26FZ/xLRsV+vQdc4TjuG4StQ/s5c63nL7KUCpvqJLEGGLm2QkN52Trtk5KzgYhzq1CzWzPg5/tYMMPo1nHiT5u10iw2JVfrDsC1wT9V3kw08+a0YTrTGika/r4D7muai+PaA+1QdKkbNo+hEQH3sTcUK00R8bqfBhY+tzkt4NEfGAh+HXf9j9YF5pioHM4yxQtY34fDuvKcqZyilMNPA6NC80utx6ef/5gAYUzPfWxf/9FyyzpqN2sa3MfVbR6rpFBBH4BDFXIf3A5fQ24lHx1nQw7JDS7KgMYYEc0JNLoZANek= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(10201501046)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 4:i9hvkKv51eTzNXdeQeqGsPUh9CI9iX6BdDJiER31CRsNozS5FpVr0BfPx49Y3tYbn26hPKkwEvYioWFRR6cWVjamLi1Uj6w1O/6pqVOHazvcVZwOFYCuVDvqYsfBe4BnJs1ZfwSj5P1s6eXNBr8ox9SPI0qbpxa+v7T5j48voGqw5hR3IjyTYK0N/hoN+3CVtijdr14CQ75r3zLhvcJRNxa269nq+LB4/W3zTRWC5v4T8p9TRIkdAKCJAXfAz0BQx2rd6bQdc1AybjPOH062VrEhr4jZTKFyasl+fZhvQWYZkv0z2dZYXRYIkxJo5HDLbGiqtrZVWdLPVgamdk8vAQ== X-Forefront-PRVS: 04631F8F77 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(189002)(199003)(13464003)(66066001)(47776003)(23726003)(189998001)(6496005)(6246003)(5009440100003)(3846002)(6116002)(53376002)(50466002)(72206003)(16586007)(83506001)(16526018)(97736004)(316002)(50986999)(478600001)(8656003)(76176999)(58126008)(966005)(54356999)(33716001)(68736007)(4326008)(101416001)(575784001)(5660300001)(42882006)(229853002)(25786009)(6666003)(1076002)(81166006)(2906002)(33656002)(9686003)(106356001)(55016002)(6916009)(2950100002)(7736002)(6306002)(81156014)(8936002)(105586002)(53936002)(8676002)(305945005)(533714002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:1LbyEt5RfaZIYV6fBWtcR8Or5aLywMPKvrLPBfb4E?= =?us-ascii?Q?7gyOeIP1QF2siaU/H672LmIgeK0w7vA+lQbPNxraLxIiLHu3O3gdlQ9Tp1oM?= =?us-ascii?Q?vOWVTMmnH6KsRNuhogX6HDHr6ERpqmHnyeIVGRg9OrLgFW7rltaCuaxQBuAn?= =?us-ascii?Q?bhXkY1gs+GnXlq+8BRvqgL/vQp5Qj0HiLCAYGLnqRmG61YavwnEU/eVmNEf0?= =?us-ascii?Q?ImFJ08DNqEhmGxI1usllndUuoKbiyAsBsm+HVcfwOSwbLNZD368AyxXOYEuj?= =?us-ascii?Q?8cRReNCWrwWZ0tx+WVdSddcV6WXwxli3j/t7WxOCovjvBojETngvaQ8hjaiF?= =?us-ascii?Q?Lf2KplXyigbNFPn0igLNQZHGzb8zF33pZM5GYlp60p+wXh2CxiY7l6XeKRoD?= =?us-ascii?Q?FSkuzjPOaqyj8Fw5oSwSP3rtju/ZyR6/4lzDroo/42Bvo8h9so388gX6e7nc?= =?us-ascii?Q?wU2/c12sxNhhkm33f2vxPowFa8tF14bi9pRcZrQ5MTdsHTSrVJ4VTNW7kPGv?= =?us-ascii?Q?zXaQULXC/k0xXj8p62/f1Rz5wHkG7Lx+mW66d52QYSkdrsCoMOBTsG+LkYHt?= =?us-ascii?Q?hm5qyZgbvVi2t+LzgZDhruf6sg9rNSYV/gCocOyVIFE2jvkhaRiHR6lSFues?= =?us-ascii?Q?hVwqoJep5C+DGjz1vrxcdtpyU/GjaoJ6iBHFRIjBRTsmkLNC73NlVUD3Oyfd?= =?us-ascii?Q?oQnuSlIDf6/GfFBqA33nrjgqbUmuSpv9arz8ItWmyESc6m5s8S0AyGvaOiCv?= =?us-ascii?Q?F1TofXTvF3I0dYeo36ZEtud9UqCYHdajltTBTSlcN2+R5PeR5Im3DgFMttgZ?= =?us-ascii?Q?NFBIGqlCcMfIKlRRKTjD2MdVTVT1+W0cuSot0OQITYA6cVyQz0upfKPAW9WM?= =?us-ascii?Q?314kSSmGkQFHWpGyOiRCmvmoban4ODGH/yNs39ffC7A6ZQsXclmDm05gx2JB?= =?us-ascii?Q?0+L+36TGtrY1QI4y8He6gfaANaUhUPVfsc/AvCatg3rIsxX3iQ2gAGDl9OIr?= =?us-ascii?Q?m/n/59KRl6T8C/7oBRWtfLt5t/buCwNB2ifzC9T0a+72ncSDMsou6hczqJZE?= =?us-ascii?Q?yiyLjAvtpYFWmJ6MsnfysAOLz8CkQr+XiDLphg4ajd0tN5htQztx8VX2DoS3?= =?us-ascii?Q?QV1FjnNHTvgPHmyDGqSKdIkFrRNf3G9x/MmWZvJE08NB/Zuk+KssvwVABM96?= =?us-ascii?Q?RyNvxCaa+8mxQiBHkN/zYdNUIhA3eeLN3sBcCg+DeNy07jdSD7cU4MMjidYw?= =?us-ascii?Q?Uxi/4Sjq+XIrWU/AGl4PCkMig3/KK7wWfXs3WENSp3z17GFxsBnmeZ7jic2m?= =?us-ascii?Q?3PTbmrRs3xVta0+pfxfW8mZfeTwQLMv3WiZF3aEGEiOVlE+tEG9ojOOCGwaT?= =?us-ascii?Q?NvH0Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:g2Ca7Aphz72ighZ/SPyURGpOEZiOr7CpFn7UK5K0HSDvz49F98VcU9KVxbsocthq5zV4q4vlJx3awDVBjo/QwcBqEayl0CIJTJSUF1Ej2oeJkYUXbE6vdspWH7IyZtL+i0MC1MLcMrZeCF5KxAGFVuCFOEvG12j4tWaCba0FXiV5lF2OtWyDmY21N+RsNGefh7czTRGE2ppe+oPypFK3NgLMj+1Tujk2yQaXBdzYMiTfGpzQ9RhU4rZcteyBl+F6BtwP+rCVzVMrKDShsRn5RFj0ghghjYR0AuS4uGfsr3otq1tqBGoUbci4cSiYp5XG2GUBveGpdZHWq6GtcqNfNw==; 5:svsBzKflCmek16WSwjCFY+PHDQJLd+Rs6xlZG05HhLuFd4O5HKGmmJOnGjt8CGyfWRP+RtjUkIaxFGku+x9kQzwBSoHWNnckDredz5QMtwcCgOkQoJ4jS1y5zf1QZP1uKj7fK8xeY3fRpP8pSEPhRA==; 24:Ka1gcv3wMe9LcD0OUCQtCDnqS1CiSY5SbvyleGbCz0FdcAh0UFMV2UFfFtdHI0BEhnHVvddrDZl4gZKqlOiWiPMmE8MMiUwjZOt6aNGYtI4=; 7:pTEFw2R7iDjz5Tyyw9IoiChuWMGVfyMWcCDxrGW4tcoLfKYc6LaydSvugJguo1OW/OdP+zA4IW+SLs+1/liVJm4fyAxKkedMOnLgrITcSfXiax2P9/bJ05KWNwt2eIpfPN/MiKSyYgpjFTy6lbmgE/u0809A8vBi6fe31MGSrK8xbqjy6Ep4qdwJkBXgM2AvaZikJSWabAqu+1E8tSlZdG6A4rDUYLssoG/QM78VDc8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2017 05:01:16.4434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH v3 3/4] event/dpaa2: support event eth adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 05:01:20 -0000 -----Original Message----- > Date: Tue, 17 Oct 2017 03:14:34 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agrawal@nxp.com, jerin.jacob@caviumnetworks.com, > nikhil.rao@intel.com, Nipun Gupta > Subject: [PATCH v3 3/4] event/dpaa2: support event eth adapter > X-Mailer: git-send-email 1.9.1 > > Signed-off-by: Nipun Gupta > Reviewed-by: Nikhil Rao > Acked-by: Hemant Agrawal > --- > Changes in v3: > Fix shared library build > Changes in v2: > Support rx_queue_id = -1 in eth adapter queue and and del (Nikhil) > Remove duplicate returns (Nikhil) > > drivers/Makefile | 2 +- > drivers/event/Makefile | 4 +- > drivers/event/dpaa2/Makefile | 2 + > drivers/event/dpaa2/dpaa2_eventdev.c | 151 ++++++++++++++++++++++++++++++++++- > drivers/event/dpaa2/dpaa2_eventdev.h | 8 ++ > 5 files changed, 163 insertions(+), 4 deletions(-) > > diff --git a/drivers/Makefile b/drivers/Makefile > index 0467250..db0cd76 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -39,6 +39,6 @@ DEPDIRS-net := bus mempool > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto > DEPDIRS-crypto := bus mempool > DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event > -DEPDIRS-event := bus mempool > +DEPDIRS-event := bus mempool net > > include $(RTE_SDK)/mk/rte.subdir.mk > diff --git a/drivers/event/Makefile b/drivers/event/Makefile > index d09be74..e119d60 100644 > --- a/drivers/event/Makefile > +++ b/drivers/event/Makefile > @@ -31,7 +31,7 @@ > > include $(RTE_SDK)/mk/rte.vars.mk > > -core-libs := librte_eal librte_eventdev > +core-libs := librte_eal librte_ether librte_eventdev The above two changes makes sense to me as eventdev-ethdev Rx adapter is depended on ethdev and there could be an Rx adapter implementation in event area that may use ethdev driver exported API. Can you split driver/event and driver/Makefile change to different patch? Other than that, This patch set looks good to me and it is ready to merge. But, There is a compilation error[1] in event-next tree be case of Hemant reported problem[2].I can apply this patch set once the solution for the reported problem[3] is applied to master branch(so that I pull those changes to next-eventdev to avoid build issue) [1] Applying: event/dpaa2: support event eth adapter /export/dpdk-next-eventdev/mk/rte.subdir.mk:62: target 'event' given more than once in the same rule make[2]: Circular mempool <- event dependency dropped. [2] http://dpdk.org/ml/archives/dev/2017-October/079249.html [3] http://dpdk.org/ml/archives/dev/2017-October/079324.html