From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH] build: fix EAL path to drivers for static builds
Date: Tue, 17 Oct 2017 17:41:02 +0100 [thread overview]
Message-ID: <20171017164102.71159-1-bruce.richardson@intel.com> (raw)
For static builds, even though the drivers are installed in the lib folder
that does not mean that that folder should be set as the EAL driver search
path. If it is, EAL will try loading all shared libraries as drivers and
fail to start. Instead, track the EAL driver path separately from the
driver install path, allowing static builds to have an empty driver path
by default.
Fixes: d8b85d98b3f7 ("build: add initial infrastructure for meson & ninja builds")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
----
NOTE: on apply will be merged into offending commit in next-build tree.
---
config/meson.build | 3 +--
meson.build | 2 ++
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index ce26a29f0..8e4a703c7 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -71,8 +71,7 @@ endif
dpdk_conf.set('RTE_COMPILE_TIME_CPUFLAGS', ','.join(compile_time_cpuflags))
# set the install path for the drivers
-dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', join_paths(
- get_option('prefix'), driver_install_path))
+dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', eal_pmd_path)
# set other values pulled from the build options
dpdk_conf.set('RTE_MAX_LCORE', get_option('max_lcores'))
diff --git a/meson.build b/meson.build
index e3d40ac38..4af057615 100644
--- a/meson.build
+++ b/meson.build
@@ -47,8 +47,10 @@ dpdk_extra_ldflags = []
# for shared libs, put them in a driver folder
if get_option('default_library') == 'static'
driver_install_path = get_option('libdir')
+ eal_pmd_path = ''
else
driver_install_path = join_paths(get_option('libdir'), 'dpdk/drivers')
+ eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
endif
# configure the build, and make sure configs here and in config folder are
--
2.13.6
next reply other threads:[~2017-10-17 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 16:41 Bruce Richardson [this message]
2017-10-23 10:32 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017164102.71159-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).