From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 4E6A31B61B for ; Wed, 18 Oct 2017 10:54:45 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id i124so8479288wmf.3 for ; Wed, 18 Oct 2017 01:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=uLXWHAGXau1JEokNmFMP4AR5ztQQuAP+Q+X5aK/THBc=; b=V4WQHaXnmdIWKqaDKkkT0KvM2wCWrMQOLsGRdMn03uGD9zfST6Ic3KLFgu7aPrN5QQ mRrqnhtCWWV6fKwX53LKhA0xqk079CekUrGtMHin0X5m1gVX5f3IzzvrZnG74O5AtBOb DmmdsrbD/vsql1ij32369CKKG5K06f58hh/Gz1uhvbnNN8fHlJj+y/RiaCMUXszMpfpd zJbgIdmn2fsA6OZfja5RTv3jIuGTQnoeP4kpNy+m6oiQPEcP2wHavPyUETr+feXRvjwK id2dMit10/pk5clLoHZbVXGzkb29e4aAfaI8Q6KoqTQWmSsTPyMkp+Y6O7bSrbJZgHZS YV0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=uLXWHAGXau1JEokNmFMP4AR5ztQQuAP+Q+X5aK/THBc=; b=bjqHXaaBp1q4dAFwQ5jUPBRs6vW0/C/5Fs2QWispzOtjSvaKnVGjqTtQ8t7/FTUIqk KMDO4MARDkKs+RSzpJZEy9TxfRpDW4ROGAdBXiOTIJTytur89fe2Tq3t/s7GCI53y7R3 Pg6BaU6aS/j3Da1KgszEvBAUjDWcrGKeKHRnnKOGFi0ZrfqXWWvGJ+yee+CSehi1aaOQ UcrtQ+bh/tXrNa09pEfsnPdObRFCi77K09vczjfxUfjlYq78SqD2vzZuFLDnJ1NYJL6T +oEIQ14+/ukH4StRILgM9b4WremOVbU+Zj+gVy1c5JktH8maL2QedKUfl+OcKACs3r+g eSmA== X-Gm-Message-State: AMCzsaWanjMJyCmOPfxnwD4LUCTw+vgOefuGmmMeUDIOfi/rCt26bxg7 Y0ie+WT+jtyYvb7CqzcaknF2fw== X-Google-Smtp-Source: AOwi7QBujGShaukpzJdqTvV+ne6Ibb301fQ8KEGEtNX67HNTOgHeNpO0BqZOJHUmEBiTMWRg8Xm5Qw== X-Received: by 10.80.144.203 with SMTP id d11mr20168196eda.196.1508316884900; Wed, 18 Oct 2017 01:54:44 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q6sm7795435edk.55.2017.10.18.01.54.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Oct 2017 01:54:44 -0700 (PDT) Date: Wed, 18 Oct 2017 10:54:32 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Aaron Conole Cc: dev@dpdk.org Message-ID: <20171018085432.GC3596@bidouze.vm.6wind.com> References: <35d2cbe2bb9d8c03d0564256a85cce54b8331eee.1507804944.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 08:54:45 -0000 On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote: > Gaetan Rivet writes: > > > Parsing operations should not happen in performance critical sections. > > Headers should not propose implementations unless duly required. > > > > Signed-off-by: Gaetan Rivet > > --- > > Can these cleanups be done before the move in patch 3? Sure. I wanted to minimize the changes before moving the code. If I had rework to do on these patches, I wanted to avoid having to redo the move and verify the changes were properly propagated. But if it is necessary, these changes can happen before moving the whole lot. -- Gaëtan Rivet 6WIND