From: Ivan Malov <Ivan.Malov@oktetlabs.ru>
To: Lee Daly <lee.daly@intel.com>, thomas@monjalon.net
Cc: dev@dpdk.org, kubax.kozak@intel.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API
Date: Wed, 18 Oct 2017 14:10:19 +0300 [thread overview]
Message-ID: <20171018111019.GA5352@oktetlabs.ru> (raw)
On 10/12/2017 2:31 PM, Lee Daly wrote:
> From: Lee <lee.daly@intel.com>
>
> Fix xstats functions, rte_eth_xstats_get_names_by_id()
> and rte_eth_xstats_get_by_id(), in current implementation
> ethdev level reads all xstat values and filters out
> the ones requested by the application. This behavior doesn't
> benefit from PMD ops and doesn't provide the benefit the
> API was created in the first place for. APIs are also unnecessarily
> complicated. Both APIs have different returns for the same params.
>
> In this fix, instead of reading all the stats and finding the
> requested value, drivers can provide ops to get selected xstats.
> API no longer crashes with certain params,
>
> rte_eth_get_by_id returned seg fault with
> "ids = NULL && values != NULL && n<max"
> rte_eth_get_names_by_id returned seg fault with
> "ids = NULL && values != NULL && n=0"
> These now return max number of stats available, matching the other API.
>
> rte_eth_get_by_id returned seg fault with
> "ids != NULL && values = NULL && n<max"
> This now returns -22,(EINVAL).
>
> Standardized variable/parameter names between the 2 APIs.
>
> Overall code complexity reduced.
>
> Fixes: 79c913a42f0e ("ethdev: retrieve xstats by ID")
> Cc: kubax.kozak@intel.com
>
> Signed-off-by: Lee Daly <lee.daly@intel.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
I have a serious concern regarding the patch. There is a common scenario
of rte_eth_xstats_get_names_by_id() usage, and the patch breaks it.
Typically, the function is called with 'ids = NULL' and 'xstats_names = NULL'
in order to get the number of figures. Then the function is called one more
time with appropriate storage for 'xstats_names'. According to the patch,
on the former step get_xstats_count() is called to count the figures available.
The resulting number counts for PMD statistics + RTE_NB_STATS + some amount of
per-queue figures. However, on the latter step the following may take place:
> + if (dev->dev_ops->xstats_get_names_by_id != NULL)
> + return (*dev->dev_ops->xstats_get_names_by_id)(
> + dev, xstats_names, ids, size);
This obviously means that in the case when 'xstats_get_names_by_id' is present,
it will be called directly, and RTE statistics will not be filled in the storage
before the PMD figures. Accordingly, the value returned by the function in this
case will count for PMD figures only (i.e. will be less than the value obtained
on the first step). This is an obvious malfunction, and it would be desirable
to provide a fix for that. I hope for your understanding.
--
Best regards,
Ivan
next reply other threads:[~2017-10-18 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 11:10 Ivan Malov [this message]
2017-10-18 21:49 ` Ferruh Yigit
2017-10-19 11:06 ` Van Haaren, Harry
2017-10-19 15:03 ` Ivan Malov
2017-10-19 17:31 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2017-10-11 7:22 [dpdk-dev] [PATCH] " Lee Daly
2017-10-12 13:31 ` [dpdk-dev] [PATCH v2] " Lee Daly
2017-10-12 19:42 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018111019.GA5352@oktetlabs.ru \
--to=ivan.malov@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kubax.kozak@intel.com \
--cc=lee.daly@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).