From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0087.outbound.protection.outlook.com [104.47.41.87]) by dpdk.org (Postfix) with ESMTP id 4F8303790 for ; Wed, 18 Oct 2017 16:36:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VFoVJN8UIsdBP9OSK8rzZ5XbYr4HKV7r484AzBMJqc8=; b=DaaQXyEHvQtCFn0OuBWwrOvI1HcH8KOXFi5LOd1fvd2e1BY8k5Y07P2z061f2HCvoGc0sDfZgeMSHOARDb7zs5xgJA1+SOzkRLoY9F9ypeCyIJ3FmUDC2FT2pfb8w8ziabhHI/mAi6xVbyiDGURKU1l5097CqRNGbpTiPsgoeLA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.76.118.225) by SN2PR07MB2526.namprd07.prod.outlook.com (10.167.14.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Wed, 18 Oct 2017 14:36:52 +0000 Date: Wed, 18 Oct 2017 20:06:34 +0530 From: Jerin Jacob To: santosh Cc: Thomas Monjalon , John McNamara , dev@dpdk.org, olivier.matz@6wind.com, hemant.agrawal@nxp.com, ferruh.yigit@intel.com Message-ID: <20171018143632.GA31948@jerin> References: <20170831063719.19273-1-santosh.shukla@caviumnetworks.com> <2b50074a-f964-d1de-d3b9-0abcd9df68a8@caviumnetworks.com> <2831928.n80VB9rmku@xps> <80cd844a-511e-5b27-4bc0-ea796611cb28@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80cd844a-511e-5b27-4bc0-ea796611cb28@caviumnetworks.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [171.76.118.225] X-ClientProxiedBy: BMXPR01CA0044.INDPRD01.PROD.OUTLOOK.COM (10.174.214.30) To SN2PR07MB2526.namprd07.prod.outlook.com (10.167.14.154) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4828e97b-df37-4198-d9a1-08d51635ae3f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:SN2PR07MB2526; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 3:oPDrkzfzQzs9Fkru4mfzJeiqHrPyE4hrFd9wUF4qxrpocQK6Wx2wqlHtX/1IemNpxI+qYQUmZvNQ0dNUW0bSKzyxUYTVAtHjV+zdK1it7Q2lb0liTZZQJ/tM+7aP/J54GAhEI7C5u0qdTHS2rzSe31rK1m+XMF984NF0EZnPbRuZQdGXgRe2fDda3BOSAOSzfotfmMycB1qC9TjzOLw8ZVQ69CDBh3JGpPkabfM0BzdGA7IDP/ftPVfpNYlyH7d9; 25:sRWbwrEXMqnhb4L3Jr00CSz14pGkygAyTFkukobsE1JPgER/guPiYTYhYxGMqWUBP6KgvpzlQe/AXvifrNmCJEMzeNYbNLKzQtOXWB8/2d4NZk5q0Nm0Y8g4WbsP3J4nFoQikQOjuChs9cE9Qv6rpGh3pZFwgxntYqbYiw9Ob32iIOUJvlOLjyp0bCIc0Py5TRjchk6ANizMIXtM21wTT3GzX0Mx7pwJQTwjqE1oWUSeCCuAIS4aATnQs6tCQzuiieP+AkSYLpdZl1hZETBSMAN8CqSJBLIavFtDpC82eAu3x9E0JAel2CFOAwJN4OoccPA1q4ZkZpAlY2VTpYvR4A==; 31:98nH2C5vp/29Wza+f7+OxMYOH26ObWDHBLhPIovlyBcG1TZytxV5LUT+/Vo7xAVTigoQNsv/Czg1PTlBHHC3kmTzXsdnLLa2SyvkQE4px7fRxU/RCTApGPbygRxJ6N68oXTHl9VJ+GDFOZ67hew/3UmU/0ysZWe66ou7qGTthzk0gXYDXY6D7QYHo4Wd4BcuYQcl3AnwEijEQqzpElYcW6tjKzVuIWOrXrXT51Dfrxw= X-MS-TrafficTypeDiagnostic: SN2PR07MB2526: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 20:qQx2yzXYDVY4aEGFhdxGOrJIrQalKNymEvYSinDZyTp4AOngFdEAl/yqTr+Xm7LASLLwfgLVaSCzfP/VhVPccH4Gi2r9dWSmVeIfG/BK2SAJyqfiFssMTmuM9rrLJzNa1ILUXWLJQk+LWWKZo+gAuNI1wgxknlO4XnS7FjilSYlM13piSbQTs9xhZbb3koQF6HCzQm01lN+14woBkHgsQ92Y1H0A/+I2SILztaPQ62i1/nvsTNpkU4LKTqV7vocsLGnP+nFIho1fC/TSFjBLMth5SRBM2xz4n4nHrmjRa8mwUaErJJcBgLopbHK34pCgZwrFL1l5e4BygSLh2K5qxAhnGiDaY3u+cNTkBr/2n0WcSGVYfPV1vKgAdHxQlhJ9OEFohcnHweGYmqairnuijNFYMcHT3FDS38a56xTOi9rYfHLxZRlNelQYaufyP/3cWNUJT5VOv1c7+6o8uslgAVI83g5iGD3V7PDqH4kRrgkS0vStqKTl+KGoKAZUjmmjg5kUbuxvvEg8kmg8SC00wt1nxJg0IwydiR4awDcKTlJskLRJyK0FPlJYr9XHFRONtBnm+0f6uKTUZPN1K/5rlEEQsE17Ziu2ucwGoznJxQ0= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(100000703101)(100105400095)(6041248)(20161123558100)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN2PR07MB2526; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN2PR07MB2526; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 4:/d0XHzndTmi2S8B6ameTl0j30uHKiO2k7qGU6xxjGc6JNZc0F8U7zYkD8IYiJLGi524V6j1aDHAaxMTyJcrvNe6zY5GRzTYCsevLtzAs1QvY0kQirqsCrqrszpM+lRKl5dMcv06BJJdT9Eaj4xiuHaVZGQxxgTJzVq6tOjKaAEtTn1eT7m837B8UKD9yOa/6Lp5EjtwoINbqFsKjTnJP4XaUnXPtcIw608xyOnWf8egkcS3cWImXj/oHTGx1Bf3f44hL0Zlq+kpyxunMejMdRLFSMaSfT2/LrwlypsxU8ZZjdvbUPJl5bme9gTcoKy8LqSgJKOeTjypI/6TWyLS6zg== X-Forefront-PRVS: 0464DBBBC4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(189002)(199003)(377454003)(13464003)(24454002)(42882006)(33656002)(6636002)(16586007)(6666003)(58126008)(97736004)(2906002)(50466002)(189998001)(83506001)(6246003)(93886005)(66066001)(561944003)(25786009)(8936002)(54906003)(8676002)(305945005)(316002)(53376002)(4326008)(6862004)(76176999)(47776003)(6496005)(1076002)(16526018)(2950100002)(33716001)(53936002)(5660300001)(106356001)(966005)(9686003)(81156014)(6306002)(50986999)(81166006)(229853002)(55016002)(8656005)(7736002)(101416001)(68736007)(23726003)(478600001)(105586002)(3846002)(6116002)(54356999)(72206003)(8656005)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2526; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2526; 23:kv4ONgJq7beG1YYZXLWOvKxuDqbs5CCjYOSFjfsyH?= =?us-ascii?Q?MbkKovBBRVWTysHvjPNVQD2q7PLS+VcAG9rNTIvVOYcIQ7kitWF5829JkHw1?= =?us-ascii?Q?yxd2BJpoLoTZFDI6qw12tW4WLMq1Nfg86d6UYxm90m1aEpE3Lpb32/jGWrh5?= =?us-ascii?Q?elky8POfXKP/9c7YQ8CQJjv4BqTXFKtzodGrazGLggqTyVGndMS++3YZfkNR?= =?us-ascii?Q?XnKYDWVwof0D0qGdQ95yQbXGankzTeZaxb9EOCZzdvqqHHkr76hQsJbbcbVV?= =?us-ascii?Q?J2ggBcRei9//LG2JsN25RdTFDarg5W0hRh/UNyHO2EJH1X5Gbrrmg3EcAq53?= =?us-ascii?Q?MQGgi2WKbuhg8hGDTMoM6C4Bg28l5MP1xRvJFO/JmbvyRYGyMOOK5ntaxypk?= =?us-ascii?Q?kQfAPRv983zYRgppfDjH8SL0a8/9pgtKwgkJZoeEGY4uayUs87xk9sy9cMF8?= =?us-ascii?Q?rurFSi6ZRAkzgBh1iMvlIV4m2Te0czs+j3DTbSCcB7Z3b0aGFEa+3zCBFWa6?= =?us-ascii?Q?QUSZ988PETffYHaMPbrzsNKRZunBEiKhJJ22spNN022v5XBp5Rdvdv5yXUYp?= =?us-ascii?Q?IFwTf2ssXxuoe8zyCyN9vBFiu47XC6vahXmLCFfIwzTUvF3l1A/nePsC0nit?= =?us-ascii?Q?C8pBxSKFbWum2o+qvY378Vn6Vij1ZhV1qHt3KSAmknbzQAF7aV7KOeiD4OnS?= =?us-ascii?Q?viZmo/tdt5+COwod9iJAXOyCrz1a6JXj4qVTqJUUF9XuDRlOPWy73AH1cHMA?= =?us-ascii?Q?j8wLVgp4zDXYrO38GaQOvqmKL4pGcNMAuRinbHx+2L6q94fieXcFcaiGwtVZ?= =?us-ascii?Q?k/NreMNszyIBeRvmdj1yiiP0YnafwnI0N+p2S8VzPywEiE5nLinqLlV85OuS?= =?us-ascii?Q?iB0gBXJpyDTWB3+CpjioywFeT3Mor08Q8iBGXS6HfT+YxqE9nhs1mRqML9V7?= =?us-ascii?Q?NXBWApTQIM9kURFT1O4F5ONyN+1fQL92F3O7Z6viYSPb+HLvI5fgiiDrsvrM?= =?us-ascii?Q?X/ohxB8GdmGen0d0+gzmT/z1eXDyDFd4AL6AmwOLSv/v83+0d8slAizKDf66?= =?us-ascii?Q?e5Xy+JuP8N1b4ULklB8V9qFVOpctBgv7hbCiK1r/X9oLXmINe6k6hnYXEn+p?= =?us-ascii?Q?C3JrnEuaBODBhMCCw60xdWZlIL3YFWk6P+tSUggB/RVbhga1HFuvAES6ohu9?= =?us-ascii?Q?w4QSbZtsMpdGlyDO7ZDGlYoG2WKplR+aE+Q5W17Dcmyo+qCKKpN2kvGdk5cW?= =?us-ascii?Q?Kys2yQ1pmsnUhecJdMz6JsyuliUYiUHf+nxFuYSxbHpROVYykkF5qEbmFIH4?= =?us-ascii?Q?WMtyTg8hpUe2EiUXPShDTbUaja9XFW+yXfMiarKKXceC/ur9QgeKArPJYuDa?= =?us-ascii?Q?Qqo22B0CRczXrO6w7po/qU8Ym7U1CevmV/K/xW22wsb5QQGEiK6kVXjWrAK4?= =?us-ascii?Q?NDqm3v1Bw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 6:zN5XMM7DAkRP12Xuch+Yn8Zcw8uMLYW7OCzepYjxHIg9GHN180mltZ82Z8D4l6G983TIHQv1EAXsWGU/wLygNNxASm1V2oTaqi7BHpdAotoDXf6uzQbfAfnoHR2SimRRD2V4cK/drCK2vht4WPr607UHNOaLZt8WNSDNf83zhypjwUFEr62LHT40f0n8HC8lQiGXSk5khATbH1hRJJUY+y9+D5zvzoVQDxKEWhm2kr6SqjX8ohkDyX19YNdE1j5aNTFIHMgGZoCooNUBfsDXqUMRpmLgD/e1rTWvod+xPTSlG1kZ9V2ZvJUuV4DxIAKB5s99ZPHcRssF3KtQZc/UkA==; 5:lwHbU+sJ2/KTRhf8Hr/8SqN3rFurngfiFnc3fFvgRE84xEtTak5rfxzZ9ZssbdoVqafSu9+RMcFbbSuRBgdY0+sUfJSVIhFI3YJggwe0oSdu+Cqfl8F2ZgpxckMs8+j14vcXg9D7p52UJX4UXNSsxjjUa8jt42JKVhQ3KBTLV7E=; 24:d13nAbwH2P1C6pD1Q9FLTJm64XGQG8ucFwmt0lXh3ymusWYvC5XjFl+mX4gcsCJWneEyJp6UlyMUjrTeXKKjnvzdMu4DXgaLTLaDwb84dkA=; 7:3kERA6tsYf9xUkIQ8osHzB6Orm+jb/Vu69vnytVB3BWoHvMrJOwEAd1VK4omlRmgIJn0NFySw25WYCh2YOnqmtvOy4YDJMI+niL7tM4HVsOPKCxt/U+wCm8Ei9HmioZC+fp8H0/GNcGlvfBp1gSeMgEeDr+JC9L2Ejv9dAXBPDAkoYntDy9zJf0ArRwygAEaNSeBDtD5/1Sbd4pGZGSbHRW+6yw62q2Zp//2RcWa090= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2017 14:36:52.7165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2526 Subject: Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 14:36:57 -0000 -----Original Message----- > Date: Wed, 18 Oct 2017 19:32:44 +0530 > From: santosh > To: Thomas Monjalon , John McNamara > > Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, > hemant.agrawal@nxp.com, ferruh.yigit@intel.com > Subject: Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx > mempool device > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 > Thunderbird/45.5.1 > > > On Wednesday 18 October 2017 07:15 PM, Thomas Monjalon wrote: > > 18/10/2017 14:17, santosh: > >> Hi Thomas, > >> > >> > >> On Monday 09 October 2017 02:49 PM, santosh wrote: > >>> On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: > >>>> 09/10/2017 07:46, santosh: > >>>>> On Monday 09 October 2017 10:31 AM, santosh wrote: > >>>>>> Hi Thomas, > >>>>>> > >>>>>> > >>>>>> On Sunday 08 October 2017 10:13 PM, Thomas Monjalon wrote: > >>>>>>> 08/10/2017 14:40, Santosh Shukla: > >>>>>>>> This commit adds a section to the docs listing the mempool > >>>>>>>> device PMDs available. > >>>>>>> It is confusing to add a mempool guide, given that we already have > >>>>>>> a mempool section in the programmer's guide: > >>>>>>> http://dpdk.org/doc/guides/prog_guide/mempool_lib.html > >>>>>>> > >>>>>>> And we will probably need also some doc for bus drivers. > >>>>>>> > >>>>>>> I think it would be more interesting to create a platform guide > >>>>>>> where you can describe the bus and the mempool. > >>>>>>> OK for doc/guides/platform/octeontx.rst ? > >>>>>> No Strong opinion, > >>>>>> > >>>>>> But IMO, purpose of introducing mempool PMD was inspired from > >>>>>> eventdev, Which I find pretty organized. > >>>>>> > >>>>>> Yes, we have mempool_lib guide but that is more about common mempool > >>>>>> layer details like api, structure layout etc.. I wanted > >>>>>> to add guide which tells about mempool PMD's and their capability > >>>>>> if any, thats why included octeontx as strarter and was thinking > >>>>>> that other external-mempool PMDs like dpaa/dpaa2 , sw ring pmd may come > >>>>>> later. > >>>> Yes sure it is interesting. > >>>> The question is to know if mempool drivers make sense in their own guide > >>>> or if it's better to group them with all related platform specifics. > >>> I vote for keeping them just like Eventdev/cryptodev, > >>> has vendor specific PMD's under one roof.. (has both s/w and hw). > >> To be clear and move on to v3 for this patch: > >> * Your proposition to mention about mempool block in dir struct like > >> doc/guides/platform/octeontx.rst. > >> And right now we have more than one reference for octeontx.rst in dpdk > >> example: > >> ./doc/guides/nics/octeontx.rst --> NIC > >> ./doc/guides/eventdevs/octeontx.rst --> eventdev device > >> > >> Keeping above order in mind: My current proposal was to introduce doc like eventdev for mempool block. > >> > >> So now, I am in two mind, Whether I opt your path If so then that should I remove all octeontx.rst reference from dpdk? > > I think we must keep octeontx.rst in nics and eventdevs. > > > > My proposal was to have a platform guide to give more explanations > > about the common hardware and bus design. > > That way, event device also a common hw block.. just like mempool block is > for octeontx platform. Also PCI bus is octeontx bus.. we don;t have platform > specific bus like dpaa has, so bus stuff not applicable to octeontx doc(imo). > > > Some infos for tuning Intel platforms are in the quick start guide, > > and could be moved later in such a platform guide. > > > > With this suggestion, we can include mempool drivers in the > > platform guide as mempool is really specific to the platform. > > > > I thought you agreed on it when talking on IRC. > > yes, we did discussed on IRC. But I'm still unsure about scope of that guide > from octeontx perspective: That new platform entry has info about only one block > which is mempool and for other common block or specific blocks : > user has to look around at different directories.. > > >> and bundle them under one roof OR go by my current proposal. > >> > >> Who'll take a call on that? > > If you strongly feel that mempool driver is better outside, > > I don't have strong opinion on doc.. I'm just asking for more opinions here.. Combining both proposal. How about, 1) Create ./doc/guides/mempool/octeontx.rst to capture octeontx mempool specific information.(Which is inline with driver/ hierarchy). 2) Create a platform specific document(say doc/guides/platform/octeontx.rst) - We can use this file to capture information about the common content between the three separate documents(doc/guides/nics/octeontx.rst, ./doc/guides/eventdevs/octeontx.rst and ./doc/guides/mempool/octeontx.rst) and give reference to common file instead of duplicating the information in driver documentation. Thomas, John, Thoughts? > as I'm not fully convinced with your proposition. > > > you can make it outside in a mempool guide. > > John do you have an opinion? > > >