* [dpdk-dev] [PATCH] net/softnic: fix integer overflow
@ 2017-10-19 9:39 Jasvinder Singh
2017-10-23 18:54 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Jasvinder Singh @ 2017-10-19 9:39 UTC (permalink / raw)
To: dev
Fixed integer overflow by casting hard_rate to uint64_t type.
CID 195020 (#1 of 1): Unintentional integer overflow
(OVERFLOW_BEFORE_WIDEN)
Fixes: 8316b9816b79 ("net/softnic: support traffic management")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
drivers/net/softnic/rte_eth_softnic_tm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/softnic/rte_eth_softnic_tm.c b/drivers/net/softnic/rte_eth_softnic_tm.c
index 682cc4d..dbb2514 100644
--- a/drivers/net/softnic/rte_eth_softnic_tm.c
+++ b/drivers/net/softnic/rte_eth_softnic_tm.c
@@ -47,7 +47,7 @@
int
tm_params_check(struct pmd_params *params, uint32_t hard_rate)
{
- uint64_t hard_rate_bytes_per_sec = hard_rate * BYTES_IN_MBPS;
+ uint64_t hard_rate_bytes_per_sec = (uint64_t)hard_rate * BYTES_IN_MBPS;
uint32_t i;
/* rate */
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/softnic: fix integer overflow
2017-10-19 9:39 [dpdk-dev] [PATCH] net/softnic: fix integer overflow Jasvinder Singh
@ 2017-10-23 18:54 ` Ferruh Yigit
2017-10-23 19:07 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-23 18:54 UTC (permalink / raw)
To: Jasvinder Singh, dev
On 10/19/2017 2:39 AM, Jasvinder Singh wrote:
> Fixed integer overflow by casting hard_rate to uint64_t type.
Coverity Issue: 195020
> Fixes: 8316b9816b79 ("net/softnic: support traffic management")
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/softnic: fix integer overflow
2017-10-23 18:54 ` Ferruh Yigit
@ 2017-10-23 19:07 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-23 19:07 UTC (permalink / raw)
To: Jasvinder Singh, dev
On 10/23/2017 11:54 AM, Ferruh Yigit wrote:
> On 10/19/2017 2:39 AM, Jasvinder Singh wrote:
>> Fixed integer overflow by casting hard_rate to uint64_t type.
>
> Coverity Issue: 195020
>> Fixes: 8316b9816b79 ("net/softnic: support traffic management")
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-23 19:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-19 9:39 [dpdk-dev] [PATCH] net/softnic: fix integer overflow Jasvinder Singh
2017-10-23 18:54 ` Ferruh Yigit
2017-10-23 19:07 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).