From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id BDFF61B27D for ; Thu, 19 Oct 2017 18:46:03 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 19 Oct 2017 09:46:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,402,1503385200"; d="scan'208";a="1026993906" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.32]) by orsmga003.jf.intel.com with SMTP; 19 Oct 2017 09:46:00 -0700 Received: by (sSMTP sendmail emulation); Thu, 19 Oct 2017 17:45:59 +0100 Date: Thu, 19 Oct 2017 17:45:59 +0100 From: Bruce Richardson To: dev@dpdk.org Message-ID: <20171019164559.GA20056@bricha3-MOBL3.ger.corp.intel.com> References: <20171019163629.28618-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171019163629.28618-1-bruce.richardson@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 16:46:04 -0000 On Thu, Oct 19, 2017 at 05:36:24PM +0100, Bruce Richardson wrote: > Both Linux and BSD EALs should provide exactly the same set of functions > to the user, even if in some cases the function is a stub returning > ENOTSUP. Because of this we should only need a single version.map file for > all of EAL - not one each for Linux and FreeBSD. > > Unfortunately, there was some inconsistencies in the two EALs, specifically > 4 functions were missing from the BSD interrupts files. As part of adding > the needed stubs, I also discovered that there was nothing terribly > Linux-specific about the Linux-specific rte_interrupts.h file, which > appeared to contain a superset of the BSD contents. Therefore, this file > could be made common also. > > The net result is that there are now zero BSD-specific EAL headers, and > only a single Linux one for KNI. The version.map file is now moved to a > common location also, just inside rte_eal directory. > > [While an argument could be made to put it in common, this location works > best for integration with the existing meson build-sysetm work. It also > allows the same version file to be used for non-posix-like environments > which may not use the "common" folder as much] > > > Bruce Richardson (5): > eal/bsdapp: align interrupt include file with Linux version > eal/bsdapp: fix missing interrupt stub functions > eal: merge bsdapp and linuxapp interrupt headers > eal: mark internal interrupts file as such to doxygen > eal: use a single version map file > Compilation tested for both static and shared builds on FreeBSD 11.0 and Fedora 26. /Bruce