DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Requirement of minimum Rx burst size for PMDs
Date: Fri, 20 Oct 2017 09:13:49 +0100	[thread overview]
Message-ID: <20171020081349.GA15108@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <BD4E5B5E-6CDE-4180-8040-58027CF32897@mellanox.com>

On Fri, Oct 20, 2017 at 01:18:18AM +0000, Yongseok Koh wrote:
> Hi,
> 
> In some rx_burst functions, especially for vectorized ones (e.g. i40e_rxtx_vec*
> or mlx5_rxtx_vec*), there's actually a requirement of min burst size.
> 
> As it manipulates 4 packets simultaneously in a loop, if nb_pkts of
> rte_eth_rx_burst() is less than 4, it just returns without sending a packet.
> 
> One way to handle it could be falling back to regular rx_burst in such cases but
> the burst size isn't a fixed/static parameter but applications can dynamically
> change it when it polls a device. So, it might not be a good option.
> 
> Therefore, how about adding min_rx/tx_burst_sz in struct rte_eth_dev_info and
> have PMDs fill it in on dev_ops->dev_infos_get() so as to make apps comply with
> it.
> 
> Because the max size of a burst can be handled well by PMD, it may not be
> necessary.
> 
> Thoughts?
>
For a short term fix, having the min burst size in the device info is a
good enough fix, I think. Medium to long term, we need to remove this
limitation in the vector drivers.

/Bruce

  reply	other threads:[~2017-10-20  8:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20  1:18 Yongseok Koh
2017-10-20  8:13 ` Bruce Richardson [this message]
2017-10-20 10:07 ` Andrew Rybchenko
2017-10-20 11:58   ` Bruce Richardson
2017-10-20 12:23     ` Andrew Rybchenko
2017-10-20 16:59       ` Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171020081349.GA15108@bricha3-MOBL3.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).