From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Pavan.Bhagavatula@cavium.com> Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0076.outbound.protection.outlook.com [104.47.37.76]) by dpdk.org (Postfix) with ESMTP id 7553C1B646 for <dev@dpdk.org>; Mon, 23 Oct 2017 16:55:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JVHZQuTi8mawClTpBW9s4HpFY3kB1ya6yQymSNM+6qM=; b=WVUpyME/FXnNkkfq/45rxIiBbtilvx+CdNG4nZzrGnSpBmC4WuQB6GlhoI1lFd1jv77LwRWk3nQyg/1iWenXcv7juTtAUKNaJevohOkToSS1zpp05L4l1lUF595VrXZKQ+r4/dYJZmxzogg8kB0rK9THd3Q76jSjA17JIlUerLk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from PBHAGAVATULA-LT (103.16.71.47) by DM5PR07MB3467.namprd07.prod.outlook.com (10.164.153.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 23 Oct 2017 14:55:04 +0000 Date: Mon, 23 Oct 2017 20:24:44 +0530 From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com> To: "Van Haaren, Harry" <harry.van.haaren@intel.com> Cc: dev@dpdk.org Message-ID: <20171023145443.GA4502@PBHAGAVATULA-LT> References: <1507814147-8223-1-git-send-email-pbhagavatula@caviumnetworks.com> <E923DB57A917B54B9182A2E928D00FA650FC91E3@IRSMSX102.ger.corp.intel.com> <20171020103032.GA7404@PBHAGAVATULA-LT> <E923DB57A917B54B9182A2E928D00FA650FC9605@IRSMSX102.ger.corp.intel.com> <20171020190927.GA18722@PBHAGAVATULA-LT> <E923DB57A917B54B9182A2E928D00FA650FC9F22@IRSMSX102.ger.corp.intel.com> <20171023084138.GA27709@PBHAGAVATULA-LT> <E923DB57A917B54B9182A2E928D00FA650FCA316@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FCA316@IRSMSX102.ger.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [103.16.71.47] X-ClientProxiedBy: DB6P189CA0011.EURP189.PROD.OUTLOOK.COM (10.175.239.152) To DM5PR07MB3467.namprd07.prod.outlook.com (10.164.153.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 15c5d686-e7fc-471e-5dde-08d51a260bf6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:DM5PR07MB3467; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 3:6RzBxXejbnZMUbKy9WHPw//MXETb9y6tqGIeeBj292zfY1oQtSrQnAlmFq1XY5cs3RdHC4cNqQVkNVuGTW2tQlPNx5re2W2u0BsMgWWcjGu3dhYX1uz1tshjPlSYuBx5hNGOzx0d6Itb7N18S7G1AMzWE80Jh6hSS0UR+7Th5FznWzqkOfhGoVwcGT9AezEWbAj6XMvsAiVDq8huB050TXJ3xa9qXVwgQmEqiBh6VBdWnBw5yQNdepmuhwrNs64g; 25:xAa5E7/Bx0Y3ictBRLXwd5OC/8gDMTMVuDSCKPuzIEXnmc1/RMEGorB2oeO7Yt+g6DJmVcwkXeNd8wfE5AjOMm0qJbW+UAwIGhmsNskr5efDGz2JBzzXMvhe6SNMTw1gXX5+Nau5i53B2LrFmSRRrOMYmrZF2AlV5If6XG8lpb39gOmcqHMCSHYvC7lu4HH68ZlmwnvT7BWHoVNCSDp2Exhc5LGkUjKp78Bj2cUDdEsI1557PvYm76gDIViQLNQanN+mv7rYWaJE2vEk5/ywBsg6PT3XR8vIbjqERO94sZqBsmzWLdhSWkIPqPYWh+3/TSmOeNc1xxF7yV2w7iAFjA==; 31:s7Zut9neM4QxwLZdXWIDERaB9JCjMy5Rpy2UOXUmD5ahDBPSax5KO4RwHEfdnK49NwTHyTdDU9pZWsD7PNdCAcpuyR+dPKiqrs7/v5/uLIY2whwZdT5URWv7PyAQfwhIiXmW8V69TuFSxzLg5/SOJXcVY1A/rAMKpOy4MRuInRRJrdS2oTOGp5VDjrKffH3fY+CVSMrme7CgfIhe+neGBGvf3JA6I+OUIJMhVRRq6fg= X-MS-TrafficTypeDiagnostic: DM5PR07MB3467: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 20:g7pHHJXkFXz+h+L1ZM1FaZs2xGTPWbAuvHBShRyPN0vIgz+wu8jhy6p1TpjqUMB0UXH82AYujFi1VtqaSUm+CGfuR5D7HX8VMigwdxd/my1hI+fMYzQAMraY8jG4vR4hfKBFxCDoakdl1uM+Dygbu5/3TbtrcqxtjHdeAAPJ8hJpmQLeyCYtUbERMie9iFi4Z5ZWoU7KdFOvFpMkW76em8MebO/8I+K3KMVnxzxHWvEFojS9zVn4vkLB5nJO5xwdvZAx0WL2IaN4+mSzX6z3Ylr5Vd+MICBJUjWGjHScwJc2au3Jp3sQqMWmTP8pxP5/O3eE7jcQypQddGA4niuvOPDRhdyBQqWUJIhFck0jSgyxzYuzPulgGoegd/YOlgpiXFKQyEAyQPsvE7SUASMfY+WXlk4XhG+nMvYNWz/gZW1naC+hy8UcsSgzk0urFlBFnQ8o1tZRkJ7lchsXEBGF+8edoztyWgjMUtTWARF1oH6gVtMe1VovRxrP/f1Y+RDzRZQVjEFIVGmTsbVTfr1DryahrpDGTGWutm3ksFKilZ6zz7bfpPbqIdGlEVcDTJ9Z4852C/+hBoEvkUBnqv+U587trecgI5w0CwG5Jco6FbM= X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(228905959029699); X-Microsoft-Antispam-PRVS: <DM5PR07MB3467445DA0882749F93E791280460@DM5PR07MB3467.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(10201501046)(100000703101)(100105400095)(3231020)(3002001)(6041248)(20161123555025)(20161123564025)(20161123558100)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3467; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3467; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 4:GU3YOAoLFZ+XYNx3a6A23Qg0WWJmepA+d5LHY9bu5kzfhB0e/UATYYAQoMGuY5gIzWITSWZdejxzxymN6IIXf8lSwiUL/O4/6dgO8rt5+wgcQySMyC+oxW8SWXpBkr4XyvwMsQd1QpD+V09CMo8kvh31lt94+1Q2xQQFqY1wpdnOreaN13yC/p5F22Jq5ked0xa4Rap0bS5hiTZmEwFer0Rp8VKyCLnOBFFpNtWNM9zTs8HJOKsQ7D9E6R7lyezlySJmfifEkyVNdqH0WLSnl+KcRhJGYggZjq++qzSD9hseyodb3wStkrSGAhZwLiSkUPi323gMdJNAGIGtbJbW0g== X-Forefront-PRVS: 046985391D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(51914003)(199003)(24454002)(189002)(229853002)(72206003)(83506002)(7736002)(305945005)(2906002)(478600001)(33716001)(54356999)(76176999)(68736007)(16586007)(6666003)(50986999)(8936002)(33656002)(316002)(53546010)(50466002)(6496005)(101416001)(4326008)(93886005)(6246003)(58126008)(25786009)(53936002)(42882006)(9686003)(3846002)(6116002)(97736004)(23726003)(105586002)(1076002)(6916009)(2950100002)(8676002)(106356001)(55016002)(66066001)(5660300001)(189998001)(81166006)(81156014)(47776003)(16526018)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3467; H:PBHAGAVATULA-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3467; 23:rgqEJuZHEC4E4hszm5BJehw1HA/bAJAcywtjmNID7?= =?us-ascii?Q?beF9hD09zuAETLQZ/whP0f8mVBQP1Yk1aLFaOfpXAge/HgXytb6OAAI+Rb1y?= =?us-ascii?Q?NQBaXOEvHP5NLz9MCknwqbAku3LhcTjzq3aUHQpfOZt4lZk6ntEmLurUlEET?= =?us-ascii?Q?31GlTSPFSz5kxnplp9mxkyBF34ToSy+wN0ZYUTF7XdrHdpQBJf8Dp8El+WOC?= =?us-ascii?Q?SashfhChUOpqcSyoXs/8oO26vk6YDiZyBHGa3psb+tiXYw5Wyurpj9EXfNTl?= =?us-ascii?Q?smbLO6gU2UPOR+Mc1vOHOqjI02laLvhJaDr8DM5ldgYciMJLluALNBcJtmOx?= =?us-ascii?Q?eevPUHpDAzTfUE9Pp9s77dfxIJb+C3qLLCEMkG76kPx72/I5GYRHpwsCDHCb?= =?us-ascii?Q?tokme9tNTWrGi6nTXGblZFRxZsV2UHvksHKgKY3hYwuvozYB6CyPk/h0SNY8?= =?us-ascii?Q?VYNBrEF/w02h00UI+zVsprIsQXbfGyLtyFozw+e/qBZBuZoUgEv5SvLhDyAB?= =?us-ascii?Q?+UaiJzRsA6zOCdeSqC2wSzGKbELeY7T3u/WVOLnEDWAAD+nOHDs1sQx1hUKS?= =?us-ascii?Q?4on02nWrlPr67N5NgsE10u9PsQKUAtGarHQw2wpSZRKKfuCIJXcUjuy22/6w?= =?us-ascii?Q?uc6wMKW4819IGzIln/cnwOuIxHMjEuz82VGzyNWmE71GR132VtZ5hU4tafXl?= =?us-ascii?Q?zlvharoFHzR88W0NF0+kQU5D+oGUaHnAX5jDxSjZIUoFZjQ0S8hsc8JMcuYY?= =?us-ascii?Q?+mxs8iMRbWDX31wDvT4JF18m+YrtMicHPg0YNcA8PARuEXmd6SYxBFVZtkxh?= =?us-ascii?Q?sBArHtRS6tXSvgWFKXLIY3Fj54l1ZDlfbKmIl2QkBbk1zn0je3HhuJVVDSBQ?= =?us-ascii?Q?qswqrhz1KsHhioKr/HTf8tXehs9H4qRWsBWAJPXcIzPD1v1YspEeBTCOFqUw?= =?us-ascii?Q?QBxmrFRGFdmwa84IjE6LSxM585z2SzrxyZVkFnOVTh+52YUrF1Jrv7NSsvBu?= =?us-ascii?Q?8PGo8W2CUYUedPDOxqbzc94jgunrgLkguXMyHvNHP9I7gWbUNh6Uo+iuD6VC?= =?us-ascii?Q?8uM1G61pY17TOlPg8KPwto1MpHcz2qLBPvMU+vNxoqq4yncCKJO7jB7JtVJT?= =?us-ascii?Q?KE5Br1oYveImY0VpcIe3ObTeWRqr+PBXq2YUip1LZioFuyCwKTi8J+zuMajm?= =?us-ascii?Q?gr+289AurvuCT2ELZtpSjfbGSsWeUOOXjTShuNo2MIJxVrqTUrAXBZ76zt/6?= =?us-ascii?Q?86GHAzgDrBQzMcfo2CIdhddjyqDq+5ZZo/Y+xMjFHlfkPqouMeFQwm6Wsg/e?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 6:n0QRUFvj+7NuUvL8UH99V3Ipzxpfxzl8hky4Jwrp27hKSImOei6EsYJtWBt+Y9Q8UvFeOxpm2B44XOvzEenKMUQ0Ub/sbQ/0MGDVNIdS8TZjHWeFDP2F/cmvipm2jnolQE0XZQClUjUvzB13pu/hf3qTteRWODgYkDfexBJrjj0uY/0/kwc/w99olZjLECgjYjtGPvOL7J4FDNq+5H36aSffA0oPKCgP9tML6NsY3ya1aOdj7WyOlqF3C0YOJddUTlctxpR0WkI4KDhADFmPl6llVjbtusunEflhJnzxHwrRfOuZdgP14JYH3ixrNasz2GUz5fsdcWWaGV1KuD/PCw==; 5:OJADXXzjhAesqC+gevfti9CY/yhAK5jk/sVKxrgeNL7Hc48TiDGceFJ4VvB4RlAxdast4kNij4fS+mz6N5OY97VKlHIGSSn4xAayjH9TC6wSAnMOE1yDvBpIwrG0y1P62QXBXite07YxCRFhAgVxkg==; 24:G2JVeyCb5ZMg6Ing9K/aDbbz6SvKBuRlG6EHu8jIqbCv9qWxb/8DZnno3b31gpzOdsYOkDv3DAent84Gq/4+qnm6nQ3FgRFkuUn8jffpMnM=; 7:2ahYU9Dv7MV41pjzeTs+T3N7Arai97S6giPIX+kv8cBVMJTEoeIJD3rtQ+ObgUAXImvThIFTbZEzgWGBb9Oud3U6d1IcXu8pQXpRpdLs9zTx/V1xgPOjSfBEKzjlzzRquZRSwRSiCdpD2f4dOLtUUbgsYLl3ISHK2HYia8TCffQ8pkBpsfudnQ7tvdwRvYtT6l2Zmiome62zPiXp205QLYWE94ve6aCpjURA/VZsSFc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2017 14:55:04.0349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3467 Subject: Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event queue config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 23 Oct 2017 14:55:09 -0000 On Mon, Oct 23, 2017 at 02:45:32PM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Monday, October 23, 2017 9:42 AM > > To: Van Haaren, Harry <harry.van.haaren@intel.com>; > > jerin.jacob@caviumnetworks.com > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event > > queue config > > > > On Mon, Oct 23, 2017 at 08:04:26AM +0000, Van Haaren, Harry wrote: > > > > From: Pavan Nikhilesh Bhagavatula > > [mailto:pbhagavatula@caviumnetworks.com] > > > > Sent: Friday, October 20, 2017 8:09 PM > > > > To: Van Haaren, Harry <harry.van.haaren@intel.com> > > > > Cc: dev@dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event > > > > queue config > > > > > > > > On Fri, Oct 20, 2017 at 04:38:57PM +0000, Van Haaren, Harry wrote: > > > > > > <big snip> > > > > > > > > Sure, I see two sane-ish options: > > > > > > > > > > 1) Return an error code from get_attr(), which actually means "ALL > > TYPES". > > > > Feels a bit weird, because an error value is really a valid return. > > > > > > > > > > 2) Return UINT_MAX (aka, -1) as the scheduling value. Applications > > that > > > > use/care about the scheduling type must check, others can ignore it. > > > > > > > > > > I'm not sure which of these is the better/less-bad solution. Opinions? > > -H > > > > > > > > > > > > > I think 1st option would be good, we could use ENOTUNIQ to represent > > that > > > > the > > > > queue type is "ALL TYPE". > > > > > > > > Thoughts? > > > > > > > > > OK with me! > > > > > Hey Harry/Jerin, > > > > Sadly ENOTUNIQ is not supported on freebsd so, would returning EOPNOTSUPP > > make > > sense as it is closest error message that has similar meaning. > > I found ENOATTR in freebsd but that's not supported on linux. > > > EOVERFLOW seems to be supported on both, and suggests that the ALL_TYPES return would "overflow", aka is too big, aka, too many types to return? > > Documenting the return is IMO more important that exactly what the value is - given there's no logical errno to use, lets use this and document it clearly so when somebody looks at the docs, they'll gain the correct undersanding? > Agreed will spin out a v2. Thanks for the inputs Harry. Pavan. > -H >