From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0072.outbound.protection.outlook.com [104.47.36.72]) by dpdk.org (Postfix) with ESMTP id 7C9D31B676; Mon, 23 Oct 2017 21:03:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+nM6wrhIJcMu4yz8Dt9fX8l18WiWdH7iizdygOj5BgY=; b=DZx1+JvsnsbwMxnzvXC8XfJHN0RavyO93cS+lEKIDswqPPmdrmdxxiWsWm1x4PlMiga12BtuU3SpOw5QrMnyA7ZZ33OQJet9COcx3vkycxyJyJgoAo+JF4wPS9gDLZrL7uirUmAfJ6Q6OkoKm5vejBwyuOfI18UCCz7QJcSiPTs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Shijith.Thotton@cavium.com; Received: from localhost.localdomain (14.140.2.178) by CY4PR07MB3062.namprd07.prod.outlook.com (10.172.116.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 23 Oct 2017 19:03:53 +0000 Date: Tue, 24 Oct 2017 00:33:47 +0530 From: Shijith Thotton To: Ferruh Yigit Cc: Jingjing Wu , Gregory Etelson , Harish Patil , Thomas Monjalon , dev@dpdk.org, stable@dpdk.org, Jianfeng Tan , George Prekas , Sergio Gonzalez Monroy Message-ID: <20171023190346.GA20733@localhost.localdomain> References: <20171020165511.47899-1-ferruh.yigit@intel.com> <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> <20171023122807.GA17153@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: CY4PR1601CA0015.namprd16.prod.outlook.com (10.171.251.28) To CY4PR07MB3062.namprd07.prod.outlook.com (10.172.116.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ab837da1-79fc-4124-86f4-08d51a48cfca X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:CY4PR07MB3062; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3062; 3:RTo/zaWpxIvzvB/dtwEI5kDR4X8na0laPzcPK+9VWnBAyacwCAqljGTfnGNzwf6qAK1nufvfjkAYE/Gfmt6iqINXvdp0WZ9BjYbwa23743nJSLq1q1t14XL2fxNnsXX4LdrBek2a6OWrY0BcCQ+gTAh0MLRP4H2pwIQbFPA7Zf5F0vtixqfJcrZSFbdk7quNWWWsl6cx5slnWr6OkwovuW8zi8vWvOMCGPNAdVcqd79s6XdNLn2AqcVZAQkv6XUs; 25:BUKC4NBGWa/V6oMnJuHfVHPbhuPbmts8aLvRFO1N0YFLpwf/oR8vvAYN6+6St67+7XNzxQb9OJzgbbxcB1rnJVQoGnQUAfdq4J7M2Ku7/MHKYl+msWY2vbNo4CgL+sAOd1urJtLkZzklyYgY6RHOBjCT6NOkxj5LR38/TmL3PSeNTzGiAAUJQ+HPXK1r6RiJvqa5s5bi4TOBTMsaU8yHLX8ojjjwM5ZAJRRBeaFTcS3CzCgBEzeF60w6M//nGF52fYNYBt/JcXyASGKq/ZaCYC5eOY2699L93MtuA63twyVJudB8VIYRdfbZCYjvTS47SATga34H+pqOIBKzbZg/7A==; 31:1xUGXVdw+tyFp4/9wSm57j9QWvtdKA+VLI15yiI0cv9fiSFMEjRoWCgueKjpew9XU5+O8oc6KOdn4bqFgGORd+Ji3r8G4Vdn5oO2qpziqg9763VMF3mQi0zmAgUO/vhMJyomZnqHjdNDoX3BwchK3yv+5HJznuWqQ/fGRDruEmCHyAEUKHU7Umggfvu27mFOCbdiT7wjyexkWqE41pjnC/Lg9U2LDCZoafDPzK0aLpk= X-MS-TrafficTypeDiagnostic: CY4PR07MB3062: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3062; 20:xUFhPcCObZeFbXCqfoFpfth8zVvEGMVOYGyyIHoRpDLFDLCJc/oV1VT5HYcFH3X9kehd91M5b44itMrnkI98joaTyaK4A4N/SNzBivMu6oZkp+EpTnPo00xmZ5YDkqwG8C0Nvt/8GnCa1QcIwOWOU7uNDVgRx+B0iazfZYJBFqM+rrO7irkVhPaVOC8RUxp+mkSN47Xi4g/mkX8yn1s2sIV+xCrpGDNRrqon8R+Syvsyy7asL8X4tuko+xBXMEGuPogkl5PtL2WIN8DXUyGMvM43SRqqy+gWQ1VAhdxt2dND9a4b3Al1gSmMkF2ylz3xO9XFYdtjTMOH+OTBWTtqNT9/vxYRIKWCi8EWV4pDwt8vGxBwsX9woEi4E5mKgYeT3x6IsBrStbgxP6AOKSznwjvzDtT50bghUuiveRWOiX770WQ3sBScTaNa9Wa/W6R7JO+37bK8rsxhAKWKJQBNLu/aJEsABpR3sc3Jhy0UAS9qcROdBwY+6UFWvN/yieZfIznEpFxTbv1RZ1XGnYU4z48Zb71wcng62c3zrYMLrGGSpgxlYmXYKHVjPwasBqcmXIacxKDT2SkCR6YMJVF5uLHOST54Y/QQmCoevYITYdk=; 4:hn7YCOiWsdCkQtIOcPHOOrp4DraVIHtTIOh2gOIZca5Cu32DBgei9aDXOb2geLInUVsXNOTP/bm+/X6tVkw7jJk9Kr8RJkh3apy3O6DryK58hAjuIB6BCAKudnvpUFDSHLh2mWuBJKGbtX9++mBlwnOuZWSgUdwDuljmvTCaU/owbwM7+dCwB3lff8yixjrS+YJrl+wTnWaraZ37d2IiLj+RLSg0qaqTbsN58QT6mVZGoyBp9yD5vXbpaU0dC4bgSeZNir+LaZ/uIModqq4vzKH9W23LRVZPv9z1E+JzdHE= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3231020)(100000703101)(100105400095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3062; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3062; X-Forefront-PRVS: 046985391D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(376002)(346002)(24454002)(199003)(189002)(6916009)(6666003)(54906003)(2950100002)(42882006)(72206003)(478600001)(4326008)(53546010)(2906002)(6246003)(16586007)(105586002)(53936002)(97736004)(16526018)(58126008)(83506002)(6506006)(316002)(106356001)(9686003)(68736007)(55016002)(305945005)(33656002)(7736002)(54356999)(76176999)(50986999)(47776003)(101416001)(66066001)(8936002)(61506002)(25786009)(50466002)(5660300001)(93886005)(81156014)(229853002)(189998001)(23726003)(5009440100003)(3846002)(1076002)(6116002)(8676002)(81166006)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3062; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3062; 23:oof6TyegH07VfJY61cjm6zRQUwBCYybupuiQYPHz6?= =?us-ascii?Q?IDa9D5Zj/DoWx5pJJPb8n5s25JHPQY3BG/+XP7EM7WoNO7vzEsJGGkiLZFKy?= =?us-ascii?Q?QmaR4Lazn47+vRti9fVjzZ38FXD6ZJg+t7OoP2BEH/5f8t+WDYdCuwnzDu6d?= =?us-ascii?Q?rmTjmQVpMQBho6JvEePuw7KDE5NFlB2dqiz4U9zp/D/KHGdNJfsTiDsZkGST?= =?us-ascii?Q?YkoXknbL2RUkCndzT+bk8oLRHIzXkrVlVrj+IwPtL2PH01VA9RHg211DM/NL?= =?us-ascii?Q?KLhzV8pj3j2pAXukc0O+822HiWd/weR5LAUR3pWOPi4QsnvvcJ35m85CeLYt?= =?us-ascii?Q?89fKAuGd06Seb5RC7MpXj9Xwy23g/csAZfvV90W+8EkO3bjpl9hKieQ4U8r+?= =?us-ascii?Q?xyk8jWuzgxLxTaSFMDnr2FRJehi0xit1PLgiF+h4AuvGGaA+D4ycbI1zvRyi?= =?us-ascii?Q?j89dvoBP+wa+ZQ6v5pwmtilnaOKoeruD7v+X3GKOtjGicnjyHKOqTOurQD+W?= =?us-ascii?Q?tJFtVO+SWJaD+msDXgIzQM1Q8c6+MrmIAG0MpKZD2rQ3RBpBo8p4CYTH88AR?= =?us-ascii?Q?25R4oCo7XdcvtpkcgybqhF8E10//QrplN6JEF+O6wy4VrSz0+9+c7kAit/Jt?= =?us-ascii?Q?JZ2F3jU0pK30JXllPBuSTdq2mNwnPBU0TUcEJKfOB/Rru2xUWPxzJcc/JV4l?= =?us-ascii?Q?J1pNT5y8KBG9Re423MpnG3XOM7qSMYLkpoOEXOYhly5UO9iaLaRS9NuU4Ae+?= =?us-ascii?Q?uA1uXSs0WFJ4VcG6V5pwEQRGblP3ku3cxCpLM12Nf7bm8lxXsW8lt/bWkBv6?= =?us-ascii?Q?eqVrp7I4K3JoCRrQWbwJa4RW36dgus/2xmNtp83kYhbWjZIq1iFiD2pwXHXT?= =?us-ascii?Q?nMHBU0B3Ss6w3MVD5orEppmRY2CcWEpAjO3NBd0sQgxWxXaORcqoB8bdTkVu?= =?us-ascii?Q?T101RKQtIvCjJ/ACNpquY2sKhGPyxJFyMPJUs6SHcpi727tW/pcGcipOHYh1?= =?us-ascii?Q?iaSJ3rIJkmToXHAtXB9emTrngHYQFXXjA37eYSt07NUJsCqLatTI9r5WS0Pu?= =?us-ascii?Q?tOvp7JBkDNQfQjlP8ux0KHnlm/m38ksGFL78i9WAoXLGWv2/1Kwg6+8nn1RA?= =?us-ascii?Q?uQ6u6sbewynROQtJ1yd2DaIU4xDlhdOoOBH3ZZ0KQJN6hbJ+ZChQsNlupHlc?= =?us-ascii?Q?2VWKZ7w6A/L6r9bNDmDkmZsU/H1SSVmz2Q8DMhYx9oME8k/sRORBGl8I/JSN?= =?us-ascii?Q?MXxAJFHMLyh5CGFNUiLT5HC4wFPBZi1F7i4HfOvsQ+x1hzjFz3WjSC3x9ycP?= =?us-ascii?Q?2fIy91DRHpOmPE8UkNKIKV+Ac5Q9AgnWR6TGAeBppTu?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3062; 6:86Z2viKAlU4AEMACBIdILYUUMo2tiMazn4gIYJd0y1gp06XveBLu1IyQ8D8AQZ5wG7rxpa+z7Hn1MtBlYtT/uztuOZ1vaAIrHRdS+P5SB6XK0SoTOhw3UMskZJaeG5sgH4cyj8i2qnP8iM9gtZBRCQrJHywQVxwyhCx/GgFoOnx1Qtf4xgmBchjP+iP8EZkFVJjQBRBpUVik908Dqi3FEXMuz4hexaZvd6q24eLFl42Csw2TWREh1WIxTklFHmfjZD72RGE8aBMpUziPdSLmDg5fJUKe4HYdJwB1svwbdKslVXYIpntR7CYc+qb4/k102b+mRAfAP9EA/PFKIVyDBA==; 5:0rZrJaursNHULM7339yTJI6MzsM3KPYVyKk737yZvRwk7fMp04iWDi7hkfd5QLmF7N48S4+VRkJfS0j8UQEg89+WFHUnd45s4clQ3MFOcxhKYP8NI3/ViDzSy+D3SliM3XV+MM3JkUYALm3tccFw5A==; 24:pgXbn+0aPPOf5Wl6uDG1d2PhQXJaezNLcPxi3QWwZq9doYPm69bIKVa5drOWNiYE6GnfTCyJ2RopLtdmfXkOKsvYriNAUJbyyM+/xfNbphE=; 7:+RIq4tdWCuo6VHOyOylMA9mm2PavKV0GMlsq50teKcfzuWIsdon9BJ0d+V6hwduR+xmhHskI7yGuSW3COkCKj1B8pesORxud2sZ7dDx88+waUTqsB5tJuPpNJIZhCOA4ZSw4ufP74pxfUZgGHxtfZkPdQzwH7kzwcJ5tzxtlgDH0tYcOVnluGXNztQ/TqbBFnSAIFmO9g4sk2NzBl4hHDJd417OuOVhMW5XO7op3to4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2017 19:03:53.6434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3062 Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 19:03:59 -0000 On Mon, Oct 23, 2017 at 09:36:38AM -0700, Ferruh Yigit wrote: > On 10/23/2017 5:28 AM, Shijith Thotton wrote: > > On Fri, Oct 20, 2017 at 09:57:38AM -0700, Ferruh Yigit wrote: > >> On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > >>> Remove device reset during application start, the reset for application > >>> exit still there. > >>> > >>> Reset in open removed because of following comments: > >>> 1- Device reset not completed when VF driver loaded, which cause VF PMD > >>> initialization error. > >>> Adding delay can solve the issue but will increase driver load time. > >>> > >>> 2- Reset will be issues all devices unconditionally, not very efficient > >>> way. > >>> > >>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > >>> Cc: stable@dpdk.org > >>> > >>> Signed-off-by: Ferruh Yigit > >> > >> Hi Jingjing, Shijith, Gregory, Harish, > >> > >> Can you please test this on top of current master (which has already Jingjin's > >> fix) ? > > > > Hi Ferruh, > > > > Tested for LiquidIO cards and it works. > > Thanks Shijith, > > Is following commit needs to be reverted after pci_reset removed from open(): > > Commit: 9ed3f38770c6 ("net/liquidio: remove FLR request to PF driver") Not required. The commit can stay. Thanks, Shijith