From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id BD4CF1B744 for ; Tue, 24 Oct 2017 09:11:47 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id z3so7072229wme.5 for ; Tue, 24 Oct 2017 00:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=2oE8XqM7uHh0k0U/zOVirPlBB1Jj+4ygO33/5DJ2Q4w=; b=SBKSqG0jfuSpmmC5Bp+oP/4wWkeP9p+pu1mgaVnC3aYYp0+KQDUo2ytkWLIBYmtE4g SnolnMuSyQkZurQ5HwkjqqesCyGRaiyRujDN4rbuOX9h/qmQ4sAdr9rmUMPQmOXYCIEy TZqiRIcuGy5JZc1uiUkQAkuyEOdlbRs6l5A80d1ocIyzOt/IVfuXs6JUhK1qJm7k9V9q ZPaMDtlo/nT2xHtmYiNYw0iWq+03WZUdfjbusO7bq7DOy8e/8rlUyJMlaukMU4EJvnHc eAz/ewJIzdgI+NvwsjqRz6OsXs+tK60tS2hgYRJ/yebqiMeoLOa/EQmlCR3vv4gTVXHC hTLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=2oE8XqM7uHh0k0U/zOVirPlBB1Jj+4ygO33/5DJ2Q4w=; b=NYKlztsVwu465Uo0R2TDtDx1Km4s4CIUuSHaj8i5lHrQg7rQMKCKqC4JctZCXbdwSw 2IPke2xothP0JEIvB+qGz5wscD88LkmVZefuZuSs+RMd/Hd6u3wRmm+KRGI/jEsfZdgx rt91BNKW8GHmDRLKhrwLFl/uZyZZp11G1VVMrBVf5ksFiMDJGu9ZOksBRMjr74/c8lq/ oBRWdu2BZm7Kzqye4hU4RnPPrvkNWX0TQdVzTEJDDfhx5VHINSVkohQPTjWUWXfKQFMq 7HOHc7phu4e4M4L5L6q34xPNFIHcFUy3HYJJuiNoOW/EYxPCyjqI2cKutXWp0ExVc6m4 bY2g== X-Gm-Message-State: AMCzsaX7l1/OCkPSJOnBVIxBfM1uKmf8sZ57WuGUIcvcfPIV0hjNQqRM 0beU9S/1BQEyn2uzu//KLRSX X-Google-Smtp-Source: ABhQp+RliF3fGxjVqhTJozZK4eyhW2fmkCQcGE3YASCEt7vYO7WW1pyL1yKMbxPl0zf67m+6uAQURA== X-Received: by 10.80.226.8 with SMTP id n8mr19449088edl.177.1508829107236; Tue, 24 Oct 2017 00:11:47 -0700 (PDT) Received: from laranjeiro-vm (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r15sm7914656edi.52.2017.10.24.00.11.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 00:11:46 -0700 (PDT) From: "=?iso-8859-1?Q?N=E9lio?= Laranjeiro" X-Google-Original-From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Date: Tue, 24 Oct 2017 09:11:42 +0200 To: Yongseok Koh Cc: Nelio Laranjeiro , dev@dpdk.org, Adrien Mazarguil Message-ID: <20171024071142.3wsybjacfoa6i453@laranjeiro-vm> References: <20171023192544.GA19386@yongseok-MBP.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171023192544.GA19386@yongseok-MBP.local> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: fix reception when VLAN is added X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 07:11:47 -0000 On Mon, Oct 23, 2017 at 12:25:45PM -0700, Yongseok Koh wrote: > On Mon, Oct 23, 2017 at 04:49:56PM +0200, Nelio Laranjeiro wrote: > > @@ -261,75 +284,59 @@ priv_dev_traffic_enable(struct priv *priv, struct rte_eth_dev *dev) > > }; > > > > claim_zero(mlx5_ctrl_flow(dev, &promisc, &promisc)); > > - } else if (dev->data->all_multicast) { > > + return 0; > > + } > > + if (dev->data->all_multicast) { > > struct rte_flow_item_eth multicast = { > > .dst.addr_bytes = "\x01\x00\x00\x00\x00\x00", > > - .src.addr_bytes = "\x01\x00\x00\x00\x00\x00", > > + .src.addr_bytes = "\x00\x00\x00\x00\x00\x00", > > .type = 0, > > }; > > > > claim_zero(mlx5_ctrl_flow(dev, &multicast, &multicast)); > > Just curious. No need to consider VLAN for multicast here? According to the lib documentation no [1] "Enable the receipt of any multicast frame by an Ethernet device" > [...] > These (bcast and ipv6_multi_mask) can be duplicated multiple times if there are > multiple MAC addrs, is that intended? There is in fact an issue in this series, it does not match my final code. I'll send a v3. [1] http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.h#n2304 -- Nélio Laranjeiro 6WIND