* [dpdk-dev] [PATCH] pci: fix check uio bind
@ 2017-10-19 11:18 Jianfeng Tan
2017-10-19 11:42 ` Gaëtan Rivet
2017-10-24 7:44 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan
0 siblings, 2 replies; 9+ messages in thread
From: Jianfeng Tan @ 2017-10-19 11:18 UTC (permalink / raw)
To: dev
Cc: santosh.shukla, jerin.jacob, anatoly.burakov, gaetan.rivet, Jianfeng Tan
When checking if any devices bound to uio, we did not exclud
those which are blacklisted (or in the case that a whitelist
is specified).
This patch fixes it by only checking whitelisted devices.
Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux")
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index b4dbf95..2b23d67 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -516,8 +516,26 @@ static inline int
pci_one_device_bound_uio(void)
{
struct rte_pci_device *dev = NULL;
+ struct rte_devargs *devargs;
+ int check_all = 1;
+ int need_check;
+
+ if (rte_pci_bus.bus.conf.scan_mode == RTE_BUS_SCAN_WHITELIST)
+ check_all = 0;
FOREACH_DEVICE_ON_PCIBUS(dev) {
+ devargs = dev->device.devargs;
+
+ need_check = 0;
+ if (check_all)
+ need_check = 1;
+ else if (devargs != NULL &&
+ devargs->policy == RTE_DEV_WHITELISTED)
+ need_check = 1;
+
+ if (!need_check)
+ continue;
+
if (dev->kdrv == RTE_KDRV_IGB_UIO ||
dev->kdrv == RTE_KDRV_UIO_GENERIC) {
return 1;
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] pci: fix check uio bind 2017-10-19 11:18 [dpdk-dev] [PATCH] pci: fix check uio bind Jianfeng Tan @ 2017-10-19 11:42 ` Gaëtan Rivet 2017-10-20 16:47 ` Tan, Jianfeng 2017-10-24 7:44 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan 1 sibling, 1 reply; 9+ messages in thread From: Gaëtan Rivet @ 2017-10-19 11:42 UTC (permalink / raw) To: Jianfeng Tan; +Cc: dev, santosh.shukla, jerin.jacob, anatoly.burakov Hi Jianfeng, On Thu, Oct 19, 2017 at 11:18:29AM +0000, Jianfeng Tan wrote: > When checking if any devices bound to uio, we did not exclud > those which are blacklisted (or in the case that a whitelist > is specified). > > This patch fixes it by only checking whitelisted devices. > > Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") > > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> > --- > lib/librte_eal/linuxapp/eal/eal_pci.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c > index b4dbf95..2b23d67 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > @@ -516,8 +516,26 @@ static inline int > pci_one_device_bound_uio(void) > { > struct rte_pci_device *dev = NULL; > + struct rte_devargs *devargs; > + int check_all = 1; > + int need_check; > + > + if (rte_pci_bus.bus.conf.scan_mode == RTE_BUS_SCAN_WHITELIST) > + check_all = 0; > > FOREACH_DEVICE_ON_PCIBUS(dev) { > + devargs = dev->device.devargs; > + > + need_check = 0; > + if (check_all) Unless I'm mistaken, you will check blacklisted devices as well here. The condition should be something like: if (check_all && devargs == NULL) Which means that both ifs can be refactored as if ((check_all ^ (devargs != NULL)) == 0) continue; Removing need_check. But it can be hard to read. > + need_check = 1; > + else if (devargs != NULL && > + devargs->policy == RTE_DEV_WHITELISTED) > + need_check = 1; > + > + if (!need_check) > + continue; > + > if (dev->kdrv == RTE_KDRV_IGB_UIO || > dev->kdrv == RTE_KDRV_UIO_GENERIC) { > return 1; > -- > 2.7.4 > -- Gaëtan Rivet 6WIND ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] pci: fix check uio bind 2017-10-19 11:42 ` Gaëtan Rivet @ 2017-10-20 16:47 ` Tan, Jianfeng 2017-10-20 20:08 ` Gaëtan Rivet 0 siblings, 1 reply; 9+ messages in thread From: Tan, Jianfeng @ 2017-10-20 16:47 UTC (permalink / raw) To: Gaëtan Rivet; +Cc: dev, santosh.shukla, jerin.jacob, anatoly.burakov Hi Gaëtan, On 10/19/2017 7:42 PM, Gaëtan Rivet wrote: > Hi Jianfeng, > > On Thu, Oct 19, 2017 at 11:18:29AM +0000, Jianfeng Tan wrote: >> When checking if any devices bound to uio, we did not exclud >> those which are blacklisted (or in the case that a whitelist >> is specified). >> >> This patch fixes it by only checking whitelisted devices. >> >> Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") >> >> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> >> --- >> lib/librte_eal/linuxapp/eal/eal_pci.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c >> index b4dbf95..2b23d67 100644 >> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c >> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c >> @@ -516,8 +516,26 @@ static inline int >> pci_one_device_bound_uio(void) >> { >> struct rte_pci_device *dev = NULL; >> + struct rte_devargs *devargs; >> + int check_all = 1; >> + int need_check; >> + >> + if (rte_pci_bus.bus.conf.scan_mode == RTE_BUS_SCAN_WHITELIST) >> + check_all = 0; >> >> FOREACH_DEVICE_ON_PCIBUS(dev) { >> + devargs = dev->device.devargs; >> + >> + need_check = 0; >> + if (check_all) > Unless I'm mistaken, you will check blacklisted devices as well here. Thank you for pointing out this. I was referring to rte_pci_probe(), which also only check "probe_all" and (devargs && RTE_DEV_WHITELISTED); but turns out it double checks the blacklisted devices in rte_pci_probe_one_driver(). I'll fix it. > The condition should be something like: > > if (check_all && devargs == NULL) > Which means that both ifs can be refactored as > > if ((check_all ^ (devargs != NULL)) == 0) > continue; > > Removing need_check. But it can be hard to read. Yes, I prefer to make it easy to understand. Please let me know if you are OK with below code (remove check_all): FOREACH_DEVICE_ON_PCIBUS(dev) { devargs = dev->device.devargs; need_check = 0; switch (rte_pci_bus.bus.conf.scan_mode) { case RTE_BUS_SCAN_UNDEFINED: need_check = 1; break; case RTE_BUS_SCAN_WHITELIST: if (devargs && devargs->policy == RTE_DEV_WHITELISTED) need_check = 1; break; case RTE_BUS_SCAN_BLACKLIST: if (!devargs || devargs->policy != RTE_DEV_BLACKLISTED) need_check = 1; break; } if (!need_check) continue; ... Thanks, Jianfeng ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] pci: fix check uio bind 2017-10-20 16:47 ` Tan, Jianfeng @ 2017-10-20 20:08 ` Gaëtan Rivet 2017-10-23 3:20 ` Tan, Jianfeng 0 siblings, 1 reply; 9+ messages in thread From: Gaëtan Rivet @ 2017-10-20 20:08 UTC (permalink / raw) To: Tan, Jianfeng; +Cc: dev, santosh.shukla, jerin.jacob, anatoly.burakov On Sat, Oct 21, 2017 at 12:47:14AM +0800, Tan, Jianfeng wrote: > Hi Gaëtan, > > > On 10/19/2017 7:42 PM, Gaëtan Rivet wrote: > >Hi Jianfeng, > > > >On Thu, Oct 19, 2017 at 11:18:29AM +0000, Jianfeng Tan wrote: > >>When checking if any devices bound to uio, we did not exclud > >>those which are blacklisted (or in the case that a whitelist > >>is specified). > >> > >>This patch fixes it by only checking whitelisted devices. > >> > >>Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") > >> > >>Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> > >>--- > >> lib/librte_eal/linuxapp/eal/eal_pci.c | 18 ++++++++++++++++++ > >> 1 file changed, 18 insertions(+) > >> > >>diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c > >>index b4dbf95..2b23d67 100644 > >>--- a/lib/librte_eal/linuxapp/eal/eal_pci.c > >>+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > >>@@ -516,8 +516,26 @@ static inline int > >> pci_one_device_bound_uio(void) > >> { > >> struct rte_pci_device *dev = NULL; > >>+ struct rte_devargs *devargs; > >>+ int check_all = 1; > >>+ int need_check; > >>+ > >>+ if (rte_pci_bus.bus.conf.scan_mode == RTE_BUS_SCAN_WHITELIST) > >>+ check_all = 0; > >> FOREACH_DEVICE_ON_PCIBUS(dev) { > >>+ devargs = dev->device.devargs; > >>+ > >>+ need_check = 0; > >>+ if (check_all) > >Unless I'm mistaken, you will check blacklisted devices as well here. > > Thank you for pointing out this. > > I was referring to rte_pci_probe(), which also only check "probe_all" and > (devargs && RTE_DEV_WHITELISTED); but turns out it double checks the > blacklisted devices in rte_pci_probe_one_driver(). > > I'll fix it. > > >The condition should be something like: > > > >if (check_all && devargs == NULL) > > >Which means that both ifs can be refactored as > > > >if ((check_all ^ (devargs != NULL)) == 0) > > continue; > > > >Removing need_check. But it can be hard to read. > > Yes, I prefer to make it easy to understand. Please let me know if you are > OK with below code (remove check_all): > > FOREACH_DEVICE_ON_PCIBUS(dev) { > devargs = dev->device.devargs; > > need_check = 0; > switch (rte_pci_bus.bus.conf.scan_mode) { > case RTE_BUS_SCAN_UNDEFINED: > need_check = 1; > break; > case RTE_BUS_SCAN_WHITELIST: > if (devargs && devargs->policy == > RTE_DEV_WHITELISTED) > need_check = 1; > break; > case RTE_BUS_SCAN_BLACKLIST: > if (!devargs || devargs->policy != > RTE_DEV_BLACKLISTED) > need_check = 1; > break; > } > > if (!need_check) > continue; > ... I like the switch, two remarks however: 1. The SCAN_UNDEFINED basically means blacklist mode for the PCI bus. This is the reason probe_all was set by testing for WHITELIST mode: either of the other too would thus trigger the blacklist behavior. Thus, I think you could write a fallthrough case for UNDEFINED, that would go into the BLACKLIST mode. 2. For pointers in general I would test against NULL instead of using the unary '!'. I think it is the general policy in DPDK to always explicitly check against the constant value, but I personally think that for booleans like need_check the "not" operator is ok. So I will only highlight the !devargs :) > > Thanks, > Jianfeng -- Gaëtan Rivet 6WIND ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] pci: fix check uio bind 2017-10-20 20:08 ` Gaëtan Rivet @ 2017-10-23 3:20 ` Tan, Jianfeng 0 siblings, 0 replies; 9+ messages in thread From: Tan, Jianfeng @ 2017-10-23 3:20 UTC (permalink / raw) To: Gaëtan Rivet; +Cc: dev, santosh.shukla, jerin.jacob, Burakov, Anatoly Hi Gaëtan, > -----Original Message----- > From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Saturday, October 21, 2017 4:08 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org; santosh.shukla@caviumnetworks.com; > jerin.jacob@caviumnetworks.com; Burakov, Anatoly > Subject: Re: [PATCH] pci: fix check uio bind > > On Sat, Oct 21, 2017 at 12:47:14AM +0800, Tan, Jianfeng wrote: > > Hi Gaëtan, > > > > > > On 10/19/2017 7:42 PM, Gaëtan Rivet wrote: > > >Hi Jianfeng, > > > > > >On Thu, Oct 19, 2017 at 11:18:29AM +0000, Jianfeng Tan wrote: > > >>When checking if any devices bound to uio, we did not exclud > > >>those which are blacklisted (or in the case that a whitelist > > >>is specified). > > >> > > >>This patch fixes it by only checking whitelisted devices. > > >> > > >>Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") > > >> > > >>Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> > > >>--- > > >> lib/librte_eal/linuxapp/eal/eal_pci.c | 18 ++++++++++++++++++ > > >> 1 file changed, 18 insertions(+) > > >> > > >>diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c > b/lib/librte_eal/linuxapp/eal/eal_pci.c > > >>index b4dbf95..2b23d67 100644 > > >>--- a/lib/librte_eal/linuxapp/eal/eal_pci.c > > >>+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > > >>@@ -516,8 +516,26 @@ static inline int > > >> pci_one_device_bound_uio(void) > > >> { > > >> struct rte_pci_device *dev = NULL; > > >>+ struct rte_devargs *devargs; > > >>+ int check_all = 1; > > >>+ int need_check; > > >>+ > > >>+ if (rte_pci_bus.bus.conf.scan_mode == RTE_BUS_SCAN_WHITELIST) > > >>+ check_all = 0; > > >> FOREACH_DEVICE_ON_PCIBUS(dev) { > > >>+ devargs = dev->device.devargs; > > >>+ > > >>+ need_check = 0; > > >>+ if (check_all) > > >Unless I'm mistaken, you will check blacklisted devices as well here. > > > > Thank you for pointing out this. > > > > I was referring to rte_pci_probe(), which also only check "probe_all" and > > (devargs && RTE_DEV_WHITELISTED); but turns out it double checks the > > blacklisted devices in rte_pci_probe_one_driver(). > > > > I'll fix it. > > > > >The condition should be something like: > > > > > >if (check_all && devargs == NULL) > > > > >Which means that both ifs can be refactored as > > > > > >if ((check_all ^ (devargs != NULL)) == 0) > > > continue; > > > > > >Removing need_check. But it can be hard to read. > > > > Yes, I prefer to make it easy to understand. Please let me know if you are > > OK with below code (remove check_all): > > > > FOREACH_DEVICE_ON_PCIBUS(dev) { > > devargs = dev->device.devargs; > > > > need_check = 0; > > switch (rte_pci_bus.bus.conf.scan_mode) { > > case RTE_BUS_SCAN_UNDEFINED: > > need_check = 1; > > break; > > case RTE_BUS_SCAN_WHITELIST: > > if (devargs && devargs->policy == > > RTE_DEV_WHITELISTED) > > need_check = 1; > > break; > > case RTE_BUS_SCAN_BLACKLIST: > > if (!devargs || devargs->policy != > > RTE_DEV_BLACKLISTED) > > need_check = 1; > > break; > > } > > > > if (!need_check) > > continue; > > ... > > I like the switch, two remarks however: > > 1. The SCAN_UNDEFINED basically means blacklist mode for the PCI bus. > This is the reason probe_all was set by testing for WHITELIST > mode: either of the other too would thus trigger the blacklist > behavior. > > Thus, I think you could write a fallthrough case for UNDEFINED, that > would go into the BLACKLIST mode. > > 2. For pointers in general I would test against NULL instead of using > the unary '!'. > I think it is the general policy in DPDK to always explicitly check > against the constant value, but I personally think that for booleans > like need_check the "not" operator is ok. > So I will only highlight the !devargs :) Make sense! Will send out a new version as per your above suggestions. Thanks, Jianfeng ^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2] pci: fix check uio bind 2017-10-19 11:18 [dpdk-dev] [PATCH] pci: fix check uio bind Jianfeng Tan 2017-10-19 11:42 ` Gaëtan Rivet @ 2017-10-24 7:44 ` Jianfeng Tan 2017-10-24 8:25 ` Gaëtan Rivet 2017-10-24 8:31 ` santosh 1 sibling, 2 replies; 9+ messages in thread From: Jianfeng Tan @ 2017-10-24 7:44 UTC (permalink / raw) To: dev; +Cc: gaetan.rivet, Jianfeng Tan When checking if any devices bound to uio, we did not exclud those which are blacklisted (or in the case that a whitelist is specified). This patch fixes it by only checking whitelisted devices, or not-blacklisted devices depending on the bus scan mode. Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> --- v2: - Accept two suggestions from Gaetan. lib/librte_eal/linuxapp/eal/eal_pci.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c index b4dbf95..4d1de07 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c @@ -516,8 +516,29 @@ static inline int pci_one_device_bound_uio(void) { struct rte_pci_device *dev = NULL; + struct rte_devargs *devargs; + int need_check; FOREACH_DEVICE_ON_PCIBUS(dev) { + devargs = dev->device.devargs; + + need_check = 0; + switch (rte_pci_bus.bus.conf.scan_mode) { + case RTE_BUS_SCAN_WHITELIST: + if (devargs && devargs->policy == RTE_DEV_WHITELISTED) + need_check = 1; + break; + case RTE_BUS_SCAN_UNDEFINED: + case RTE_BUS_SCAN_BLACKLIST: + if (devargs == NULL || + devargs->policy != RTE_DEV_BLACKLISTED) + need_check = 1; + break; + } + + if (!need_check) + continue; + if (dev->kdrv == RTE_KDRV_IGB_UIO || dev->kdrv == RTE_KDRV_UIO_GENERIC) { return 1; -- 2.7.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] pci: fix check uio bind 2017-10-24 7:44 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan @ 2017-10-24 8:25 ` Gaëtan Rivet 2017-10-26 21:48 ` Thomas Monjalon 2017-10-24 8:31 ` santosh 1 sibling, 1 reply; 9+ messages in thread From: Gaëtan Rivet @ 2017-10-24 8:25 UTC (permalink / raw) To: Jianfeng Tan; +Cc: dev On Tue, Oct 24, 2017 at 07:44:53AM +0000, Jianfeng Tan wrote: > When checking if any devices bound to uio, we did not exclud > those which are blacklisted (or in the case that a whitelist > is specified). > > This patch fixes it by only checking whitelisted devices, or > not-blacklisted devices depending on the bus scan mode. > > Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") > > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> Small nit below, but otherwise: Reviewed-by: Gaetan Rivet <gaetan.rivet@6wind.com> > --- > v2: > - Accept two suggestions from Gaetan. > > lib/librte_eal/linuxapp/eal/eal_pci.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c > index b4dbf95..4d1de07 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > @@ -516,8 +516,29 @@ static inline int > pci_one_device_bound_uio(void) > { > struct rte_pci_device *dev = NULL; > + struct rte_devargs *devargs; > + int need_check; Both could have been declared within the loop instead, but this is really a detail and isn't worth a v3 IMO, so do as you please. > > FOREACH_DEVICE_ON_PCIBUS(dev) { > + devargs = dev->device.devargs; > + > + need_check = 0; > + switch (rte_pci_bus.bus.conf.scan_mode) { > + case RTE_BUS_SCAN_WHITELIST: > + if (devargs && devargs->policy == RTE_DEV_WHITELISTED) > + need_check = 1; > + break; > + case RTE_BUS_SCAN_UNDEFINED: > + case RTE_BUS_SCAN_BLACKLIST: > + if (devargs == NULL || > + devargs->policy != RTE_DEV_BLACKLISTED) > + need_check = 1; > + break; > + } > + > + if (!need_check) > + continue; > + > if (dev->kdrv == RTE_KDRV_IGB_UIO || > dev->kdrv == RTE_KDRV_UIO_GENERIC) { > return 1; > -- > 2.7.4 > -- Gaëtan Rivet 6WIND ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] pci: fix check uio bind 2017-10-24 8:25 ` Gaëtan Rivet @ 2017-10-26 21:48 ` Thomas Monjalon 0 siblings, 0 replies; 9+ messages in thread From: Thomas Monjalon @ 2017-10-26 21:48 UTC (permalink / raw) To: Jianfeng Tan; +Cc: dev, Gaëtan Rivet 24/10/2017 10:25, Gaëtan Rivet: > On Tue, Oct 24, 2017 at 07:44:53AM +0000, Jianfeng Tan wrote: > > When checking if any devices bound to uio, we did not exclud > > those which are blacklisted (or in the case that a whitelist > > is specified). > > > > This patch fixes it by only checking whitelisted devices, or > > not-blacklisted devices depending on the bus scan mode. > > > > Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") > > > > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> > Small nit below, but otherwise: > > Reviewed-by: Gaetan Rivet <gaetan.rivet@6wind.com> Applied as is, thanks ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] pci: fix check uio bind 2017-10-24 7:44 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan 2017-10-24 8:25 ` Gaëtan Rivet @ 2017-10-24 8:31 ` santosh 1 sibling, 0 replies; 9+ messages in thread From: santosh @ 2017-10-24 8:31 UTC (permalink / raw) To: Jianfeng Tan, dev; +Cc: gaetan.rivet Hi Jianfeng, On Tuesday 24 October 2017 01:14 PM, Jianfeng Tan wrote: > When checking if any devices bound to uio, we did not exclud > those which are blacklisted (or in the case that a whitelist > is specified). > > This patch fixes it by only checking whitelisted devices, or > not-blacklisted devices depending on the bus scan mode. > > Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") > > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> > --- > v2: > - Accept two suggestions from Gaetan. v2, looks good to me. Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com> Thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-10-26 21:48 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-10-19 11:18 [dpdk-dev] [PATCH] pci: fix check uio bind Jianfeng Tan 2017-10-19 11:42 ` Gaëtan Rivet 2017-10-20 16:47 ` Tan, Jianfeng 2017-10-20 20:08 ` Gaëtan Rivet 2017-10-23 3:20 ` Tan, Jianfeng 2017-10-24 7:44 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan 2017-10-24 8:25 ` Gaëtan Rivet 2017-10-26 21:48 ` Thomas Monjalon 2017-10-24 8:31 ` santosh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).