From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 892401B75D; Tue, 24 Oct 2017 10:46:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 396C41521; Tue, 24 Oct 2017 04:46:26 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 24 Oct 2017 04:46:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=BvGubRMi11bv0P5TN4PBUuARMobCuLMACcDLobz9L8g=; b=O3uKbVpp aCmta2UJw3fDBXu+m/bgMqtWa5h/OxwZ5rUA/MmYRc/tHTfMaV8O7WI4zQFd8XIU VtMLJg+fqK8W7oqYFIK1NlptPQ2CJvTF8jTfzqtgxV9JYjJO5Ue0OJsPrAXr6I2D LP5AHVUDjafP6Hwd2vHDDa5Bp2RG1jOX4StnIhcZOq44wNE477TajTF3yHvpeEk7 kK1Y9wPVMhd1gd9mgxOTRQkDr5FSNn8rT20qwfql7UrZlkZ4A/a23eVfT+MN6T++ qb8b219J+FKUvYooh1dihWAf37DAQA1IfNaAd+bExuERq7oMQZbJk7s7aItMxx8K cW7IPokps2FdhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=BvGubRMi11bv0P5TN4PBUuARMobCu LMACcDLobz9L8g=; b=Jfo0tD6pykhOczQnqIHaWaPQMIOl+AqIZpvPZSnq0uL5n zyiEoUiYUJxy1nE8/vbHAb9lzhCeKJHGeiokTOzZjzCdmUrHLG0y5b6XQyDNdi0C zHwIxNCNJ0pN673Hlnp0ll6a9+VORVMenaDzczd9wU9B3LTgoCqKUAF2RF6GYjWK tkGKHw1TDUVBlD1TC+VXmkGF4fqV45Dr1saW7+url4Jo/02lMGJrw99ROGaRtTpo HVlnu8wTgDq6fvUIRkPalsMkmVsMvDGdfGV6K/xXZa0HP/Wz6F4Z6dLRFfHH8KVP Mpv1eqAg3a2xiCp2dFqscHhXE0VPikFUtcove0IOw== X-ME-Sender: Received: from yliu-home (unknown [180.158.56.237]) by mail.messagingengine.com (Postfix) with ESMTPA id EB04C7E1AE; Tue, 24 Oct 2017 04:46:24 -0400 (EDT) Date: Tue, 24 Oct 2017 16:46:21 +0800 From: Yuanhan Liu To: Zhiyong Yang Cc: dev@dpdk.org, stable@dpdk.org, maxime.coquelin@redhat.com Message-ID: <20171024084621.GO1545@yliu-home> References: <20171023064036.56821-1-zhiyong.yang@intel.com> <20171024030614.37690-1-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171024030614.37690-1-zhiyong.yang@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong TX pkt length stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 08:46:26 -0000 On Tue, Oct 24, 2017 at 11:06:14AM +0800, Zhiyong Yang wrote: > In the function virtqueue_enqueue_xmit(), when can_push is true, > vtnet_hdr_size is added to pkt_len by calling rte_pktmbuf_prepend. > which is wrong for pkt stats, virtio header length should be subtracted > before calling stats function. > > Fixes: 58169a9c8153 ("net/virtio: support Tx checksum offload") > > Cc: stable@dpdk.org > Cc: yliu@fridaylinux.org > Cc: maxime.coquelin@redhat.com > Signed-off-by: Zhiyong Yang > Reviewed-by: Maxime Coquelin Applied to dpdk-next-virtio. Thanks. --yliu