From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix targetless internal rule creation
Date: Tue, 24 Oct 2017 11:21:17 +0200 [thread overview]
Message-ID: <20171024092117.GY26782@6wind.com> (raw)
In-Reply-To: <1508834730-30271-1-git-send-email-matan@mellanox.com>
On Tue, Oct 24, 2017 at 08:45:30AM +0000, Matan Azrad wrote:
> The corrupted code allowed to create internal rule with no any target queue
> in case the rule creation ocured before queues creation.
ocured => occurred
>
> For example, when user calls rte_eth_dev_default_mac_addr_set after probe
> and before dev_configure, mlx4 failis because the RSS queue number was 0.
failis => fails
>
> The fix prevents internal rules creation before queues creation based on
> future creation before traffic start.
>
> Fixes: 7d8675956f57 ("net/mlx4: add RSS support outside flow API")
Since adding MAC addresses before dev_configure() was not taken into account
in the design of the affected function, I suggest appending:
Fixes: bdcad2f4843a ("net/mlx4: refactor internal flow rules")
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Thanks.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-10-24 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 8:45 Matan Azrad
2017-10-24 9:21 ` Adrien Mazarguil [this message]
2017-10-24 10:05 ` [dpdk-dev] [PATCH v2] " Matan Azrad
2017-10-24 18:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024092117.GY26782@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).