From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id EA0EE1B738 for ; Tue, 24 Oct 2017 11:21:29 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id u138so14323440wmu.5 for ; Tue, 24 Oct 2017 02:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=naR8Cp0aSa3cpWZykV1zk1IgZC+vNg6CV5KVzfjpYfY=; b=vTQtcMj1zUSc4NJRvVuvDJVIGRDyEIYz911pI1PqcTohAt0Ecw3ApgYGxdC/WFUN3E 3+IBFLaDJsc3rexrXtZMXXsQCnmtx6u0RB2uEY2AdMKwrenReUQDyJuJesuuzc8SSqYn lg3r5z4FfwsmKZoGB4mXPsjrfvRJcILkoI6cnrtDI0k8MYYk4V3Oi/21ebtyXbMar08i L0kcakuzmgJjNU6L0ZVQ0HJuey7cYmMZiD2v7AmOrELE3ECmnbZzMhR6gdQPp5lbRGV7 uOBdO8yFxWMneQtvHHC9LVdyV4I/G202KWaS4xAsf/A4vu64e5pRVekfgLnkZfgVuj42 OKlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=naR8Cp0aSa3cpWZykV1zk1IgZC+vNg6CV5KVzfjpYfY=; b=lYey7N48Bt9/6vNzKQoDAI5wNfVFH0WppoGLF4yOqbnsGB04ElAXfuugkTlMCTLHgM QgHo4Nzlq1mFhDCSeiTQH2K6o603liczs8KSiZbI2tqI1XXm05rioETk0MuxrRPQUCk/ g32U/rBspp9XLvhRS8u86/tqe7tUInQ/8bZk4W2xccBWwSUyi+6NuWHlS1UFKJQmiBdb JqmwCDXiqMdwCy9Ziu9I8zQRMdN5VYFdUGVvykGNm7tBIQlJ/3aTVHABduXjhyAsVBbq s/wTcBJtIeZo2spoapOc1NtAnYeeb46nqTndozwMDaRhrQmY/rynKSftSc1SYDPAW+I8 BUJA== X-Gm-Message-State: AMCzsaUi3lV179GMJ7N9bh5mwD/zR4eBAnPCAPJW4/4r8v290Pqq9ZzR l/uQO5wupGMib+JK5fDOw56TNtmk X-Google-Smtp-Source: ABhQp+Qip5pe4AJHEV/Z2Ame4ULYP8T93kSCcGCbHDLxtb3BAeEszgWiVsNK8X6TpOWlOXQhv8aYkA== X-Received: by 10.80.177.179 with SMTP id m48mr6056672edd.114.1508836889581; Tue, 24 Oct 2017 02:21:29 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n20sm978572edb.93.2017.10.24.02.21.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Oct 2017 02:21:28 -0700 (PDT) Date: Tue, 24 Oct 2017 11:21:17 +0200 From: Adrien Mazarguil To: Matan Azrad Cc: dev@dpdk.org Message-ID: <20171024092117.GY26782@6wind.com> References: <1508834730-30271-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508834730-30271-1-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix targetless internal rule creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 09:21:30 -0000 On Tue, Oct 24, 2017 at 08:45:30AM +0000, Matan Azrad wrote: > The corrupted code allowed to create internal rule with no any target queue > in case the rule creation ocured before queues creation. ocured => occurred > > For example, when user calls rte_eth_dev_default_mac_addr_set after probe > and before dev_configure, mlx4 failis because the RSS queue number was 0. failis => fails > > The fix prevents internal rules creation before queues creation based on > future creation before traffic start. > > Fixes: 7d8675956f57 ("net/mlx4: add RSS support outside flow API") Since adding MAC addresses before dev_configure() was not taken into account in the design of the affected function, I suggest appending: Fixes: bdcad2f4843a ("net/mlx4: refactor internal flow rules") > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil Thanks. -- Adrien Mazarguil 6WIND