DPDK patches and discussions
 help / color / mirror / Atom feed
From: luca.boccassi@gmail.com
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, wei.dai@intel.com, remy.horton@intel.com,
	thomas@monjalon.net, Luca Boccassi <bluca@debian.org>
Subject: [dpdk-dev] [PATCH v2 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code
Date: Tue, 24 Oct 2017 12:03:12 +0100	[thread overview]
Message-ID: <20171024110312.24029-2-luca.boccassi@gmail.com> (raw)
In-Reply-To: <20171024110312.24029-1-luca.boccassi@gmail.com>

From: Luca Boccassi <bluca@debian.org>

When VF reset will be supported by drivers, the API will most likely
have to return -EAGAIN to avoid blocking when the VF cannot be reset
because the PF is down.
Document it immediately even if it's not yet supported, so that users
and developers can already take into account about this use case, and
thus avoid an API-incompatible change later on.

This is based on real-world production usage and customer escalations,
using earlier patches from Intel.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 lib/librte_ether/rte_ethdev.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 697f6b2e0..2a0129a2a 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -2277,6 +2277,7 @@ void rte_eth_dev_close(uint16_t port_id);
  *   - (-EPERM) if not ran from the primary process.
  *   - (-EIO) if re-initialisation failed.
  *   - (-ENOMEM) if the reset failed due to OOM.
+ *   - (-EAGAIN) if the reset temporarily failed and should be retried later.
  */
 int rte_eth_dev_reset(uint16_t port_id);
 
-- 
2.11.0

  reply	other threads:[~2017-10-24 11:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19 13:48 [dpdk-dev] [PATCH 1/2] ethdev: document rte_eth_dev_reset return codes luca.boccassi
2017-10-19 13:48 ` [dpdk-dev] [PATCH 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code luca.boccassi
2017-10-19 14:53   ` Remy Horton
2017-10-19 16:14     ` Luca Boccassi
2017-10-24  6:18       ` Remy Horton
2017-10-24 12:01         ` Luca Boccassi
2017-10-23 22:11     ` Thomas Monjalon
2017-10-24 12:00       ` Luca Boccassi
2017-10-19 14:52 ` [dpdk-dev] [PATCH 1/2] ethdev: document rte_eth_dev_reset return codes Remy Horton
2017-10-24 11:03 ` [dpdk-dev] [PATCH v2 " luca.boccassi
2017-10-24 11:03   ` luca.boccassi [this message]
2017-10-24 12:29     ` [dpdk-dev] [PATCH v2 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code Thomas Monjalon
2017-10-24 12:27   ` [dpdk-dev] [PATCH v2 1/2] ethdev: document rte_eth_dev_reset return codes Thomas Monjalon
2017-10-24 13:19     ` Luca Boccassi
2017-10-24 13:19   ` [dpdk-dev] [PATCH v3 1/2] ethdev: document error codes of reset luca.boccassi
2017-10-24 13:19     ` [dpdk-dev] [PATCH v3 2/2] ethdev: document new error code for reset luca.boccassi
2017-10-24 20:41     ` [dpdk-dev] [PATCH v3 1/2] ethdev: document error codes of reset Ferruh Yigit
2017-10-25 12:01       ` Luca Boccassi
2017-10-25 16:08         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024110312.24029-2-luca.boccassi@gmail.com \
    --to=luca.boccassi@gmail.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=remy.horton@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wei.dai@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).