From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 37CD51B7BE for ; Tue, 24 Oct 2017 13:57:01 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id 15so6549854wrb.5 for ; Tue, 24 Oct 2017 04:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Uua/CL0LVTQ8FP9rCEvAj1lGNKsLVqq3lvNLrT/jYU4=; b=dy735pdTs9fpfviT2S5N4hmzIGzURnqePW6Epoj2BRyr03921SrHQaknFe86nqCq2m 5ugqXQaHoSSRHTkfrz5fy1soTmwhruByxKqdnpR+ZIAx+4w2WKmUPbtZ01H80YGBcHWr DuUR1sHZuTcH66dNiZ3iR4hkb/32E3vh5ZzQT2L/TP5tR2IaKmYe6MqBO44KoAftBQxo YtB9wQcuDZEwnWXYDClsDgXbcLD7pl2aSfXdviGiqKBMZiE/ZhvIrYlhNQcQaGFd41+H 17udvgoDDSpcFSjhvRPpWwn8zmyQQTfJFvlrekpPmBOm9vQcXHtCc7aGYZTwy/aDExI8 Yf6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Uua/CL0LVTQ8FP9rCEvAj1lGNKsLVqq3lvNLrT/jYU4=; b=Cc62l72+HilJziORTmlCvNeSXwvsuIyOtv0mpf+3QWwRvhs3ygtroRYA6ZBXdOquji RE2oF5L7Q1wMi8MWexjM+6ZwkfTb0Zo65gRyrTHqpG+TD05YdtqLp72TysdvSAKFzwjU GylldS1Ry3DxKzNQHPpqKb6BhE9Wvdn6fZ0hgrUqvLQ2ZvrzPyRV2kEE4aKDBM7P+3Rr YpisVUPabY/aeLAAyghIkpdBAeOBnAHArOqSXgv5Kn3nQnNdNl8xv1+cK1fquhNmmuR8 BnZEDlBOosHfA7UhStAmyR8bNDvwl2vnWw0YhB1LPKHXPCi2EcxwZi0Jan6x+RJ/jgo/ Nl7Q== X-Gm-Message-State: AMCzsaUcUIC886SyOmovaewaA1TVl6VU3BOj2YMPDdLU+vPybQHfiWFk ghgeWUfMkHOe8jpQGAiNEXh2 X-Google-Smtp-Source: ABhQp+QJYu0j3Hvup5lzB9uLVNrXXK9QQ2T7DOXmDKS5Dyd2nLo5vhzAJikcUi8bHOW+QAdBAwNPDg== X-Received: by 10.223.131.4 with SMTP id 4mr14952878wrd.106.1508846220908; Tue, 24 Oct 2017 04:57:00 -0700 (PDT) Received: from laranjeiro-vm (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v80sm118305wmv.37.2017.10.24.04.57.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 04:57:00 -0700 (PDT) From: "=?iso-8859-1?Q?N=E9lio?= Laranjeiro" X-Google-Original-From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Date: Tue, 24 Oct 2017 13:56:56 +0200 To: Moti Haimovsky Cc: adrien.mazarguil@6wind.com, dev@dpdk.org Message-ID: <20171024115656.lsq75jusgpb7h47k@laranjeiro-vm> References: <1503590050-196143-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1503590050-196143-1-git-send-email-motih@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 0/5] new mlx4 Tx datapath bypassing ibverbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 11:57:01 -0000 Hi Moti, Small comments/question to clarify the situation for any user of this series. On Thu, Aug 24, 2017 at 06:54:05PM +0300, Moti Haimovsky wrote: > This series of patches implements the mlx4-pmd with Tx data path that directly > access the device queues for transmitting packets, bypassing the ibverbs Tx > data path altogether. > Using this scheme allows the PMD to work with upstream rdma-core package > instead of the Mellanox OFED one without sacrificing Tx functionality. > > These patches should be applied in the order listed below as each depends on > its predecessor to work. > > This implementation allows rapid deployment of new features without the need to > update the underlying OFED. Seems this explanation is wrong, the PMD still relies on Verbs for control plane configuration and thus for new features it will still require an update of the underlying layers i.e RDMA-Core or MLNX_OFED >= 4.2 and the associated Linux Kernel Mellanox drivers. > This work depends on > http://dpdk.org/ml/archives/dev/2017-August/072281.html > [dpdk-dev] [PATCH v1 00/48] net/mlx4: trim and refactor entire PMD > by Adrien Mazarguil > > It had been built and tested using rdma-core-15-1 from > https://github.com/linux-rdma/rdma-core > and kernel-ml-4.12.0-1.el7.elrepo.x86_64 > > It had been built and tested using rdma-core-15-1 from > https://github.com/linux-rdma/rdma-core Seems this version (15-1) does not exists on this repository the latest being v15. Does this series compiles and work on this version, or should the user use some point above the v15? > and kernel-ml-4.12.0-1.el7.elrepo.x86_64 > > Moti Haimovsky (5): > net/mlx4: add simple Tx bypassing ibverbs > net/mlx4: support multi-segments Tx > net/mlx4: refine setting Tx completion flag > net/mlx4: add Tx checksum offloads > net/mlx4: add loopback Tx from VF > > drivers/net/mlx4/mlx4.c | 7 + > drivers/net/mlx4/mlx4.h | 2 + > drivers/net/mlx4/mlx4_ethdev.c | 6 + > drivers/net/mlx4/mlx4_prm.h | 249 ++++++++++++++++++++++ > drivers/net/mlx4/mlx4_rxtx.c | 456 +++++++++++++++++++++++++++++++++-------- > drivers/net/mlx4/mlx4_rxtx.h | 39 +++- > drivers/net/mlx4/mlx4_txq.c | 66 +++++- > mk/rte.app.mk | 2 +- > 8 files changed, 734 insertions(+), 93 deletions(-) > create mode 100644 drivers/net/mlx4/mlx4_prm.h > > -- > 1.8.3.1 Thanks, -- Nélio Laranjeiro 6WIND