From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id EB7761B823 for ; Tue, 24 Oct 2017 16:19:49 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id 78so13813844wmb.1 for ; Tue, 24 Oct 2017 07:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=SDKUdjYiW+J7xlilZFRqASlHjF7Vimw+cdbKPJ378m0=; b=CvLASYHzQ2wxH+e+au9F8EckF1OqyToHPKiwi+58YAbE9SXQVJnKRjuqeLFnWDcg+C alAUo7Kw9wo0LjekO1aEgJYkvEEBqj5LBbhmFzF78haS3fsJqGYnv7CPcxzUtHfQ1TFa tMvM6DS9y/u//3fd2qD9kAATwfuP5OjhDCjBytgqxwiEAPbguGJ4DP5xiXy6kCg9dQuC 46z0ctobKscoGyxj1LoP6doANGp9oM5GCuF2e/DlV9n/4mzrMtDIR1jRLbG+m0WB3aeX 1uy30KRkgDryG59WSk/67JBqxgphYKCp6zvqZAMFAFnTTupMavOE2RHrCP7sKC4F2sgd 2dkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=SDKUdjYiW+J7xlilZFRqASlHjF7Vimw+cdbKPJ378m0=; b=nigcB/ZApygJRuBNorqEhkGxMHRmGtiP7GwLvOsTk1ZwK/w+mvLdjVu0gtkEWZnJI2 SF7AsN5i33O3ArMKlIItsT7p/suEgV5dz7T6hhJ+8ME46ccgl4/nQD0AdNYkW6YhY92P fBeOV5PGIaSANrzA6PkHvb083Svo7aAC20P+iixmTyzXe92LO8umOA5PxG2Gul18AAjG m1dL+O0QfQrnl0HDf8zTPWNMZbde32/Zhsvvi6pjaWdrA3popQ+F0I/DL6r8bFfQIMPQ 9Nz2lunwAe6WYU2LgjSkI1dfwXhpqCAMBe5JxhCe/lDQ+6dMSWqJ8YcyIujSevx9pC0m DulQ== X-Gm-Message-State: AMCzsaV1pbWJwjnErjyhcIgsfRNnToaGilDNgw0FBfNBaSzWckuACxxy sRoC5ISXDFqzUd8dyTG2WZGMYMNd0w== X-Google-Smtp-Source: ABhQp+RgPGiglelel/QgLqovJPugYpjHUe/+ipbyUsoY1MwUwulUyHC0su1DlfV6lwUpLApd9l0DuA== X-Received: by 10.28.136.83 with SMTP id k80mr5016071wmd.133.1508854789627; Tue, 24 Oct 2017 07:19:49 -0700 (PDT) Received: from laranjeiro-vm (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p78sm472845wma.11.2017.10.24.07.19.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 07:19:49 -0700 (PDT) Date: Tue, 24 Oct 2017 16:19:45 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: dev@dpdk.org, Adrien Mazarguil Message-ID: <20171024141945.n5iaefh266pnchqz@laranjeiro-vm> References: <20171023192544.GA19386@yongseok-MBP.local> <20171024071142.3wsybjacfoa6i453@laranjeiro-vm> <20171024073434.5cbsrnzw7pjrjswm@laranjeiro-vm> <20171024134106.GA19843@yongseok-MBP.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171024134106.GA19843@yongseok-MBP.local> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: fix reception when VLAN is added X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 14:19:50 -0000 On Tue, Oct 24, 2017 at 06:41:07AM -0700, Yongseok Koh wrote: > On Tue, Oct 24, 2017 at 09:34:34AM +0200, Nélio Laranjeiro wrote: > > On Tue, Oct 24, 2017 at 09:11:42AM +0200, Nélio Laranjeiro wrote: > > > On Mon, Oct 23, 2017 at 12:25:45PM -0700, Yongseok Koh wrote: > > > > On Mon, Oct 23, 2017 at 04:49:56PM +0200, Nelio Laranjeiro wrote: > > > > > @@ -261,75 +284,59 @@ priv_dev_traffic_enable(struct priv *priv, struct rte_eth_dev *dev) > [...] > > I've wrongly read your last comment, the patch is correct, it won't add > > multiple time the broadcast multicast, it will add one per expected > > VLAN. > > > > Example: > > > > testpmd> set promisc all off > > testpmd> set allmulti all off > > testpmd> rx_vlan add 0 1330 > > testpmd> rx_vlan add 0 1331 > > > > Will cause this code to add a broadcast flow with VLAN TCI 1330 and > > another broadcast flow with VLAN TCI 1331, others won't be received. > > > > The user will only receive broadcast packets with VLAN TCI 1330 and > > 1331. It is what he expects. > > What I meant was, if there are multiple MAC addresses on a port, the bcast/mcast > flows will be repeated. For example, if there are 3 valid addrs in > dev->data->mac_addrs > > testpmd> mac_addr add 0 > testpmd> mac_addr add 0 > testpmd> mac_addr add 0 > > and 2 vlan filters are configured like your example above, then 6 ucast flows > (2 per an addr) will be added along with 6 bcast flows and 6 mcast flows. But it > only needs 2 bcast flows and 2 mcast flows - one per vlan. Right, I missed this case. I'll fix it in a v3. Thanks, -- Nélio Laranjeiro 6WIND