From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 9A0F51B820 for ; Tue, 24 Oct 2017 16:44:31 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id b189so16107826wmd.4 for ; Tue, 24 Oct 2017 07:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=llaK5y9G1bYvarDbdbEkTzc22vZHYwfy7z1yTN22sM4=; b=fykpSGr6iLnwzqPQ//4yJfRLFh72EgBpIGrAiuUuj5UAYn9cwBLRFqr+l6Zz5RyA5B dB+Qqo8ujYcyMfpg7MVElI0o12/DxpUh90tYqlAkTdyQpb4c+wkxYbYh07GL3+1/5O6R mUrOk73lqi7l/GZptVv0yRI0LkVxS+9v185n9SFbSCR+TnFwfHgurwWcZv7icXyZ3TCC a7NPuXihKoQB0dPN36Gmq/hq4jiPBBspcJZp/Xpcl1oikfHBypLjwSFuLJo8QtIq1EIf B1k5KkGWF2FAMm9jrtb3UYUaoETlplgkxwg9KICEg5/oSn4vHGkAUYLSiqahB3nuz0HT nyIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=llaK5y9G1bYvarDbdbEkTzc22vZHYwfy7z1yTN22sM4=; b=aiGkKW9RW/FlCGWqnWyHlD63vHogLi7nRk8av7mJii+JEum8tYhyR/h1/1kfeDZ35q QEvJ4VVjjm+yhTLqsp9SR1A2pp1msTBiLD2VY+xsVOIqgWsc/JKI6D4u5LDAF2hWVGvq IBzdSao7ZtXTUDgmDuq96xO35wcgXG3WuyCjIPjJWlSEGy74ZczEW4HTO8Apvl1uEp5e ijXg9hOI8TKd9mOxn/gltmiboORsCRQSdP+ciit5tFmdNd0HgRRPFhtHooFDToO+x8Tp xCS5DPmtE9mWefgO1ll3h/p1DvFD06woWpXzG8zm/v28YKeewniBikmLiSgJb/h1e2e/ SK8Q== X-Gm-Message-State: AMCzsaVxMXB4m5EGoNdS8e51/l0bwSpiUYhOGj8u9VfOz6GO9H8CNmaH F+CTPj/PWUo1Xy9SNG8YOgCl2Awp X-Google-Smtp-Source: ABhQp+S3OKYKp4CYrrRsJgc+ExbOZdHiS/M1LX6dka1qQxWp+rK51IN+tXLdpi2KxkDXdjeumeVBHA== X-Received: by 10.28.109.220 with SMTP id b89mr8880771wmi.30.1508856271327; Tue, 24 Oct 2017 07:44:31 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x185sm433849wmx.35.2017.10.24.07.44.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Oct 2017 07:44:30 -0700 (PDT) Date: Tue, 24 Oct 2017 16:44:19 +0200 From: Adrien Mazarguil To: Moti Haimovsky Cc: dev@dpdk.org Message-ID: <20171024144419.GC26782@6wind.com> References: <1508848533-180885-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508848533-180885-1-git-send-email-motih@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v1] net/mlx4: fix missing initializers for old GCC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 14:44:31 -0000 On Tue, Oct 24, 2017 at 03:35:33PM +0300, Moti Haimovsky wrote: > This patch works around compilation issues seen on RHEL 7.2 > using GCC 4.8.5: > > [...] In function 'mlx4_rss_init': > [...]/mlx4_rxq.c:433:19: error: 'wq_num' may be used uninitialized > in this function [-Werror=maybe-uninitialized] > > Fixes: ff3397e90080 ("net/mlx4: relax Rx queue configuration order") > > Signed-off-by: Moti Haimovsky > --- > drivers/net/mlx4/mlx4_rxq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c > index fb28290..4c50077 100644 > --- a/drivers/net/mlx4/mlx4_rxq.c > +++ b/drivers/net/mlx4/mlx4_rxq.c > @@ -417,6 +417,8 @@ void mlx4_rss_detach(struct mlx4_rss *rss) > if (wq) { > wq_num = wq->wq_num; > claim_zero(ibv_destroy_wq(wq)); > + } else { > + wq_num = 0; /* Shut up GCC 4.8 warnings. */ Wait, there's an indentation issue here, please remove unnecessary extra space before "wq_num". > } > claim_zero(ibv_destroy_cq(cq)); > if (!wq) { > -- > 1.8.3.1 > -- Adrien Mazarguil 6WIND