From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 529501B868 for ; Tue, 24 Oct 2017 23:20:06 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.224.233]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 232C430C057; Tue, 24 Oct 2017 14:20:05 -0700 (PDT) Received: from C02PT1RBG8WP.vpn.broadcom.net (unknown [10.10.118.158]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 93CC281EAE; Tue, 24 Oct 2017 14:20:04 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Tue, 24 Oct 2017 16:19:47 -0500 Message-Id: <20171024211953.12021-10-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.13.5 (Apple Git-94) In-Reply-To: <20171024211953.12021-1-ajit.khaparde@broadcom.com> References: <7b5c8ca8-7523-add0-0cca-826278496a19@intel.com> <20171024211953.12021-1-ajit.khaparde@broadcom.com> Subject: [dpdk-dev] [PATCH v2 09/15] net/bnxt: fix an issue reported by Coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 21:20:07 -0000 Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support") Coverity issue: 195015 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 9065a12df..c2d54efd8 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2039,6 +2039,11 @@ bnxt_cfg_ntuple_filter(struct bnxt *bp, goto free_filter; STAILQ_INSERT_TAIL(&vnic->filter, bfilter, next); } else { + if (mfilter == NULL) { + /* This should not happen. But for Coverity! */ + ret = -ENOENT; + goto free_filter; + } ret = bnxt_hwrm_clear_ntuple_filter(bp, mfilter); STAILQ_REMOVE(&vnic->filter, mfilter, bnxt_filter_info, -- 2.13.5 (Apple Git-94)