From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0081.outbound.protection.outlook.com [104.47.32.81]) by dpdk.org (Postfix) with ESMTP id 74D791B93C for ; Wed, 25 Oct 2017 12:24:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JnOl8BA/6xlCAu4yuCXuM7Rvk6tNB7GqtaeK3XN2I2Q=; b=MowU5Sre4aOzLrLnfV3YrgO9StNfMio1pkeibcCxz1dw1mkoQHdhQl8UlDWRuzVD6xnZeAuQku3qg1DPRUKxv6YRPSWT1NTqImmL30vA6a7xhPjvtw8JQNb0uJAgoXx5M9HlEQAuhz0hfDJLifibLmNPIR9ZmslcEAxMp7ZNnC8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from PBHAGAVATULA-LT (111.93.218.67) by DM5PR07MB3466.namprd07.prod.outlook.com (10.164.153.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Wed, 25 Oct 2017 10:24:53 +0000 Date: Wed, 25 Oct 2017 15:54:46 +0530 From: Pavan Nikhilesh Bhagavatula To: "Van Haaren, Harry" Cc: dev@dpdk.org Message-ID: <20171025102445.GB29948@PBHAGAVATULA-LT> References: <1508779012-56186-1-git-send-email-harry.van.haaren@intel.com> <1508779012-56186-3-git-send-email-harry.van.haaren@intel.com> <20171024172439.GA18820@PBHAGAVATULA-LT> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MWHPR1301CA0022.namprd13.prod.outlook.com (10.174.164.163) To DM5PR07MB3466.namprd07.prod.outlook.com (10.164.153.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d05e19cf-d22a-4182-0d67-08d51b92a285 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:DM5PR07MB3466; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 3:3TbwJvMKN1cg7U7H2mlEkIu20z9TBXFJh9HdQES+1w9wqTUJwIGiyTgFx9wnlCJUEmvsSvIqpMQPuy2Dr2tk8SLfk3+49uv3Fc4L5oOQbYqg1bf2PERkrfpFXzecn1JfO8RWpEYiYkywS9ozkz0fu14rXX8qtp87PZAjodpIMrvfrKsD3Yee8WrVI3lx97maoApvNK66i9nrVky9cH4z5F6l8AuFTZ4Pcfj+rV7ZXcQ3G2lW1SHZtcGLUixxf+92; 25:IAuyUQ3NE9OdpxWDD6hu82NnqG9yYp53jtG9+gIZ1yJAozuKKB9H2iN6wkSo+4NauIz772l95HprJNPaSCNgHMklkZCkf42UvMCinB1x7yImGbNM0u99Vu/xkFy09m6ugmpTWMXiPSjaC3oSmEVWEreXFf5muFL+iJ3nV0b0t5uQuECyX3qWAAZR7ZZDPYFrhRl9ur+itt1ISQp3dUWQ8V/ekYhuCtDHcdUOvo9MMeRgLs0YHVCtCLavkKSDYGlqKTuFCokXvIW8I/Nc92pejJ5/RvY5ydGoLpiMqTFlEuQchB+94qIddzwVEeqPq+l76k5RT2Fgzp4n1pirNnXCwMtq6Dv5jyDOCn/unQPtQ8Y=; 31:m0zvDAO6XTumoIPW7t+bI8omtnhDsyvhNGuVI/G71vWIm/WwGpWqIjs6xz5M4SOTSIJ+nSl6urllHvTDB65+i0aiDBTvIK5SxqOm+dg4HkLRKDzP3U0NZh/4ZPJ0B8jcvnKzdCMse0QGFS3Y0E+2Z1So6Va1neEuUyyR74KJqu/vQa0RGOnugRo8mKsu3jLyF8AoHJL6+zsYTD1ixPrMj0R52BSW2Xyioc6/YLjVOAA= X-MS-TrafficTypeDiagnostic: DM5PR07MB3466: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 20:hhA3heJw/Zo0Zi34ITwz2unXPhtLbXj0kfkgTbAPBvKmig79VFRuYxjOXE9CRFDnX1iubgBOloRc0cYkp3ROR5Y/NNsCB42qILdFEjgCKK4V8qRLGM55x6PdWjtCNAp4ja3hs0V+6ONH7cNzyPUJ+xeV+X6fk8cOtwAYEd5VawZglyAnR1h+FIfUOoi/InHbYUms3wztNeUyBBroiMxcsv40tSMVZdoyA65ACuSx4xPMy9Tp3UA7SsXnVxAVaR2yT58Xr+jPFzs7RY0rpBlhigDRcjglm+RL0SI/UpZUcZzFWD7XV/nF96BPmBOpfkArRjYk+3V602tvc/q4aQJr57YZwHaScc4dJNYYsQgEmGxSEXx8klwmEU2cc0DPphLbymsSuoqrP7QC8ZAfLxZDRGwgYVovQSsTWSzPG3kaU7PIF7WBYZ2WcSJuHs68Oo2QYWLCMUhh9Vj/1xUHyW1MXaFPvOYWhBw3SdFK/EoesLUscU6DH9N5iY0+UALG1beH0klmGQn5YhPCP9U0SNCO7YsLtElNTaEPxfI3AgoP6mlJ/Qv/jqNTGgDOetv6mcdVQBuMeOlBL5dkTIJOsFAwWTJ7xEDV1McDKSaj4a9wdIc=; 4:reTisz8Xtf5WZO/q+HGrfK6op9oEhj9Vw6rK+gPl5DnTtDY6cjNIuHY0sytZQH3k8w2MiQgTQuHCYKh0M1Fn7Swd9cLSINkyyIw6cPeqFb4LPN9slGN92qf2KWZ1Rx1KCl03TLfO47vr+YxlfPjz+poS4MbRVcLvYEAQsf/YRxg2xCniBJ6BOTRHmsiyfDYqB2D2+bJn4Wee8mQrpnuKk3uj38/VySnigQFPSXQgCNlcUz9iQ0K/FjVzsmODXyOaBU3ReHREBT/mb57RP8bCwqeLriYWJh9BlYf38FkYm+ReCwoQlMi+srqYerGC8pzP X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(3231020)(10201501046)(100000703101)(100105400095)(93006095)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3466; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3466; X-Forefront-PRVS: 0471B73328 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(199003)(24454002)(189002)(9686003)(6116002)(55016002)(3846002)(53936002)(81156014)(33716001)(6666003)(97736004)(5660300001)(5009440100003)(58126008)(53546010)(6246003)(6496005)(6916009)(16586007)(2950100002)(42882006)(106356001)(105586002)(76176999)(54356999)(16526018)(66066001)(23726003)(316002)(47776003)(478600001)(189998001)(93886005)(101416001)(50986999)(1076002)(81166006)(25786009)(68736007)(33656002)(7736002)(83506002)(8936002)(305945005)(72206003)(8676002)(4326008)(50466002)(2906002)(229853002)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3466; H:PBHAGAVATULA-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3466; 23:Woygs20ny/CjazV4i/RdJp8MrTG/RuQAu0ycmAXMz?= =?us-ascii?Q?fN2HKNU7re4pQQ62JkURTXjzjaV0e0t5EJogGuE+iN46A1fKIpG0+hoJlps+?= =?us-ascii?Q?XanTuDKKoY3FR9amX0r3jEeRPhMclU8dVFfYWtEB35kJAWWp16IEC3fTL6XE?= =?us-ascii?Q?Jk8nRdq4gHlRO/Gtb3uRvSrQ8SUIxShdCrGw/D0wkdWz5Ct8LEhX6vBw1QL3?= =?us-ascii?Q?ydNN0QOmfMxRSI432Sd3aaawmgc9HQCj9oRPHEzumduOGneoF09RR7co0i6O?= =?us-ascii?Q?PbkjHQz4Ml0pOijw9YsSnxws/TQFusdcFao4KKsGnuoLDJlYq86Ms8TM1os3?= =?us-ascii?Q?vc6kRMStFAelsJYO7w2FNazZcUO8vcjdn9isdAQkl/bnd9wEsgffAVjxBExu?= =?us-ascii?Q?zZybADrMl0GxPtbyKqZYz+IMPRS5vngBQx/TOglsalRK9tN8VfAomt8kY67G?= =?us-ascii?Q?mViP3YFHh2p2xYnq0eEUpmMaYKYgCHJY7G1Y3RKTb7D/6MAqhswXef40xgXc?= =?us-ascii?Q?iOrkkt2WSnYuMAUI8Msyt0bDJZPBnABj6O797FC8N6ZTWHlaUxIXfJfWZlxG?= =?us-ascii?Q?GSzMCUShLKQHGCgoV33KZpyEnIlf3YTZfD1DHe3c9jkTTZk9Mp6D2pIP8WD4?= =?us-ascii?Q?w+sgzkZfJCUtZ2L6PPZYXxMmlx0mdgXH3xPW0Hyya3xjuKawMB2M83xhS80/?= =?us-ascii?Q?axRnikQ/wObf2T1WZ+2f+NUPS2fevcJpWfM++2q0vCKaCfe3gfhgfRuodivF?= =?us-ascii?Q?j2Aw7lnKJ2/WUMfcI9xlbO4omRJQjEaEeJtR338O5qzjAz7ppzkeVI6qEPs9?= =?us-ascii?Q?ejOGzLymya34Mo1sNXvyK3cGxjATwHj5+X1cWO1zDRchbpi0ODzsMLrrWr3g?= =?us-ascii?Q?XucgMa/xlctPMbpabU9IK2Z1LAqDxJP0LfS7CcSNzRtN4mtLuPnuKUgF1aKI?= =?us-ascii?Q?fkrPhWod53l98QXI5pjGzbNr5naZmwA8AQdlBnE0zbldRTRVutgH+/1b5drB?= =?us-ascii?Q?gXqroA2yf9BdfGF+6dcfsFRVp9H+cZL0SJSfORUZt3l8EAgv2XODo0hqtXuE?= =?us-ascii?Q?TN7eXxAOKdeTk0ExmRNKXVw0MAoc5f6rEbKlwOxDsZ1A3rPPLQ0q+TJyd7zS?= =?us-ascii?Q?d41DBDDAYgZA51+2TAJD/TPwXbknteMC5LGwD1LVaE9C+y4i22mrKdGNEuTi?= =?us-ascii?Q?VpqNX+l7g/fZYYeE1L37SEjxQLWA0Wp95oUh0x87EvHr+8liU2qmJILHTM7v?= =?us-ascii?Q?XT/ra0wSfxr/mylo/TNTR5bvzSpd+93Yj3ujSIvo2ag7IeFjuy594xr4vSu/?= =?us-ascii?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 6:TK7ZTGRPKXIx11MoXf2MDjx8SgIP7JTsFnDYmSDdSGjsqBPLIp4yZJshxJ5noIkOctUziiznM47Y4KFXDhkVg+gz5L242k98HTFe1A5fNnBkk0X7HezYvlar3W6E+HQ+cFtyhDYaW5wOMLWqqX52Stplo+Wz+ydkSBjCbX1TavwlBcH8QhMXzF+QFFF+MU1ONK3yLrtWkrk94iXEOa/hgxWnRWhVJkfcg32qSn579PLdo0tYvl/w9GAcCt8oDpl7hqFoxpH6ZxJRvmPqUuClsDD1zXX9cep3HZMM0XJ7unx4KCu9s8Lj1/Tv71WOI6uOHTpEz9VjUADdwT8LHXBi6xPXGaXOW3CDiQ1RssQD+Os=; 5:QPShcZnPwL/TE+FQMcVWbfoPMAwffzPuqTB+QmGOhpKpA6xz2eZo3/uSHhWGRPmoNdU0zoatTAE4Q1zhGF7G2GEqsCfKZhnwD5ienCuTQqVTMMtVxbuBTTJY8YlkwCHjIUghiecnZONiWFe6bN8i/lilPW+vnEn35hSSmyVQHMw=; 24:6ijKaCfWfNtUWJ/3MOjs4qu3n7ujAyQbu9wBgGfIvFXfDkQU5CWhskETvw6mX9XRZQ2o3fuBnk9v+vGLPysVIgf5AbwskCVLwoIb9904wFg=; 7:KzVkPbFnf4Wo3uxo25nb4izd/0IHGoNPPvRlIAeZ4qf/2EpO8cpbOX8Yq9xk7KXDOQZD2csVntYJGOu0ghmb3fEpHodbNHZUWW5Ramlgk9ubWVPSBGjy9bT6m5P7RTofx8MLD8gVSP+z52cbNEUeVyit8J8x1MWvqlJXm9hOt7wpTq3TAQUm1nWiLszI6hcDOSBpxJTX5uD5gJUG+OIBW/wFsF1oGPWyYCZsncn67Bgn8nXNyFpMr/TOVkhWdhK+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2017 10:24:53.8059 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d05e19cf-d22a-4182-0d67-08d51b92a285 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3466 Subject: Re: [dpdk-dev] [PATCH 2/2] service: add runtime service core check disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 10:24:56 -0000 On Wed, Oct 25, 2017 at 09:09:53AM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Tuesday, October 24, 2017 6:25 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org > > Subject: Re: [PATCH 2/2] service: add runtime service core check disable > > > > On Mon, Oct 23, 2017 at 06:16:52PM +0100, Harry van Haaren wrote: > > > This commit adds a new function to disable the runtime mapped > > > service-cores check. This allows an application to take responsibility > > > of running unmapped services. > > > > > > This feature is useful in cases like unit tests, where the application > > > code (or unit test in this case) requires accurate control over when > > > the service function is called to ensure correct behaviour, and when > > > an application has an advanced use-case and wishes to manage services > > > manually. > > > > > > > Hey Harry, > > > > The patch looks good from a logical point of view, I have integrated this > > with > > 4/7 and 5/7 of the patch set [1] for removing eventdev schedule API and > > everything > > works well. > > > > My only concern is that the function name is a bit tricky to grasp. Unless > > the > > application(dev) knows the internal working of rte_service_runstate_get() it > > would be a bit tricky to understand the role of > > rte_service_set_runstate_mapped_check(). > > > > I think we should think of a more appropriate API name for this function. > > > Suggestions welcome! > > Otherwise I hope the documentation and unit-test usages explain the functionality ok. > > Cheers, -Harry > I think the documentation would be sufficient as I don't have a better suggestion for the function name. -Pavan > > > > Signed-off-by: Harry van Haaren > > > --- > > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > > lib/librte_eal/common/include/rte_service.h | 23 > > ++++++++++++++++++++++- > > > lib/librte_eal/common/rte_service.c | 22 > > ++++++++++++++++++++-- > > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > > > 4 files changed, 44 insertions(+), 3 deletions(-) > > > > > + * @param enabled When zero, the check is disabled. Non-zero enables the > > check. > > > + * > > > + * @retval 0 Success > > > + * @retval -EINVAL Invalid service ID > > > + */ > > > +int32_t rte_service_set_runstate_mapped_check(uint32_t id, int32_t > > enabled); > > > + > > s/enabled/enable > > > +/** > > > + * @warning > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > + * > > > * This function runs a service callback from a non-service lcore > > context. > > > * The *id* of the service to be run is passed in, and the service- > > callback > > > * is executed on the calling lcore immediately if possible. If the > > service is > > > > > > > > -- > > > 2.7.4 > > > > > > > Regards, > > Pavan Acked-by: Pavan Nikhilesh