From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Pavan.Bhagavatula@cavium.com> Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0051.outbound.protection.outlook.com [104.47.42.51]) by dpdk.org (Postfix) with ESMTP id D5E491B891 for <dev@dpdk.org>; Wed, 25 Oct 2017 15:58:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1lx724hSBuQjpDFUK1diqg9GAAtGJfPytFzW/uvyhfI=; b=DE1+4kb41raXQbuOZx/anAJ4X32KXSg7ba8KtNQ6bX/bmNQk1fgBpzQu7LV6T9PukYThuJkHXhJ/Moxl8DFnmteVJfYVVr2q6wYVHUUaeufVLnjJ5K2i+JRvAP1M9KrodsFPxH5P+ceDjl+zFOMOYk73qLqg+OTKtVrkaTAXQiw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from PBHAGAVATULA-LT (111.93.218.67) by BN6PR07MB3457.namprd07.prod.outlook.com (10.161.153.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Wed, 25 Oct 2017 13:58:27 +0000 Date: Wed, 25 Oct 2017 19:28:17 +0530 From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com> To: "Van Haaren, Harry" <harry.van.haaren@intel.com> Cc: dev@dpdk.org Message-ID: <20171025135816.GA21894@PBHAGAVATULA-LT> References: <1507814147-8223-1-git-send-email-pbhagavatula@caviumnetworks.com> <1508780456-27837-1-git-send-email-pbhagavatula@caviumnetworks.com> <1508780456-27837-2-git-send-email-pbhagavatula@caviumnetworks.com> <E923DB57A917B54B9182A2E928D00FA650FCBAD6@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FCBAD6@IRSMSX102.ger.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BN6PR1301CA0020.namprd13.prod.outlook.com (10.174.84.161) To BN6PR07MB3457.namprd07.prod.outlook.com (10.161.153.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23e609ba-9ca7-4bec-9f14-08d51bb0784c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:BN6PR07MB3457; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 3:n1ybnJNNnoGilepIqbI9k2LpjwEwx8jzAEok+WrJqRdsjO1MvP4FoYCWyIwNtqSWyOqCOZG88NVCxYqn3Byq9JUrgcrzdiy0L+HRMJ8bG64sslQzf0Y747AqfQC3vbPUvbOYrvmLfcrWfRtmdTvEooVbzhdRB8u4+khhp8IVyfz83bA9XSvuzzFoWjpm5Z3ShIdoEIMF4jNvUnrjZvcGgMnKZBlfVSqvyQWxPjN5VjDyLPJuXLwiFIwB4NM4AMJ1; 25:UKYmkLMOfo5C4zfglIOrWVgX1rD+jRydc1U64L4L3qc8W13OoWbqUPbnOVKGf0TSW2LJ6OhsQ6zQ9Zi/QO4qK5LFHMk/KeLlUbvHrJKZ4dJHevMLWXf/caF1STXBm3Cd17Gcm6jIdPiUV44yFh5BwWDINqvkwGsZgXqFbr2EzPLnfAt7yGbMFlh9QCFlHxx/d2DZ4gVHQi7LuTWrWGLAhauNa7urEiaq2Ub6BFd7UOS/ZJ77E4Cd1b10oQhiVra7z+iYJwg+QPNVfkY68Fbl8gIlCAnY8VmznWpaEf/a82q5Es8xcKeXO4sPnUUxuT1AspI2YEuuFYEqdOOX9r07Iw==; 31:yGVmR5EtyE/A+8cOtk3Ngrx3hytUce7jhchsMfvRP1Zp7pHGbfHtKh8bU5Dj6S0RyLGIM0ed2owHRGFdgGeXjEbqZGEdetUVLOtf6b/hm24HAB1ZQqb3JwUfugYt1KRCOzMpyz6l/uOmI5RgZrNbTryQckx/zWU6plD1ACilEF2FWPUKzJQ2ZoQ7LlwrK7wjKgEhVwSWvglJBXNE1Ant1PhmOn6Ixi1DyfFfnx9EWD4= X-MS-TrafficTypeDiagnostic: BN6PR07MB3457: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 20:t0eRfFzmIJVOQxZcxX/qIJ1pWrSy6YX2eQUcCRyda7+qnz0zvX8RzvIfYHpn4Jd85flwO+IGoS5SLcznEQvpuUwT4LuCnUsVtIHwqPuzRFS5YCb+w1pCVXIPyGFICgqNjleMIRdU9/CwviolMte5RtEyDneiU0AWzP/GyAPvA8ymGegGGTNJ2RXKf63KP9nUqbBGZDMkjmjJmgzygcRfVP90ss0jxJVe/uKdEgUzLrRR7PYCglrxCJUM7VriFIlC9FsFOObXWKWasi0oxT3JmxdhvFA575Sjway/tkkizsfQIIUA9Q0scRyn8qoQxN+n5ACv3CsU1Z7DtKdheqS+fqW+SZcNdW5BDuukpyndoteJHnHE3w6GKxXCSQxhD0T4wc6P6ffLmSXIM6wvjMrHRE4gUmvsiU1QD2iMFVlCbLRl/kZO2QWTjIRXSANmTymn0TTB2PxA/am3h29yNr9uswMCyVu4CdtWxu4aoMSaVNvRYsCj/3IY75eSv076YecumJ8TusYLCc9fZUTMYKGX7YOn89q1kVVYK8YEZea87Jxr+aC28TYco6cairj9UwNzipC0NC0whmv8SjguaH4hdTDwBV0A5TGyQBAAklE9Wfc= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: <BN6PR07MB3457132559B35FE4F2C3341780440@BN6PR07MB3457.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(100000703101)(100105400095)(3231020)(3002001)(10201501046)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3457; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3457; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 4:r8iRsijr5KtwZAhlsLh0a6JLdiEoK6e1DFNxoxhnpwo3irhJscUjlE5U5gzsFJfUkGwAFCAeYzHKUPKtRwy1pze5B/O+g/+w4ZVe3DFv6qeiINnWEoBBffxlzRjI6mkbSLyqQBswV+iJohITSwMWco1pCSOiJnd3Dkjt1BNnyfz4R5/nn8miE2W7+hk2cK38MWjtLByie8M4/mvzIDPZKKUutYmY2I3ev+0IB856PfGefGFPjN8k0XGlTQqLI+266LY3C6BRdlgrfqXnpIJPZG+XTV/q8UboZmUs7mV4a+ODfii+FEJLGHABQPiGQvwNkdtHOFNTu8SWqFKtQKhAVg== X-Forefront-PRVS: 0471B73328 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(24454002)(189002)(53936002)(6116002)(3846002)(105586002)(23726003)(2906002)(106356001)(68736007)(25786009)(53546010)(16526018)(7736002)(5660300001)(189998001)(33716001)(4326008)(9686003)(305945005)(50466002)(33656002)(316002)(6246003)(66066001)(6916009)(101416001)(8676002)(81166006)(58126008)(83506002)(97736004)(1076002)(5009440100003)(16586007)(55016002)(93886005)(229853002)(47776003)(6666003)(76176999)(8936002)(6496005)(50986999)(478600001)(54356999)(81156014)(42882006)(72206003)(2950100002)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3457; H:PBHAGAVATULA-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3457; 23:yTIBegwmjPXaUPpZKwAE7RTloEkHqRepvSLOpQtbO?= =?us-ascii?Q?1o4FyJHHFEQrGCFZ3UxRnYmfCMZY8jciyY6Idlk3gDSwsgybFm1OOGOkd+lI?= =?us-ascii?Q?y2hDTCkw/CM7md3lViA2OvZ6n0zR4prj50dm3VJCcSIeQ6JbJ2F9JJhGxTox?= =?us-ascii?Q?WZZHziMQ036rbaS7RPdNKL3P3jGV5UGBKwxJTlrBnhqf/BqjPZ6QvzCmyS9Y?= =?us-ascii?Q?I79Zk4MyT8SGafDcxttiqIeoZiLM92NNQY/8UPCv2CYydaVkHhS/WA+0Cnm2?= =?us-ascii?Q?+cRjB7I/SdL6OUA5aHBIbK/iHS+DK+fz8ySAXcn+GVxpKxlCFsyOBJcjbple?= =?us-ascii?Q?ENaQD4BZ13ljqzxxWKpOwLNQwIc7C8hF0w+61IuEAG8Dxd6DarcpQ+i+7Oyg?= =?us-ascii?Q?CdHNC/XwVTct3y5TtfUZSCtShpxkhsFfsCDqV/jq2YsHOvVVlhU3YbsSo7vh?= =?us-ascii?Q?WBJ1RZchqo8E5rQav/A6LTrThLt0szsaxVQUV0j1/7J8qtkC1dNW1fNsKRkI?= =?us-ascii?Q?qQuBVMTj9BAhbfTBWsrW6DfHHQVJG9Y8XYAAn9Tp1oxt9XYG+zZF8fpU8POS?= =?us-ascii?Q?3t0If9yqNLJLy/epCnvy/f3mQ7QiOoLLY+x6CfbGM3o9+Hef8IdRGan9EjOb?= =?us-ascii?Q?SlWL50mOQ+WYXCZWHZItWqsT5vyghD/quSLGxQyi0Mdf/sPTzPnVf9MVCVJN?= =?us-ascii?Q?76OlJ7T9snFT2sYufVg5fuQMFZIID3DqHH3EMB4ivrE6/Sz1cB3o4x7BNC5s?= =?us-ascii?Q?WuqUc71q4+PxFOIZckbiQ+jjMWpRwaJSSSJMkqBWL6p3hh13Kk4Ng+R2eEaa?= =?us-ascii?Q?U4AH6eN40IlMDrOrSAJE+8ZqPRrqVcYPzw0KHvbZsiwPcvQ07qUYZq5SepSd?= =?us-ascii?Q?B9Lp6KIsxp3x7Qvcbni9bEHzYT3wN6nCmahLYXIp6cW7ttSXTMx/uiLmcBUa?= =?us-ascii?Q?slmEr+OLjRBncI4ZE37fDKmsEE3Ciwbv3jULfv63dR6HRve6a9Ey2S5Ob6zA?= =?us-ascii?Q?VjmKIb734krWIQ7wFV198yUMWMpt+jPuIJhwmPt/1taF/zb3mzWBSzrfL6uD?= =?us-ascii?Q?dJrLePWzTuJSgOyV4TpfmJX66R0ODtG0bk8rnaEXKDm82F8rw81GfD4+ncPO?= =?us-ascii?Q?taY5fFABEsr1rt0GX/iej0lgq7FvmSThI04OIIARocg3NvHCBIv2zHH53RNj?= =?us-ascii?Q?X+XI8/6QqcyllePQ0HDhhApk5QcL0xwVe6AIVmkFcw1/Oh/as+Zo5K3dzLWP?= =?us-ascii?Q?hhVjP2bMVI9x4wLrYtzMZH1AuP66vY8Dko12JYFATMCr2zMdd+d4R+GI0Gk8?= =?us-ascii?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 6:vjrcKAGJfhjx3fo4rKW0EMXIv9nnQfSr0C4vB8d3zpPvRO7GW7vm5lxzhXJhbq1dhAFQ+PhVRtCC7aur8zFLVgDfq6CYd7KHvRuI4Z78Tt/sw48hT+o5ZQigVcsAEKsP1aon/mZ+/cAGGwpb0mLqOgb303B2H4IFMK9buvmEEWvx8SkuwZsvcFSbJ2NqnQzQ6Cz4LDKvibmq4b22XCYcsAfCU6kBmstETe5fc7cew2sEv+K4DeFH+4gA5J7ESOVWdT84mmTGvXrXzHAiygORmkkoua+Ly8JfoNgS/sKDZ+xn4XGDeiNg6m4UGsJ4AbtSkfZJ7tb1EYceJu4gYkL8xw==; 5:inoBFQpx6ydvV3VcyuSkkiosmsnzlkQdasZdyBokWQ/ExY4jrWahsSrWLuGcnEAv/ewWTRp3Y6Ivwe/m0dSYkPRTO+sti1sTCKkQwgmn5UANhogSoxXaFhCJgSAxBIIJDa+s8p+Eu1X96JHUWOKD1w==; 24:CEE7a1Nivt4YHOAKKkivDyDpGpfckLWKBRLMYPXVjTh60xajX7r28JtSzEtfe2eSfU+p7LrvKGX9nWdMFObt86Hdi4d4a7+GPhjaatsYxFI=; 7:h271Z9Hw20CW6mkbwr1h8UhffvhGgy8Mmp0qQpWT0xMokU9pm85W+ytsAck/E7/fujpKn5swkqQAr5/SpBV4fdYxhOEKKQ/sgKDEPFxuCZ60+Yv7PICVh0XbVuwai7Ysrzrlcd0KvtS95OZZhWbNv+6RCol6EY2hStxy65+plVkJ5RXm0G6CTWSABZz5qiU5rnFzNUUlrrQDE71+78MXkYa3q/3w8P2KSTVOC91HMck= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2017 13:58:27.6930 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23e609ba-9ca7-4bec-9f14-08d51bb0784c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3457 Subject: Re: [dpdk-dev] [PATCH v3 2/3] eventdev: extend queue attribute get function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 25 Oct 2017 13:58:31 -0000 On Wed, Oct 25, 2017 at 01:43:08PM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Monday, October 23, 2017 6:41 PM > > To: Van Haaren, Harry <harry.van.haaren@intel.com>; hemant.agrawal@nxp.com; > > jerin.jacob@caviumnetworks.com > > Cc: dev@dpdk.org; Pavan Bhagavatula <pbhagavatula@caviumnetworks.com> > > Subject: [dpdk-dev] [PATCH v3 2/3] eventdev: extend queue attribute get > > function > > > > From: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com> > > > > Add schedule type queue attribute so that it can be queried along with > > the queue config structure. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> > > --- > > > > v2 changes: > > - return EOVERFLOW when schedule_type is requested and event_queue_cfg is > > set > > to *ALL_TYPES*. > > > > lib/librte_eventdev/rte_eventdev.c | 6 ++++++ > > lib/librte_eventdev/rte_eventdev.h | 7 +++++++ > > 2 files changed, 13 insertions(+) > > > > diff --git a/lib/librte_eventdev/rte_eventdev.c > > b/lib/librte_eventdev/rte_eventdev.c > > index db96552..fa18422 100644 > > --- a/lib/librte_eventdev/rte_eventdev.c > > +++ b/lib/librte_eventdev/rte_eventdev.c > > @@ -809,6 +809,12 @@ rte_event_queue_attr_get(uint8_t dev_id, uint8_t > > queue_id, uint32_t attr_id, > > case RTE_EVENT_QUEUE_ATTR_EVENT_QUEUE_CFG: > > *attr_value = conf->event_queue_cfg; > > break; > > + case RTE_EVENT_QUEUE_ATTR_SCHEDULE_TYPE: > > + if (conf->event_queue_cfg == RTE_EVENT_QUEUE_CFG_ALL_TYPES) > > + return -EOVERFLOW; > > I think event_queue_cfg is a bit-set right? The == on this line above is a bug in that case, should be & > Good catch, will send out a v4. > <snip> > > With above comments; > > Acked-by: Harry van Haaren <harry.van.haaren@intel.com> Thanks, Pavan