* [dpdk-dev] [PATCH] net/bnxt: donot set hash type unnecessarily
@ 2017-10-27 2:30 Ajit Khaparde
2017-10-31 0:32 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Ajit Khaparde @ 2017-10-27 2:30 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
We are wrongly "OR-ing" the vnic->hash_type instead of assigning
the new hash type thereby wrongly configuring hash settings.
Fixing it.
Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index 67d9bfe9d..c4da474e9 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -206,7 +206,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
for (i = 0; i < bp->nr_vnics; i++) {
STAILQ_FOREACH(vnic, &bp->ff_pool[i], next) {
- vnic->hash_type |= hash_type;
+ vnic->hash_type = hash_type;
/*
* Use the supplied key if the key length is
--
2.13.5 (Apple Git-94)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: donot set hash type unnecessarily
2017-10-27 2:30 [dpdk-dev] [PATCH] net/bnxt: donot set hash type unnecessarily Ajit Khaparde
@ 2017-10-31 0:32 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-10-31 0:32 UTC (permalink / raw)
To: Ajit Khaparde, dev
On 10/26/2017 7:30 PM, Ajit Khaparde wrote:
> We are wrongly "OR-ing" the vnic->hash_type instead of assigning
> the new hash type thereby wrongly configuring hash settings.
> Fixing it.
>
> Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration")
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-31 0:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27 2:30 [dpdk-dev] [PATCH] net/bnxt: donot set hash type unnecessarily Ajit Khaparde
2017-10-31 0:32 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).